From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 28913@debbugs.gnu.org
Subject: [bug#28913] [PATCH 2/2] gnu: Add criu.
Date: Mon, 23 Oct 2017 08:07:30 +0200 [thread overview]
Message-ID: <87po9etn19.fsf@elephly.net> (raw)
In-Reply-To: <87h8uqyfgv.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/virtualization.scm (criu): New variable.
>
> [...]
>
>> + (replace 'configure
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + ;; The includes for libnl are located in a sub-directory.
>> + (setenv "C_INCLUDE_PATH"
>> + (string-append (assoc-ref inputs "libnl")
>> + "/include/libnl3:"
>> + (getenv "C_INCLUDE_PATH")))
>
> And there’s no libnet.pc or similar to provide the right -I flag?
There is a libnl-3.0.pc file with these contents:
--8<---------------cut here---------------start------------->8---
prefix=/gnu/store/qyr5m7c21a4myx5421m90yxkxav2qij7-libnl-3.4.0
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
Name: libnl
Description: Convenience library for netlink sockets
Version: 3.4.0
Libs: -L${libdir} -lnl-3
Cflags: -I${includedir}/libnl3
--8<---------------cut here---------------end--------------->8---
That’s not enough, though, to find header files included by other libnl
headers. Without the setenv snippet above compilation fails with this
error:
--8<---------------cut here---------------start------------->8---
In file included from criu/libnetlink.c:5:0:
/gnu/store/qyr5m7c21a4myx5421m90yxkxav2qij7-libnl-3.4.0/include/libnl3/netlink/attr.h:15:29: fatal error: netlink/netlink.h: No such file or directory
compilation terminated.
--8<---------------cut here---------------end--------------->8---
>> + (synopsis "Checkpoint and restore in userspace")
>
> “user space” (two words)?
Okay. Thanks for reviewing these patches!
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
next prev parent reply other threads:[~2017-10-23 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 19:09 [bug#28913] gnu: Add criu Ricardo Wurmus
2017-10-21 0:55 ` [bug#28913] [PATCH 1/2] gnu: Add libnet Ricardo Wurmus
2017-10-21 0:55 ` [bug#28913] [PATCH 2/2] gnu: Add criu Ricardo Wurmus
2017-10-22 22:39 ` Ludovic Courtès
2017-10-23 6:07 ` Ricardo Wurmus [this message]
2017-10-23 6:10 ` bug#28913: " Ricardo Wurmus
2017-10-23 16:25 ` [bug#28913] " Ludovic Courtès
2017-10-22 22:38 ` [bug#28913] [PATCH 1/2] gnu: Add libnet Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po9etn19.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=28913@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).