From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eKj54-0007rU-JJ
	for guix-patches@gnu.org; Fri, 01 Dec 2017 06:02:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eKj50-0004Nk-Fy
	for guix-patches@gnu.org; Fri, 01 Dec 2017 06:02:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:58679)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eKj50-0004Na-Bu
	for guix-patches@gnu.org; Fri, 01 Dec 2017 06:02:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eKj50-0001Nr-0f
	for guix-patches@gnu.org; Fri, 01 Dec 2017 06:02:02 -0500
Subject: [bug#29409] [PATCH] system: vm: Do not add EFI partition on ARM
	system.
Resent-Message-ID: <handler.29409.B29409.15121260895278@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <1512124720-29980-1-git-send-email-m.othacehe@gmail.com>
	<1512124720-29980-2-git-send-email-m.othacehe@gmail.com>
Date: Fri, 01 Dec 2017 12:01:27 +0100
In-Reply-To: <1512124720-29980-2-git-send-email-m.othacehe@gmail.com>
	(m. othacehe's message of "Fri, 1 Dec 2017 11:38:40 +0100")
Message-ID: <87po7yhfug.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: m.othacehe@gmail.com
Cc: 29409@debbugs.gnu.org

m.othacehe@gmail.com skribis:

> From: Mathieu Othacehe <m.othacehe@gmail.com>
>
> * gnu/system/vm.scm (qemu-img): Do not add EFI partition if we are target=
ting
>   ARM.
>
> UEFI support on u-boot is still experimental, so do not add EFI partition=
 on
> ARM for now.

[...]

> +                    ;; Append a small EFI System Partition for use with =
UEFI
> +                    ;; bootloaders if we are not targetting ARM.

+ =E2=80=9Cbecause UEFI support in U-Boot is experimental.=E2=80=9D

> +                    (if #$(target-arm32?)
> +                        '()

Also can you add something like:

  ;; FIXME: =E2=80=98target-arm32?=E2=80=99 may be not operate on the right
  ;; system/target values.  Rewrite using =E2=80=98let-system=E2=80=99 when=
 available.

OK with these changes, thank you!

And sorry for not completing =E2=80=98let-system=E2=80=99 in type.  I plan =
to resume
soonish but I figured I=E2=80=99d rather focus on the new release now.

Ludo=E2=80=99.