unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>, 30333@debbugs.gnu.org
Subject: [bug#30333] [PATCH] gnu: Add emacs-scratch-el.
Date: Wed, 14 Feb 2018 00:00:57 +0100	[thread overview]
Message-ID: <87po58wl3q.fsf@fastmail.com> (raw)
In-Reply-To: <20180203104703.16476-1-go.wigust@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2704 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> * gnu/packages/emacs.scm (emacs-scratch-el): New public variable.

[...]

> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 9523f14da..69d18b060 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -6940,3 +6940,41 @@ navigation with the grails mode.")
>  @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and
>  @kbd{C-<} to jump to the next and previous slide.")
>        (license license:gpl3+))))
> +
> +(define-public emacs-scratch-el
> +  (let ((commit "2cdf2b841ce7a0987093f65b0cc431947549f897")
> +        (revision "1"))
> +    (package
> +      (name "emacs-scratch-el")
> +      (version (string-append "1.2" revision "."
> +                              (string-take commit 7)))

You can use (git-version "1.2" revision commit) here.

(by the way, where does 1.2 come from?)

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/ieure/scratch-el.git")
> +                      (commit commit)))
> +                (file-name (string-append name "-" version "-checkout"))

Similarly, prefer (git-file-name ...).

> +                (sha256
> +                 (base32
> +                  "0wscsndynjmnliajqaz28r1ww81j8wh84zwaaswx51abhwgl0idf"))))
> +      (build-system emacs-build-system)
> +      (native-inputs
> +       `(("texinfo" ,texinfo)))
> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'install 'install-doc
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (unless (invoke "makeinfo" "scratch.texi")
> +                 (error "makeinfo failed"))
> +               (install-file "scratch.info"
> +                             (string-append (assoc-ref outputs "out")
> +                                            "/share/info")))))))

(install-file ...) has an unspecified return value, so return #t here.

> +      (home-page "https://github.com/ieure/scratch-el/")
> +      (synopsis "Create scratch buffers with the same mode current buffer")

s/same mode/same mode as/

Other than that LGTM.

> +      (description "Scratch is an extension to Emacs that enables one to create
> +scratch buffers that are in the same mode as the current buffer.  This is
> +notably useful when working on code in some language; you may grab code into a
> +scratch buffer, and, by virtue of this extension, do so using the Emacs
> +formatting rules for that language.")
> +      (license license:bsd-2))))
> -- 
> 2.15.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2018-02-13 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-03 10:47 [bug#30333] [PATCH] gnu: Add emacs-scratch-el Oleg Pykhalov
2018-02-13 23:00 ` Marius Bakke [this message]
2018-02-14 13:00   ` bug#30333: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po58wl3q.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=30333@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).