unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31237-done@debbugs.gnu.org
Subject: bug#31237: [PATCH] gnu: Add runc.
Date: Thu, 26 Apr 2018 09:39:58 +0800	[thread overview]
Message-ID: <87po2mg2z5.fsf@member.fsf.org> (raw)
In-Reply-To: <87fu3m45uy.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 23 Apr 2018 11:41:41 +0200")

ludo@gnu.org (Ludovic Courtès) writes:

> Hello,
>
> iyzsong@member.fsf.org (宋文武) skribis:
>
>> No I haven't, some fails are:
>>
>> --- FAIL: TestFactoryNewTmpfs (0.00s)
>> 	factory_linux_test.go:87: operation not permitted
>>
>> FAIL	github.com/opencontainers/runc/libcontainer	0.047s
>> ?   	github.com/opencontainers/runc/libcontainer/apparmor	[no test files]
>>
>> --- FAIL: TestInvalidCgroupPath (0.00s)
>> 	apply_raw_test.go:16: couldn't get cgroup root: mountpoint for
>> cgroup not found
>> 	apply_raw_test.go:25: couldn't get cgroup data: mountpoint for
>> cgroup not found
>> panic: runtime error: invalid memory address or nil pointer dereference [recovered]
>>
>> --- FAIL: TestValidateRootlessMountUid (0.00s)
>> 	rootless_test.go:96: Expected error to not occur when uid= not
>> set in mount options: rootfs (/var) does not exist
>> 	rootless_test.go:106: Expected error to not occur when setting
>> uid=0 in mount options: rootfs (/var) does not exist
>> 	rootless_test.go:112: Expected error to not occur when setting
>> uid=2 in mount options and UidMapping[0].size is 10
>>
>> --- FAIL: TestValidateValidSysctl (0.00s)
>> 	validator_test.go:229: Expected error to not occur with
>> {net.ctl=ctl} but got: "rootfs (/var) does not exist"
>> 	validator_test.go:229: Expected error to not occur with
>> {kernel.msgmax=ctl} but got: "rootfs (/var) does not exist"
>> 	validator_test.go:229: Expected error to not occur with
>> {fs.mqueue.ctl=ctl} but got: "rootfs (/var) does not exist"
>>
>> --- FAIL: TestNsenterValidPaths (0.01s)
>> 	nsenter_test.go:65: nsenter exits with a non-zero exit status
>>
>>
>> Look like it need /var, network namespace and other things?  But thoes
>> are unittest (runc also has integrationtest target)...  Need more
>> investment.
>
> Right.  For now I think we could skip all the tests above, with a
> comment explaining the reason (/var, cgroups, and apparmor unavailable
> in the build environment.)
>

Done, thank you!

      reply	other threads:[~2018-04-26  1:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22 12:58 [bug#31237] [PATCH] gnu: Add runc 宋文武
2018-04-22 22:08 ` Ludovic Courtès
2018-04-22 23:06   ` Nils Gillmann
2018-04-23  3:25     ` 宋文武
2018-04-23  9:41       ` Ludovic Courtès
2018-04-26  1:39         ` 宋文武 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po2mg2z5.fsf@member.fsf.org \
    --to=iyzsong@member.fsf.org \
    --cc=31237-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).