From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGXtP-0005MQ-1o
	for guix-patches@gnu.org; Wed, 09 May 2018 18:49:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGXtO-0001jf-6o
	for guix-patches@gnu.org; Wed, 09 May 2018 18:49:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47806)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fGXtO-0001jZ-33
	for guix-patches@gnu.org; Wed, 09 May 2018 18:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGXtN-0001qt-Ry
	for guix-patches@gnu.org; Wed, 09 May 2018 18:49:01 -0400
Subject: [bug#31386] [PATCH 2/3] gnu: Add gemmlowp-for-tensorflow.
Resent-Message-ID: <handler.31386.B31386.15259061027075@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180508145909.25354-1-ricardo.wurmus@mdc-berlin.de>
	<20180508145909.25354-2-ricardo.wurmus@mdc-berlin.de>
Date: Thu, 10 May 2018 00:48:12 +0200
In-Reply-To: <20180508145909.25354-2-ricardo.wurmus@mdc-berlin.de> (Ricardo
	Wurmus's message of "Tue, 8 May 2018 16:59:08 +0200")
Message-ID: <87po24v42b.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 31386@debbugs.gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> * gnu/packages/machine-learning.scm (gemmlowp-for-tensorflow): New variab=
le.

[...]

> +;; TODO: We may need to pass "-msse4.1" as an additional optimization fl=
ag
> +;; when building for x86_64.  This is strongly recommended by the author=
s in
> +;; the README.md.

It=E2=80=99d be nice to produce a patch to have =E2=80=9Cfunction multi-ver=
sioning=E2=80=9D for
the hot parts, as described at
<https://clearlinux.org/documentation/clear-linux/tutorials/fmv>.

> +(define-public gemmlowp-for-tensorflow
> +  (let ((commit "7c7c744640ddc3d0af18fb245b4d23228813a71b"))

Could you comment on how you chose this commit?  Is it because it starts
with =E2=80=9C7c7c=E2=80=9D?  ;-)

Otherwise LGTM!

Ludo=E2=80=99.