unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 32837-done@debbugs.gnu.org
Subject: bug#32837: [PATCH 0/5] Improvements to the UI with colors
Date: Fri, 28 Sep 2018 00:31:39 +0200	[thread overview]
Message-ID: <87pnwywp10.fsf@gnu.org> (raw)
In-Reply-To: <87in2qsyal.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 27 Sep 2018 18:25:06 +0200")

Hello,

Ricardo Wurmus <rekado@elephly.net> skribis:

>> Let me know what you think!  I’d be happy to go ahead with this variant
>> soon.  :-)
>
> I really like this patch series.  It implements a very flexible
> mechanism that allows us to track the build state more accurately.  In
> fact, it would enable a GUI developer to display the build progress in
> an intuitive way that is a few steps removed from the raw build log
> style.

Yeah, that’s my hope too.  We would need Fibers/coroutines to make a
neat (G)UI, and also better multiplexing of build logs when max-jobs > 1
(the “extended build traces” are not full proof: we can’t guarantee
they’ll appear at the beginning of a line currently), but it’s a first
step.

> I noticed a few typos in patch 4/5:

Fixed!

Thanks Danny for reviewing, and thank you Ricardo for reviewing,
testing, and for the suggestions, which led to a much improved patch!

> As to the way we display build progress: we can improve on that later.
> The mechanism proposed in this patch series is very nice and I’d love to
> see it merged soon.

I have a snippet here to estimate build time based on past build logs,
we’ll see…

I’ve pushed the patches as 240a9c69a6064544a616acc521c993542c364948,
with a daemon update in 5abcb1b0e6fe849d206b3683444c76d91f21a3d4.

Bug reports & suggestions welcome!

Ludo’.

      reply	other threads:[~2018-09-27 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 15:11 [bug#32837] [PATCH 0/5] Improvements to the UI with colors Ludovic Courtès
2018-09-25 15:32 ` [bug#32837] [PATCH 1/5] progress: 'progress-reporter-report!' takes any number of arguments Ludovic Courtès
2018-09-25 15:32   ` [bug#32837] [PATCH 2/5] substitute: Progress port really closes underlying port Ludovic Courtès
2018-09-26  7:58     ` Danny Milosavljevic
2018-09-25 15:32   ` [bug#32837] [PATCH 3/5] progress: Add 'display-download-progress' Ludovic Courtès
2018-09-26  7:59     ` Danny Milosavljevic
2018-09-25 15:32   ` [bug#32837] [PATCH 4/5] Add (guix status) and use it for pretty colored output Ludovic Courtès
2018-09-25 15:32   ` [bug#32837] [PATCH 5/5] perform-download: Optionally report a "download-progress" trace Ludovic Courtès
2018-09-26  7:58   ` [bug#32837] [PATCH 1/5] progress: 'progress-reporter-report!' takes any number of arguments Danny Milosavljevic
2018-09-27  9:59 ` [bug#32837] [PATCH 0/5] Improvements to the UI with colors Ludovic Courtès
2018-09-27 16:25   ` Ricardo Wurmus
2018-09-27 22:31     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnwywp10.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=32837-done@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).