From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45504)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gFR1b-0004QU-AS
	for guix-patches@gnu.org; Wed, 24 Oct 2018 17:49:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gFR1V-0007PZ-G2
	for guix-patches@gnu.org; Wed, 24 Oct 2018 17:49:11 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36628)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gFR1S-0007N7-OZ
	for guix-patches@gnu.org; Wed, 24 Oct 2018 17:49:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gFR1S-00034S-4G
	for guix-patches@gnu.org; Wed, 24 Oct 2018 17:49:02 -0400
Subject: [bug#33059] [PATCH 04/10] gnu: Add python-fenics-dijitso.
Resent-Message-ID: <handler.33059.B33059.154041770211755@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <1539682284-6446-1-git-send-email-pgarlick@tourbillion-technology.com>
	<1539682284-6446-4-git-send-email-pgarlick@tourbillion-technology.com>
Date: Wed, 24 Oct 2018 23:48:07 +0200
In-Reply-To: <1539682284-6446-4-git-send-email-pgarlick@tourbillion-technology.com>
	(Paul Garlick's message of "Tue, 16 Oct 2018 10:31:18 +0100")
Message-ID: <87pnvzxbhk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 33059@debbugs.gnu.org

Paul Garlick <pgarlick@tourbillion-technology.com> skribis:

> * gnu/packages/simulation.scm (python-fenics-dijitso): New varaible.

I agree with Efraim=E2=80=99s suggestion to use =E2=80=98with-directory-exc=
ursion=E2=80=99.

Nitpick:

> +      (home-page
> +      "https://bitbucket.org/fenics-project/dijitso/")

Indentation is off.

> +    (synopsis
> +      "Distributed just-in-time building of shared libraries")

Please keep =E2=80=98home-page=E2=80=99 and =E2=80=98synopsis=E2=80=99 on a=
 single line each.

Otherwise LGTM, thanks!

Ludo=E2=80=99.