From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gJbK8-0006YM-PI
	for guix-patches@gnu.org; Mon, 05 Nov 2018 04:37:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gJbJf-0000YI-Nj
	for guix-patches@gnu.org; Mon, 05 Nov 2018 04:37:27 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:58582)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gJbJe-0000MC-Lm
	for guix-patches@gnu.org; Mon, 05 Nov 2018 04:37:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gJbJe-0001II-5E
	for guix-patches@gnu.org; Mon, 05 Nov 2018 04:37:02 -0500
Subject: [bug#33265] [WIP RFC] services: Add file system monitor service.
Resent-Message-ID: <handler.33265.B33265.15414105644877@debbugs.gnu.org>
References: <20181105031833.7917-1-dannym@scratchpost.org>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <20181105031833.7917-1-dannym@scratchpost.org>
Date: Mon, 05 Nov 2018 10:36:00 +0100
Message-ID: <87pnvjn9xb.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 33265@debbugs.gnu.org

Hi Danny,

I don't have time to do a proper review, but just one comment:

Danny Milosavljevic <dannym@scratchpost.org> writes:

> +          (test-assert "file system monitor running"
> +            (marionette-eval
> +             '(begin
> +                (use-modules (gnu services herd))
> +                (match (start-service 'monitor-file-system)
> +                  (#f #f)
> +                  (('service response-parts ...)
> +                   (match (assq-ref response-parts 'running)
> +                     ((pid) (number? pid))))))
> +             marionette))

How is that better than:

    (test-assert "file system monitor running"
      (marionette-eval
       '(begin
         (use-modules (gnu services herd))
         (start-service 'monitor-file-system))
       marionette))

'start-service' should return #f if the service fails to start.

Cheers,
Cl=C3=A9ment