From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnpXH-0003Mg-L5 for guix-patches@gnu.org; Sun, 27 Jan 2019 13:52:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnpXG-0000La-TF for guix-patches@gnu.org; Sun, 27 Jan 2019 13:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gnpXG-0000LA-8q for guix-patches@gnu.org; Sun, 27 Jan 2019 13:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gnpXG-0006RP-6T for guix-patches@gnu.org; Sun, 27 Jan 2019 13:52:02 -0500 Subject: [bug#34222] [PATCH 08/15] gnu: Add ruby-rest-client. Resent-Message-ID: References: <87y376ghl0.fsf@cbaines.net> <20190127170820.28937-1-mail@cbaines.net> <20190127170820.28937-8-mail@cbaines.net> <87womqromp.fsf@elephly.net> From: Christopher Baines In-reply-to: <87womqromp.fsf@elephly.net> Date: Sun, 27 Jan 2019 18:51:36 +0000 Message-ID: <87pnsigchz.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34222@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Christopher Baines writes: > >> Required for ruby-ast. >> >> * gnu/packages/ruby.scm (ruby-rest-client): New variable. > > [=E2=80=A6] > >> + (modify-phases %standard-phases >> + (add-before 'check 'fix-dependencies >> + (lambda _ >> + (substitute* "rest-client.gemspec" >> + ((".*rubocop.*") "\n") >> + ((".*pry.*") "\n")) >> + #t)) > > Could you please add a comment here why this is necessary? I've updated the patch to say: + (add-before 'check 'remove-unnecessary-development-dependencies + (lambda _ + (substitute* "rest-client.gemspec" + ;; Remove rubocop as it's unused. Rubocop also indirectly + ;; depends on this package through ruby-parser and ruby-ast= so + ;; this avoids a dependency loop. + ((".*rubocop.*") "\n") + ;; Remove pry as it's unused, it's a debugging tool + ((".*pry.*") "\n")) Hopefully that is a bit clearer. >> + (description >> + "@code{rest-client} provides a simple HTTP and REST client for Rub= y, >> +inspired by the Sinatra microframework style of specifying actions: get= , put, >> +post, delete.") > > I would wrap =E2=80=9Cget=E2=80=9D, =E2=80=9Cput=E2=80=9D, =E2=80=9Cpost= =E2=80=9D, and =E2=80=9Cdelete=E2=80=9D in @code{=E2=80=A6}. Ok, I've updated the patch to do this now. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxN/bhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcwgA/+J3qzGnnkX+Jpci2lxJp2C7Po9cTFhaHKUvq0ZNhluvJ8O4MUHeWNn7Zy Qz+mNQ9DA9YFphGHZJeEdwFA5DCRgeNI9EwBjbGPnWdM/F6dGB4chm+4VP6Igc/0 0TTgZ398csX91Hxtsc0aeSJwOiUjvHgLdKEPRWZ7NNZXl8xXGtfsvCFpjv6LggSn hz/96x2SSv5xIhHd5CIt/VscenwRI/U0qHn8sxz+u+OJiVHyD0IvQ2SBgrtTN/XN VJQY05K1EQj9ekXDJdaaxe/TB8QRLNuMKPOJZkZPNXUj1lXIn9yiTBDy5CrDiL/r z8HjeTonhtt02ECT9H21bXzwSP0wZyMgKgROrwm884zxW4jHkTNsrq+dKbj6MZfC 8g6bF2IL1la0M9g1+oJFroM1ffWCM3m4w6ondY80X6iQq6UPlMV1PwlW5tjugmXy N50muNim60AP6NDffjql5iYq2LEu6IXroc2mkkuDi7a/676Jn4pVy9wrkSwqEiu2 pUgk2CcuP41A6YJOmoYJyZXtdURZYYmp/7ApbqrociR31sQhatJttNmvqd6RJAm0 7WGEdMN6luO3iVdro3Zr3PSfDtFlzz9H/BE10HqJ20PrXo1U8QqsQoOi/WShhYfJ MrDg1G2gkPIcxpaFIUmuYwJZhsnfVlSTO2UvMT1Ej6PiNaXUUK4= =dKeJ -----END PGP SIGNATURE----- --=-=-=--