From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:33375)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7RcF-0000Ec-HN
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:22:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7RUb-0000kP-G7
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:14:23 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41187)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h7RUK-0000Ys-Hx
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:14:16 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7RUK-0000V9-CK
	for guix-patches@gnu.org; Fri, 22 Mar 2019 17:14:04 -0400
Subject: [bug#34758] [PATCH 2/4] gnu: Add vhba.
Resent-Message-ID: <handler.34758.B34758.15532892131873@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190305172620.20118-1-mail@ambrevar.xyz>
	<20190305172853.21358-1-mail@ambrevar.xyz>
Date: Fri, 22 Mar 2019 22:12:50 +0100
In-Reply-To: <20190305172853.21358-1-mail@ambrevar.xyz> (Pierre Neidhardt's
	message of "Tue, 5 Mar 2019 18:28:51 +0100")
Message-ID: <87pnqi3965.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34758@debbugs.gnu.org

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> * gnu/packages/cdrom.scm (vhba): New variable.

[...]

> +       (modify-phases %standard-phases
> +         ;; TODO: Compress kernel modules?
> +         ;; TODO: Build does not work because it needs the Makefile in
> +         ;; /lib/modules/$(KERNELRELEASE)/build which we don't ship in G=
uix.
> +         (delete 'configure))))

So it doesn=E2=80=99t build, right?  In that case I=E2=80=99d rather not ad=
d it.  :-)

It=E2=80=99s true that /build is a dangling link:

--8<---------------cut here---------------start------------->8---
$ readlink $(guix build linux-libre)/lib/modules/5.0.2-gnu/build
/tmp/guix-build-linux-libre-5.0.2.drv-0/linux-5.0.2
--8<---------------cut here---------------end--------------->8---

Ludo=E2=80=99.