From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7zy3-0004bn-Qb for guix-patches@gnu.org; Sun, 24 Mar 2019 06:03:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7zy2-0003om-FL for guix-patches@gnu.org; Sun, 24 Mar 2019 06:03:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7zy2-0003oi-5q for guix-patches@gnu.org; Sun, 24 Mar 2019 06:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h7zy2-0000MH-1D for guix-patches@gnu.org; Sun, 24 Mar 2019 06:03:02 -0400 Subject: [bug#34959] Acknowledgement ([PATCH] Add Multiple Common Lisp Packages) Resent-Message-ID: References: <87pnqh4acd.fsf@gmail.com> <87lg15493r.fsf@gmail.com> From: Ricardo Wurmus In-reply-to: <87lg15493r.fsf@gmail.com> Date: Sun, 24 Mar 2019 11:01:37 +0100 Message-ID: <87pnqg616m.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Katherine Cox-Buday Cc: 34959@debbugs.gnu.org Hi Katherine, > Of course as soon as I push it up and review it I find all the junk i > left in. Here's a cleaner patch, with apologies. > > From d40bd8e4b7b2637b088ea3c14825fd4062625e22 Mon Sep 17 00:00:00 2001 > From: Katherine Cox-Buday > Date: Sat, 23 Mar 2019 15:01:11 -0500 > Subject: [PATCH] Add Multiple Common Lisp Packages thank you for the patch! We usually expect one commit per independent change. Could you please split up this patch into multiple commits? You can group package variants like =E2=80=9Csbcl-trivial-backtrace=E2=80=9D and =E2=80=9Ccl-triv= ial-backtrace=E2=80=9D, but separate packages generally each should have their own commit. > +(define-public sbcl-trivial-backtrace > + (let ((commit-hash "ca81c011b86424a381a7563cea3b924f24e6fbeb")) > + (package > + (name "sbcl-trivial-backtrace") > + (synopsis "Portable simple API to work with backtraces in Common Li= sp") > + (description "On of the many things that didn't quite get into the = Common Lisp standard was how to get a Lisp to output its call stack when so= mething has gone wrong. As such, each Lisp has developed its own notion of = what to display, how to display it, and what sort of arguments can be used = to customize it. trivial-backtrace is a simple solution to generating a bac= ktrace portably.") Please break up long lines like this. Please run =E2=80=9C./pre-inst-env g= uix lint sbcl-trivial-backtrace=E2=80=9D, which will tell you about this proble= m. > + (home-page "https://common-lisp.net/project/trivial-backtrace/") > + (license license:bsd-style) > + (version (string-append "0.0.0-" (string-take commit-hash 7))) Please use =E2=80=9Cgit-version=E2=80=9D here. Please also use a revision = string, which allows us to build version strings that can be sorted, e.g. when the base version is unchanged and a newer commit is =E2=80=9Csmaller=E2=80=9D t= han the previous one. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/gwkkwg/trivial-backtrace.git") > + (commit commit-hash))) Throughout you can use =E2=80=9Ccommit=E2=80=9D instead of =E2=80=9Ccommit-= hash=E2=80=9D =E2=80=94 there is no naming conflict. > + (sha256 (base32 "10p41p43skj6cimdg8skjy7372s8v2xpkg8djjy0l8rm45i6= 54k1")))) > + (inputs > + `(("sbcl-lift" ,sbcl-lift))) > + (build-system asdf-build-system/sbcl)))) Generally, I would like to suggest to keep the order of fields consistent with the order used in other packages: name, source, build-system, arguments, {native-,propagated-,}inputs, home-page, synopsis, description, license. -- Ricardo