unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35207-done@debbugs.gnu.org
Subject: bug#35207: [PATCH] Resurrect pplacer.
Date: Thu, 11 Apr 2019 17:23:21 +0200	[thread overview]
Message-ID: <87pnpsin12.fsf@elephly.net> (raw)
In-Reply-To: <87sguoio9r.fsf@elephly.net>


Ricardo Wurmus <rekado@elephly.net> writes:

> Julien Lepiller <julien@lepiller.eu> writes:
>
>> Le 11 avril 2019 14:55:44 GMT+02:00, Ricardo Wurmus <rekado@elephly.net> a écrit :
>>>
>>>Ricardo Wurmus <rekado@elephly.net> writes:
>>>
>>>> Julien Lepiller <julien@lepiller.eu> writes:
>>>>
>>>>> What's the most recent version of ocaml pplacer can use?
>>>>
>>>> It’s actually 4.01.  I don’t know how much effort it’s going to be to
>>>> make it work with the latest version.
>>>
>>>I gave patching pplacer a try, but in more recent versions of OCaml
>>>strings are byte streams, so it’s quite a bit of work to figure out
>>>where exactly to convert strings to byte streams and back again.
>>>
>>>I’ll keep working on this for a while, but for now I’d like to get
>>>pplacer resurrected with 4.02 first.
>>>
>>>--
>>>Ricardo
>>
>> Ok, I guess it's acceptable. I'll fully review your patches later today.
>
> Thanks for the offer, but it won’t be necessary after all.  I figured
> out how to make it work with the latest OCaml.  I had to also patch
> ocaml-mcl, but that seems okay.
>
> New patches coming in a few minutes!

I pushed the new patches to the “master” branch with commit 12327d7447.

-- 
Ricardo

      reply	other threads:[~2019-04-11 15:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 13:00 [bug#35207] [PATCH] Resurrect pplacer Ricardo Wurmus
2019-04-09 13:13 ` [bug#35207] [PATCH 1/3] gnu: Add ocaml4.02-mcl Ricardo Wurmus
2019-04-09 13:13   ` [bug#35207] [PATCH 2/3] gnu: Add ocaml4.02-gsl Ricardo Wurmus
2019-04-09 13:13   ` [bug#35207] [PATCH 3/3] gnu: Add pplacer Ricardo Wurmus
2019-04-09 17:12 ` [bug#35207] [PATCH] Resurrect pplacer Julien Lepiller
2019-04-09 17:41   ` Ricardo Wurmus
2019-04-11 12:55     ` Ricardo Wurmus
2019-04-11 13:02       ` Julien Lepiller
2019-04-11 14:56         ` Ricardo Wurmus
2019-04-11 15:23           ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnpsin12.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=35207-done@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).