From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:43374)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfKWB-0005oy-IK
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:40:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfKWA-0000f8-ID
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:40:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42005)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hfKWA-0000en-E9
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfKWA-0002BP-72
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:40:02 -0400
Subject: [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type.
Resent-Message-ID: <handler.35790.B35790.15613655828358@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190518093206.22069-1-mail@cbaines.net> <878suz27ke.fsf@gnu.org>
 <87ef4dxgvl.fsf@cbaines.net> <87pnnpj15u.fsf@gnu.org>
 <87h88pu1cc.fsf@cbaines.net> <875zp0lbmx.fsf@gnu.org>
 <875zovmqey.fsf@cbaines.net>
Date: Mon, 24 Jun 2019 10:39:32 +0200
In-Reply-To: <875zovmqey.fsf@cbaines.net> (Christopher Baines's message of
 "Mon, 24 Jun 2019 07:46:29 +0100")
Message-ID: <87pnn3cr7f.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35790@debbugs.gnu.org

Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

> Thanks, so if I set the bindtextdomain, things do indeed work
> better. So, regarding these two patches, I've got the following things
> on my mind...
>
>  - As they change so many things, I'm not sure what to add for the GNU
>    changelog at the end of the commit message?

I think you should try to write the commit log the usual way, by
listing every changed entity.  It=E2=80=99s a bit tedious, but it=E2=80=99s=
 also a good
way to review everything (and Magit makes it relatively easy.)

Now, don=E2=80=99t lose your hair on it, it=E2=80=99s not the most importan=
t part of the
patch.  :-)

>  - Is it OK to break some of the translations, or should I fix some of
>    those as well?
>
>    - I'm thinking of the "proposed synopsis" related check specifically,
>      as I've changed what goes in to the translated string.

Actually I didn=E2=80=99t see the change you=E2=80=99re referring to, but m=
aybe it
doesn=E2=80=99t matter much.

>  - How ready are these patches to merge? I don't know of any problems
>    with them, but I am making lots of changes.

I think it=E2=80=99s ready.

Thanks, and sorry for the delays!

Ludo=E2=80=99.