From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:46777)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hlwgV-0006LD-7Z
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:38:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hlwgU-00062c-79
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:38:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:59902)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hlwgU-00062G-2S
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:38:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hlwgT-00083L-S0
 for guix-patches@gnu.org; Fri, 12 Jul 2019 10:38:01 -0400
Subject: [bug#35790] [PATCH 1/2] lint: Move the linting code to a different
 module.
Resent-Message-ID: <handler.35790.B35790.156294222330821@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87a7dyoryh.fsf@gnu.org> <20190702192542.16179-1-mail@cbaines.net>
Date: Fri, 12 Jul 2019 16:36:44 +0200
In-Reply-To: <20190702192542.16179-1-mail@cbaines.net> (Christopher Baines's
 message of "Tue, 2 Jul 2019 20:25:41 +0100")
Message-ID: <87pnmfgw03.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35790@debbugs.gnu.org

Hi,

I think this could have come as a subsequent patch, but regardless, this
is a welcome move.

Christopher Baines <mail@cbaines.net> skribis:

> To try and move towards making programatic access to the linting code eas=
ier,
> this commit separates out the linting script, from the linting functional=
ity
> that it uses.

For the final version, please write a change log.

> +(define-module (guix lint)
> +  #:use-module ((guix store) #:hide (close-connection))
> +  #:use-module (guix base32)
> +  #:use-module (guix download)
> +  #:use-module (guix ftp-client)
> +  #:use-module (guix http-client)
> +  #:use-module (guix packages)
> +  #:use-module (guix licenses)
> +  #:use-module (guix records)
> +  #:use-module (guix grafts)
> +  #:use-module (guix ui)

The principle that=E2=80=99s mostly followed for Guix modules is that they =
are
UI-independent: they might throw =E2=80=98&message=E2=80=99 error condition=
s, they might
even use (guix i18n), but they usually don=E2=80=99t depend on (guix ui).

The idea is separation of concerns: the actual UI implementation details
(TUI, GUI, etc.) remain separate from the API.

At first sight (guix ui) is not necessary here, and it=E2=80=99s enough to =
use
(guix i18n), isn=E2=80=99t it?

Last thing: please add this new file to po/guix/POTFILES.in.

Thanks for working on it!

Ludo=E2=80=99.