unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37738] [PATCH] gnu: add lxqt-connman-applet
@ 2019-10-13 18:49 Reza Alizadeh Majd
  2019-10-18  9:45 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-10-13 18:49 UTC (permalink / raw)
  To: 37738

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

Hi, 
I added a new package related to LXQt stuff: lxqt-connman-applet
could you please check and add it package repositories? thanks. 

--
Regards
Reza Alizadeh Majd
PantherX Team

[-- Attachment #2: 0001-gnu-add-lxqt-connman-applet.patch --]
[-- Type: application/octet-stream, Size: 2460 bytes --]

From c3756518da1289ec7f7cc803e624632aa21aed01 Mon Sep 17 00:00:00 2001
From: Reza Alizadeh Majd <r.majd@pantherx.org>
Date: Sun, 13 Oct 2019 20:55:21 +0330
Subject: [PATCH] gnu: add lxqt-connman-applet

* gnu/packages/lxqt.scm (lxqt-connman-applet) New variable.
---
 gnu/packages/lxqt.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index e5487d3ae4..d9199f2097 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1279,6 +1279,48 @@ easily publishing them on internet image hosting services.")
 like @command{tar} and @command{zip}.")
     (license license:gpl2+)))
 
+(define-public lxqt-connman-applet
+  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
+        (revision "0"))
+    (package
+      (name "lxqt-connman-applet")
+      (version (git-version "0.14.1" revision commit))
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+            (url (string-append "https://github.com/lxqt/" name ".git"))
+            (commit commit)))
+          (file-name (git-file-name name version))
+          (sha256 (base32 "1brkyzjmpa7hiv8p8rvmkcgagchh2zn71ry4pjiplga05as3jc11"))))
+      (build-system cmake-build-system)
+      (inputs
+        `(("kwindowsystem" ,kwindowsystem)
+          ("qtbase" ,qtbase)
+          ("qtsvg" ,qtsvg)
+          ("liblxqt" ,liblxqt)
+          ("qtx11extras" ,qtx11extras)
+          ("libqtxdg" ,libqtxdg)))
+      (native-inputs
+        `(("lxqt-build-tools" ,lxqt-build-tools)
+          ("qtlinguist" ,qttools)))
+      (arguments
+        `(#:tests? #f
+          #:phases
+            (modify-phases %standard-phases
+              (add-after 'unpack 'patch-translations-dir
+                (lambda* (#:key outputs #:allow-other-keys)
+                  (substitute* "CMakeLists.txt"
+                    (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
+                     (string-append (assoc-ref outputs "out")
+                                    "/share/lxqt/translations"))
+                    (("\\$\\{LXQT_ETC_XDG_DIR\\}") "etc/xdg"))
+                  #t)))))
+      (home-page "https://github.com/lxqt/lxqt-connman-applet")
+      (synopsis "System-tray applet for connman")
+      (description "LXQt based system-tray applet for connman")
+      (license license:lgpl2.1+))))
+
 ;; The LXQt Desktop Environment
 
 (define-public lxqt
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#37738] [PATCH] gnu: add lxqt-connman-applet
  2019-10-13 18:49 [bug#37738] [PATCH] gnu: add lxqt-connman-applet Reza Alizadeh Majd
@ 2019-10-18  9:45 ` Ludovic Courtès
  2019-10-18 13:34   ` Reza Alizadeh Majd
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2019-10-18  9:45 UTC (permalink / raw)
  To: Reza Alizadeh Majd; +Cc: 37738

Hi Reza,

"Reza Alizadeh Majd" <r.majd@pantherx.org> skribis:

> From c3756518da1289ec7f7cc803e624632aa21aed01 Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd@pantherx.org>
> Date: Sun, 13 Oct 2019 20:55:21 +0330
> Subject: [PATCH] gnu: add lxqt-connman-applet
>
> * gnu/packages/lxqt.scm (lxqt-connman-applet) New variable.

Nice.  A few comments/questions:

> +(define-public lxqt-connman-applet
> +  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
> +        (revision "0"))

Why did you choose this specific commit?

Normally we only package upstream releases (tags); we resort to commits
in between releases only when there’s a good reason to do that, and in
that cases it’s better to add a comment explaining why we did that.

> +      (arguments
> +        `(#:tests? #f

Could you add a comment explaining why tests are disabled?

> +      (home-page "https://github.com/lxqt/lxqt-connman-applet")
> +      (synopsis "System-tray applet for connman")
> +      (description "LXQt based system-tray applet for connman")

Please write a full description:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Apart from that the patch LGTM.

Could you send an updated patch?

Thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#37738] [PATCH] gnu: add lxqt-connman-applet
  2019-10-18  9:45 ` Ludovic Courtès
@ 2019-10-18 13:34   ` Reza Alizadeh Majd
  2019-10-18 21:20     ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-10-18 13:34 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 37738

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

Hi Ludo, 


> Nice.  A few comments/questions:
> 
>> +(define-public lxqt-connman-applet
>> +  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
>> +        (revision "0"))
> 
> Why did you choose this specific commit?
> 
> Normally we only package upstream releases (tags); we resort to commits
> in between releases only when there’s a good reason to do that, and in
> that cases it’s better to add a comment explaining why we did that.

since the package developers didn’t release a specific version so I 
decided to choose their latest commit in `master` branch. besides that 
I had tested the applet on LXQt desktop and it works without issues. 


>> +      (arguments
>> +        `(#:tests? #f
> 
> Could you add a comment explaining why tests are disabled?

OK, sure, I will submit updated patch ASAP. 


>> +      (home-page "https://github.com/lxqt/lxqt-connman-applet")
>> +      (synopsis "System-tray applet for connman")
>> +      (description "LXQt based system-tray applet for connman")
> 
> Please write a full description:
> 
>  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

unfortunately the original developers didn’t provide any further 
details about this package yet. so is it OK to write a description 
about this package by myself? 



Regards,
Reza


[-- Attachment #2: Type: text/html, Size: 3604 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#37738] [PATCH] gnu: add lxqt-connman-applet
  2019-10-18 13:34   ` Reza Alizadeh Majd
@ 2019-10-18 21:20     ` Ludovic Courtès
  2019-10-19 11:54       ` Reza Alizadeh Majd
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2019-10-18 21:20 UTC (permalink / raw)
  To: Reza Alizadeh Majd; +Cc: 37738

Hi,

"Reza Alizadeh Majd" <r.majd@pantherx.org> skribis:

>> Nice.  A few comments/questions:
>> 
>>> +(define-public lxqt-connman-applet
>>> +  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
>>> +        (revision "0"))
>> 
>> Why did you choose this specific commit?
>> 
>> Normally we only package upstream releases (tags); we resort to commits
>> in between releases only when there’s a good reason to do that, and in
>> that cases it’s better to add a comment explaining why we did that.
>
> since the package developers didn’t release a specific version so I 
> decided to choose their latest commit in `master` branch. besides that 
> I had tested the applet on LXQt desktop and it works without issues. 

Oh, I see (I thought there was a 0.14.1 release, but there’s no such
thing on github.com.)

>> Please write a full description:
>> 
>>  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
>
> unfortunately the original developers didn’t provide any further 
> details about this package yet. so is it OK to write a description 
> about this package by myself? 

Yes, sure!

Thank you,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#37738] [PATCH] gnu: add lxqt-connman-applet
  2019-10-18 21:20     ` Ludovic Courtès
@ 2019-10-19 11:54       ` Reza Alizadeh Majd
  2019-10-20 21:26         ` bug#37738: " Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-10-19 11:54 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 37738

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Hi Ludo, 

I updated the patch file based on mentioned requirements. so could you please
check if this recent patch meets the requirements to be submitted to guix repository?


Thank you,
Reza

[-- Attachment #2: 0001-gnu-add-lxqt-connman-applet.patch --]
[-- Type: application/octet-stream, Size: 2691 bytes --]

From d59861d1b422d1fd1b61fec9bf7d01f9aa6f8816 Mon Sep 17 00:00:00 2001
From: Reza Alizadeh Majd <r.majd@pantherx.org>
Date: Sun, 13 Oct 2019 20:55:21 +0330
Subject: [PATCH] gnu: add lxqt-connman-applet

* gnu/packages/lxqt.scm (lxqt-connman-applet) New variable.
---
 gnu/packages/lxqt.scm | 45 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index e5487d3ae4..375fb1ffe1 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1279,6 +1279,51 @@ easily publishing them on internet image hosting services.")
 like @command{tar} and @command{zip}.")
     (license license:gpl2+)))
 
+(define-public lxqt-connman-applet
+  ;; since the main developers didn't release any version yet,  their 
+  ;; latest commit on `master` branch at the moment used for this version.
+  (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
+        (revision "0"))
+    (package
+      (name "lxqt-connman-applet")
+      (version (git-version "0.14.1" revision commit))
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+            (url (string-append "https://github.com/lxqt/" name ".git"))
+            (commit commit)))
+          (file-name (git-file-name name version))
+          (sha256 (base32 "1brkyzjmpa7hiv8p8rvmkcgagchh2zn71ry4pjiplga05as3jc11"))))
+      (build-system cmake-build-system)
+      (inputs
+        `(("kwindowsystem" ,kwindowsystem)
+          ("qtbase" ,qtbase)
+          ("qtsvg" ,qtsvg)
+          ("liblxqt" ,liblxqt)
+          ("qtx11extras" ,qtx11extras)
+          ("libqtxdg" ,libqtxdg)))
+      (native-inputs
+        `(("lxqt-build-tools" ,lxqt-build-tools)
+          ("qtlinguist" ,qttools)))
+      (arguments
+        `(#:tests? #f                   ; no tests
+          #:phases
+            (modify-phases %standard-phases
+              (add-after 'unpack 'patch-translations-dir
+                (lambda* (#:key outputs #:allow-other-keys)
+                  (substitute* "CMakeLists.txt"
+                    (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
+                     (string-append (assoc-ref outputs "out")
+                                    "/share/lxqt/translations"))
+                    (("\\$\\{LXQT_ETC_XDG_DIR\\}") "etc/xdg"))
+                  #t)))))
+      (home-page "https://github.com/lxqt/lxqt-connman-applet")
+      (synopsis "System-tray applet for connman")
+      (description "Qt based system-tray applet for @code{connman},
+originally developed for @code{lxqt} desktop.")
+      (license license:lgpl2.1+))))
+
 ;; The LXQt Desktop Environment
 
 (define-public lxqt
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#37738: [PATCH] gnu: add lxqt-connman-applet
  2019-10-19 11:54       ` Reza Alizadeh Majd
@ 2019-10-20 21:26         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2019-10-20 21:26 UTC (permalink / raw)
  To: Reza Alizadeh Majd; +Cc: 37738-done

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi,

"Reza Alizadeh Majd" <r.majd@pantherx.org> skribis:

> From d59861d1b422d1fd1b61fec9bf7d01f9aa6f8816 Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd@pantherx.org>
> Date: Sun, 13 Oct 2019 20:55:21 +0330
> Subject: [PATCH] gnu: add lxqt-connman-applet
>
> * gnu/packages/lxqt.scm (lxqt-connman-applet) New variable.

Great!  Applied with the minor tweak below to make the description a
full sentence and give a bit of context.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 707 bytes --]

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 375fb1ffe1..8d5d3522ec 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1320,8 +1320,9 @@ like @command{tar} and @command{zip}.")
                   #t)))))
       (home-page "https://github.com/lxqt/lxqt-connman-applet")
       (synopsis "System-tray applet for connman")
-      (description "Qt based system-tray applet for @code{connman},
-originally developed for @code{lxqt} desktop.")
+      (description "This package provides a Qt-based system-tray applet for
+the network management tool Connman, originally developed for the LXQT
+desktop.")
       (license license:lgpl2.1+))))
 
 ;; The LXQt Desktop Environment

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-20 21:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-13 18:49 [bug#37738] [PATCH] gnu: add lxqt-connman-applet Reza Alizadeh Majd
2019-10-18  9:45 ` Ludovic Courtès
2019-10-18 13:34   ` Reza Alizadeh Majd
2019-10-18 21:20     ` Ludovic Courtès
2019-10-19 11:54       ` Reza Alizadeh Majd
2019-10-20 21:26         ` bug#37738: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).