From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:60874) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idmdB-0005MG-KQ for guix-patches@gnu.org; Sat, 07 Dec 2019 21:49:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idmd9-00074E-Vb for guix-patches@gnu.org; Sat, 07 Dec 2019 21:49:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idmd4-000714-FC for guix-patches@gnu.org; Sat, 07 Dec 2019 21:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idmd4-0008E3-E2 for guix-patches@gnu.org; Sat, 07 Dec 2019 21:49:02 -0500 Subject: [bug#38460] [PATCH 1/1] lint: Add '--load-path' option. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20191202204759.28329-1-zimon.toutoune@gmail.com> <20191202210127.28466-1-zimon.toutoune@gmail.com> <87blsoc8yv.fsf@gnu.org> Date: Sat, 07 Dec 2019 23:51:39 +0100 In-Reply-To: (zimoun's message of "Wed, 4 Dec 2019 19:21:45 +0100") Message-ID: <87pngzsq9w.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: zimoun Cc: 38460@debbugs.gnu.org Hi! zimoun skribis: > On Wed, 4 Dec 2019 at 18:10, Ludovic Court=C3=A8s wrote: > >> zimoun skribis: >> >> > * guix/scripts/lint.scm (%options): Add '--load-path' option. >> > * tests/guix-lint.sh: Test it. >> >> Awesome, I=E2=80=99ve been wanting that for a long time. :-) > > But I find this "hacky". Because it is copy/paste from other > --load-path option elsewhere (probably "guix show" :-)). Well, technically speaking it=E2=80=99s not copy/pasted since the code you = sent uses =E2=80=98find=E2=80=99 to grab the option; plus, we=E2=80=99re talking= about very few lines, which is typically hard to factorize. So I sympathize with the bad feeling of repetition, but I=E2=80=99m not qui= te sure how this can be avoided in this case. WDYT? Thanks, Ludo=E2=80=99.