From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eEQ9JGRKHF+LfgAA0tVLHw (envelope-from ) for ; Sat, 25 Jul 2020 15:06:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MJsKIGRKHF/bZQAAbx9fmQ (envelope-from ) for ; Sat, 25 Jul 2020 15:06:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C4C79400BB for ; Sat, 25 Jul 2020 15:06:12 +0000 (UTC) Received: from localhost ([::1]:42272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLkZ-0006Go-5i for larch@yhetil.org; Sat, 25 Jul 2020 11:06:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzLkQ-0006Dv-DV for guix-patches@gnu.org; Sat, 25 Jul 2020 11:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzLkQ-0000U4-40 for guix-patches@gnu.org; Sat, 25 Jul 2020 11:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzLkP-0003Ga-Vf for guix-patches@gnu.org; Sat, 25 Jul 2020 11:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jul 2020 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42030 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42030-done@debbugs.gnu.org Received: via spool by 42030-done@debbugs.gnu.org id=D42030.159568953512510 (code D ref 42030); Sat, 25 Jul 2020 15:06:01 +0000 Received: (at 42030-done) by debbugs.gnu.org; 25 Jul 2020 15:05:35 +0000 Received: from localhost ([127.0.0.1]:50801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLjy-0003Fi-Ug for submit@debbugs.gnu.org; Sat, 25 Jul 2020 11:05:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLjx-0003FW-Bn for 42030-done@debbugs.gnu.org; Sat, 25 Jul 2020 11:05:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45306) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLjr-0000Ky-Oa; Sat, 25 Jul 2020 11:05:27 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:38510 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jzLjq-0002uz-FR; Sat, 25 Jul 2020 11:05:27 -0400 From: Marius Bakke In-Reply-To: <87h7utc3a7.fsf@gnu.org> References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> <87r1u3trx8.fsf@gnu.org> <87o8p2ayaj.fsf@gnu.org> <87h7utc3a7.fsf@gnu.org> Date: Sat, 25 Jul 2020 17:05:08 +0200 Message-ID: <87pn8jvdnf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: AwRGiytxy/rG --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Marius Bakke skribis: > >> Ludovic Court=C3=A8s writes: >> >>>> I think we should export %guix-channel-introduction, or alternatively >>>> add a %default-guix-channel that can be inherited, for easy access in >>>> custom channels.scm files. WDYT? >>> >>> The idea was to expose only =E2=80=98%default-channels=E2=80=99, which = leaves room for >>> the possibility of having multiple channels by default. I=E2=80=99d ra= ther >>> avoid exposing the individual bits as that=E2=80=99s a bit of an additi= onal >>> committment. >>> >>> But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix c= hannel is >>> automatically added anyway (commit >>> c3f6f564e909ebefe752d24b325871a4e3a02d40). >> >> It is only added for people using the default channel URL, and not for >> local mirrors that may well be authenticated. E.g. (url "/some/dir") or >> (url "https://github.com/guix-mirror/guix"). >> >> Would it make sense to remove the %default-channel-url check from >> ensure-default-introductions? I think we can safely assume that a >> channel named 'guix is _the_ Guix channel regardless of where it came >> from, and if users need to override the introduction they can just do >> that. > > I don=E2=80=99t think we can do that: if someone who=E2=80=99s not curren= tly a committer > wants to publish a fork, they=E2=80=99ll also publish a different introdu= ction, > pointing to the first commit where they=E2=80=99re in =E2=80=98.guix-auth= orizations=E2=80=99. Right. >> Currently I do this to access the channel introduction, which seems >> needlessly complicated: >> >> (use-modules (srfi srfi-1)) >> (let ((guix-channel (find (lambda (channel) >> (eq? 'guix (channel-name channel))) >> %default-channels))) > > You can write: (find guix-channel? %default-channels). Ah, much better. >> (list [other channels omitted] >> (channel >> (inherit guix-channel) >> (url "/home/marius/src/guix")))) > > I=E2=80=99m hesitant. We can publish =E2=80=98%guix-channel-introduction= =E2=80=99 if it helps, > but it=E2=80=99s a slight maintenance constraint for a slight improvement= . :-) > WDYT? I'm happy with the 'find guix-channel?' trick for now. Let's see if other users report workflow issues before changing anything. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cSiQACgkQoqBt8qM6 VPpGeAf/eJCvs5Sln+YY2Jq16FBmLq2oRNtxC/vYrPUsK0rI/Gqxr1gDGoX0X8SX cBwr0oDuBYHSOIUbAdTGImCqhE0CBbjnxb5K1FNu0YUHBNylMboOiwK6a0YnHYZg PP7MCJ0TpLaz2X0fWn+Qw5G+k8EjT0ON9WxRBS2flREUx/tnHaR2IRRFVyGmwefJ IXTV/vI4wT1Ig6cEBbpslRjV4QfspPGZjkc/bRQW79uEGDcOaKIShl+JJ/NaTKnG LZU3uoOdMGYpUx7x3Oo4SngoF6LAz08AHUsUzC/KFOVZc1fUa7oqR5dfZbwUUDPX FIr+xvgDEKfDja9cHrHfREzVJ+ZP6Q== =RmKC -----END PGP SIGNATURE----- --=-=-=--