From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oMfhBmL7TF/VGgAA0tVLHw (envelope-from ) for ; Mon, 31 Aug 2020 13:30:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sMmXAmL7TF9kGQAAbx9fmQ (envelope-from ) for ; Mon, 31 Aug 2020 13:30:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5DF9B9404C7 for ; Mon, 31 Aug 2020 13:30:09 +0000 (UTC) Received: from localhost ([::1]:55168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjst-0007ys-G5 for larch@yhetil.org; Mon, 31 Aug 2020 09:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCjsp-0007yS-8i for guix-patches@gnu.org; Mon, 31 Aug 2020 09:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCjso-0001Fp-Va for guix-patches@gnu.org; Mon, 31 Aug 2020 09:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCjso-0006jd-Jp for guix-patches@gnu.org; Mon, 31 Aug 2020 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42192] [PATCH 0/3] Improve launchpad updater Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Aug 2020 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 42192@debbugs.gnu.org Received: via spool by 42192-submit@debbugs.gnu.org id=B42192.159888058725849 (code B ref 42192); Mon, 31 Aug 2020 13:30:02 +0000 Received: (at 42192) by debbugs.gnu.org; 31 Aug 2020 13:29:47 +0000 Received: from localhost ([127.0.0.1]:51835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjsZ-0006ir-8P for submit@debbugs.gnu.org; Mon, 31 Aug 2020 09:29:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjsW-0006id-KK for 42192@debbugs.gnu.org; Mon, 31 Aug 2020 09:29:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56100) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjsP-0001DE-S5; Mon, 31 Aug 2020 09:29:37 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36212 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCjsO-0007Id-NI; Mon, 31 Aug 2020 09:29:37 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200704182548.25280-1-arunisaac@systemreboot.net> Date: Mon, 31 Aug 2020 15:29:34 +0200 In-Reply-To: <20200704182548.25280-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Sat, 4 Jul 2020 23:55:48 +0530") Message-ID: <87pn77c5a9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: MsrnU8wpqdrQ Hi Arun, Arun Isaac skribis: > This patchset fixes a bug in the launchpad importer, and improves it to > recognize more URLs and extensions. `guix refresh --list-updaters` report= s an > improvement in coverage from 0.1% to 0.2%. All three patches LGTM, thank you! > On a side note, all our updaters try to detect the URL format through a s= eries > of guesses. But, all our packages already encode information about how to > construct the source URL from the version. If we could somehow tap into t= hat > information, our updaters would be much simpler. Unfortunately, all the u= ri > fields of packages are strings. We would need them to be functions that t= ake > the version as an argument. This is a major conversion. Is it feasible? A= ny > better ideas? I sympathize with the idea, but I think it=E2=80=99s a bit too ambitious. = All in all, what we currently have seems like a reasonable tradeoff. Ludo=E2=80=99.