From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eAyCIV+OW18jTgAA0tVLHw (envelope-from ) for ; Fri, 11 Sep 2020 14:49:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cNDLG1+OW1+WHAAAbx9fmQ (envelope-from ) for ; Fri, 11 Sep 2020 14:49:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08E959400EF for ; Fri, 11 Sep 2020 14:49:03 +0000 (UTC) Received: from localhost ([::1]:46910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGkMI-0006Oi-0T for larch@yhetil.org; Fri, 11 Sep 2020 10:49:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGkLK-0004am-Bf for guix-patches@gnu.org; Fri, 11 Sep 2020 10:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGkLJ-0007BE-W4 for guix-patches@gnu.org; Fri, 11 Sep 2020 10:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGkLJ-0006Uu-T4 for guix-patches@gnu.org; Fri, 11 Sep 2020 10:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43257] [PATCH] services: nfs: Require file-systems to be mounted before starting NFS shepherd service. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Sep 2020 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 43257@debbugs.gnu.org Received: via spool by 43257-submit@debbugs.gnu.org id=B43257.159983566124780 (code B ref 43257); Fri, 11 Sep 2020 14:48:01 +0000 Received: (at 43257) by debbugs.gnu.org; 11 Sep 2020 14:47:41 +0000 Received: from localhost ([127.0.0.1]:45093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGkKz-0006RW-2j for submit@debbugs.gnu.org; Fri, 11 Sep 2020 10:47:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGkKx-0006Np-0u for 43257@debbugs.gnu.org; Fri, 11 Sep 2020 10:47:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40324) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGkKp-00078r-IC; Fri, 11 Sep 2020 10:47:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39310 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kGkKg-00040B-0R; Fri, 11 Sep 2020 10:47:30 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200907164745.15932-1-dannym@scratchpost.org> <87imcnmk25.fsf@gnu.org> <20200909121313.321a18d5@scratchpost.org> <87wo12jcvx.fsf@gnu.org> <20200910152042.4b33a84f@scratchpost.org> <87h7s4vlse.fsf@gnu.org> <20200911102316.50a22465@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 11 Sep 2020 16:47:14 +0200 In-Reply-To: <20200911102316.50a22465@scratchpost.org> (Danny Milosavljevic's message of "Fri, 11 Sep 2020 10:23:16 +0200") Message-ID: <87pn6stlot.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: qzqB41Lb4c7H Danny Milosavljevic skribis: > Hi Ludo, > > On Fri, 11 Sep 2020 09:02:09 +0200 > Ludovic Court=C3=A8s wrote: > >> Any suggestions? :-) >>=20 >> The only think I could think of is transparently adding a dummy root >> file system for the purposes of =E2=80=98shepherd-graph=E2=80=99, but it= =E2=80=99s not >> necessarily a good idea either. > > It depends on whether we want to have developer tools--but if we do, it w= ould > be nice to be more forgiving on some errors (for example have a "develope= r" > switch that would add missing fields if they are harmless and don't change > the result. Or maybe just have a procedure available that would do that > which the dev could add a call to with "-e"). > > That said, not sure that it's a good idea. > > I'm just always logging weird things so we actually can see them. > > It's not necessarily something we can (or should) fix :-) > > However, this %nfs-os is used almost unchanged for marionette-operating-s= ystem. > > So I got this idea: > > $ ./pre-inst-env guix system shepherd-graph -e '((@ (gnu tests) marionett= e-operating-system) (@@ (gnu tests nfs) %nfs-os)))' > gnu/tests.scm:161:2: error: missing root file system > > ... doesn't work either. Well now that's weird. > > That operating-system is eventually passed to "virtual-machine". > > So that means we can't use shepherd-graph on VMs? No: that just means that =E2=80=98virtualized-operating-system=E2=80=99 add= s a root file system transparently, which is why we can afford not providing one in OSes that are only meant to be used through =E2=80=98guix system vm=E2=80= =99. But =E2=80=98shepherd-graph=E2=80=99 doesn=E2=80=99t know about that: it ta= kes your OS as is and show you the info. Hope that makes sense! Ludo=E2=80=99.