From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IHlNLbAZZV+IfAAA0tVLHw (envelope-from ) for ; Fri, 18 Sep 2020 20:33:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qOFCKbAZZV9HDAAA1q6Kng (envelope-from ) for ; Fri, 18 Sep 2020 20:33:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D6AF94060B for ; Fri, 18 Sep 2020 20:33:52 +0000 (UTC) Received: from localhost ([::1]:35136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJN4p-00031z-9A for larch@yhetil.org; Fri, 18 Sep 2020 16:33:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJN34-0001uD-KV for guix-patches@gnu.org; Fri, 18 Sep 2020 16:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJN34-0004IH-A0 for guix-patches@gnu.org; Fri, 18 Sep 2020 16:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJN34-00067j-7g for guix-patches@gnu.org; Fri, 18 Sep 2020 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43494] [PATCH 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Sep 2020 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 43494@debbugs.gnu.org Received: via spool by 43494-submit@debbugs.gnu.org id=B43494.160046108323491 (code B ref 43494); Fri, 18 Sep 2020 20:32:02 +0000 Received: (at 43494) by debbugs.gnu.org; 18 Sep 2020 20:31:23 +0000 Received: from localhost ([127.0.0.1]:44551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJN2R-00066p-6w for submit@debbugs.gnu.org; Fri, 18 Sep 2020 16:31:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJN2P-00066d-V2 for 43494@debbugs.gnu.org; Fri, 18 Sep 2020 16:31:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56643) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJN2K-0004Eb-Kq; Fri, 18 Sep 2020 16:31:16 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45406 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJN2J-0002vg-Sz; Fri, 18 Sep 2020 16:31:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200918184042.22660-1-mail@cbaines.net> <20200918184042.22660-4-mail@cbaines.net> Date: Fri, 18 Sep 2020 22:31:14 +0200 In-Reply-To: <20200918184042.22660-4-mail@cbaines.net> (Christopher Baines's message of "Fri, 18 Sep 2020 19:40:42 +0100") Message-ID: <87pn6iu8rx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: c1g/5CMKkd3m Christopher Baines skribis: > * gnu/services/guix.scm (): > New record type. > (guix-build-coordinator-queue-builds-configuration, > guix-build-coordinator-queue-builds-configuration?, > guix-build-coordinator-queue-builds-configuration-package, > guix-build-coordinator-queue-builds-configuration-user, > guix-build-coordinator-queue-builds-coordinator, > guix-build-coordinator-queue-builds-configuration-systems, > guix-build-coordinator-queue-builds-configuration-system-and-targets, > guix-build-coordinator-queue-builds-configuration-guix-data-service, > guix-build-coordinator-queue-builds-configuration-processed-commits-file, > guix-build-coordinator-queue-builds-shepherd-services, > guix-build-coordinator-queue-builds-activation, > guix-build-coordinator-queue-builds-account): New procedures. > (guix-build-coordinator-queue-builds-service-type): New variable. [...] > +@defvar {Scheme Variable} guix-build-coordinator-queue-builds-service-ty= pe > +Service type for the > +guix-build-coordinator-queue-builds-from-guix-data-service script. Its Oh! :-) =E2=80=98guix-build-queue=E2=80=99 maybe? Because after all, it can queue = builds coming from anywhere, not just from the Data Service, right? It=E2=80=99d be nice to add a sentence or two explaining how the =E2=80=9Cq= ueue=E2=80=9D fits in the big picture (I=E2=80=99m not quite sure :-)). > +@item @code{systems-and-targets} (default: @code{#f}) > +An association list of system and target pairs for which to fetch > +derivations to build. Cross-compilation target triplets are a notion that=E2=80=99s not available= at the derivation level; it only exists for packages. Are we mixing things here? > +@item @code{guix-data-service} (default: @code{"https://data.guix.gnu.or= g"}) > +The Guix Data Service instance from which to query to find out about > +derivations to build. Ah so the queue pulls from the Data Service. Got it! > +@item @code{processed-commits-file} (default: @code{"/var/lib/guix-build= -coordinator-queue-builds/processed-commits"}) > +A file to record which commits have been processed, to avoid needlessly > +processing them again if the service is restarted. Maybe in /var/cache by default, no? > + (processed-commits-file > + guix-build-coordinator-queue-builds-configuration-processed-commits-f= ile > + (default "/var/lib/guix-build-coordinator-queue-builds/processed-comm= its"))) Maybe =E2=80=9Cstate-file=E2=80=9D? In addition to saving space :-), it=E2= =80=99d leave room for additional bits of state. That=E2=80=99s all, thank you! Ludo=E2=80=99.