From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YBSaDwzNeF/XIAAA0tVLHw (envelope-from ) for ; Sat, 03 Oct 2020 19:12:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0P56CwzNeF+qSQAA1q6Kng (envelope-from ) for ; Sat, 03 Oct 2020 19:12:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C84F9402A5 for ; Sat, 3 Oct 2020 19:12:11 +0000 (UTC) Received: from localhost ([::1]:54694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOmx0-0006fR-2V for larch@yhetil.org; Sat, 03 Oct 2020 15:12:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOmws-0006fH-5y for guix-patches@gnu.org; Sat, 03 Oct 2020 15:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOmwr-0004Zr-QM for guix-patches@gnu.org; Sat, 03 Oct 2020 15:12:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOmwr-0002JY-J3 for guix-patches@gnu.org; Sat, 03 Oct 2020 15:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Oct 2020 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 43769@debbugs.gnu.org Received: via spool by 43769-submit@debbugs.gnu.org id=B43769.16017522928856 (code B ref 43769); Sat, 03 Oct 2020 19:12:01 +0000 Received: (at 43769) by debbugs.gnu.org; 3 Oct 2020 19:11:32 +0000 Received: from localhost ([127.0.0.1]:44504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOmwN-0002Im-Q4 for submit@debbugs.gnu.org; Sat, 03 Oct 2020 15:11:31 -0400 Received: from tobias.gr ([80.241.217.52]:50846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOmwK-0002Ic-EO for 43769@debbugs.gnu.org; Sat, 03 Oct 2020 15:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=u9dKLeZqVoqgUv3WjV/bmwy0w/WPq/nCOerAp2PBRHc=; h=date:in-reply-to: references:subject:cc:to:from; b=Lff0PrCGReubnK48w0xy81lgYS3B5JYYyoVZz vdyC1XynZjylTYGkPddGL4g3K1yTrXuhbmqbQecxjRlMKnnSso6Gqr4FJtp3DZQUl/4Nrl f7mNyoi03XeGCNc923dUXEBvgdx4NRKCI0FxWkMcaieeC0H9iZGa/B3WuuBNLbEIq1ReWw YdgXUaXyofWOB4bC7gSIwuI6VSo9zVfFoLdniVQG0r0TtGafNQl9nZYMq4Uj5vWMO7DQdx 4MKO7u2AYBTS5mBG8UpVcoMW3tlShkpTsuIgSNnumu/kXACDGKmGBPQjeY5ZjRaywwFFGo DjS1iEHsOTilneFU8hONV79JA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id f58ed69e (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Sat, 3 Oct 2020 19:11:34 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: <20201002173537.12045-1-zimon.toutoune@gmail.com> <20201003184447.9542-1-zimon.toutoune@gmail.com> In-reply-to: <20201003184447.9542-1-zimon.toutoune@gmail.com> Date: Sat, 03 Oct 2020 21:11:26 +0200 Message-ID: <87pn5z9lb5.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tobias.gr header.s=2018 header.b=Lff0PrCG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: mZYYmovIOgiV --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Zimoun, Thanks! Shell code always looks ugly to me, so LGTM if it works=20 :-) Nitpick: s/create/install/ zimoun =E5=86=99=E9=81=93=EF=BC=9A > + [Nn]*) _msg "${INF}Skipped shell completion=20 > installation" > + break;; > + *) _msg "Please answer yes or no."; Why bother the user with this? We don't ask before installing=20 /etc/profile.d/guix.sh, or enabling the daemon, and we shouldn't=20 offer similar meaningless choices just for the sake of it. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3jM3g0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15aAUBAJihwdBr5VVPWFmaEHVIhpiIDTJFqfTIePWXxlbw bvadAQDqTJZza69KvA+FCJ3YdvlDLmdem2YBS/Y4e8V8PSRvAw== =pdM5 -----END PGP SIGNATURE----- --=-=-=--