From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 43769@debbugs.gnu.org
Subject: [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions.
Date: Sat, 03 Oct 2020 21:11:26 +0200 [thread overview]
Message-ID: <87pn5z9lb5.fsf@nckx> (raw)
In-Reply-To: <20201003184447.9542-1-zimon.toutoune@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Zimoun,
Thanks! Shell code always looks ugly to me, so LGTM if it works
:-)
Nitpick: s/create/install/
zimoun 写道：
> + [Nn]*) _msg "${INF}Skipped shell completion
> installation"
> + break;;
> + *) _msg "Please answer yes or no.";
Why bother the user with this? We don't ask before installing
/etc/profile.d/guix.sh, or enabling the daemon, and we shouldn't
offer similar meaningless choices just for the sake of it.
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2020-10-03 19:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 17:35 [bug#43769] [PATCH 0/2] guix-install.sh: Minor first user-experience tweaks zimoun
2020-10-02 17:40 ` [bug#43769] [PATCH 1/2] guix-install.sh: Add symbolic links for supported shell completions zimoun
2020-10-02 17:42 ` [bug#43769] [PATCH 2/2] guix-install.sh: Check the daemon 'nscd' and suggest it zimoun
2020-10-03 18:44 ` [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions zimoun
2020-10-03 18:44 ` [bug#43769] [PATCH v2 2/2] guix-install.sh: Check the service 'nscd' and suggest it zimoun
2020-10-03 19:14 ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-05 8:08 ` Ludovic Courtès
2020-10-05 9:19 ` zimoun
2020-10-05 12:28 ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-13 16:45 ` zimoun
2020-10-03 19:11 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-10-05 8:09 ` [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions Ludovic Courtès
2020-10-05 9:23 ` zimoun
2020-10-05 12:02 ` Ludovic Courtès
2020-10-13 17:12 ` [bug#43769] [PATCH v3 2/2] guix-install.sh: Check the service 'nscd' and suggest it zimoun
2020-10-13 17:12 ` [bug#43769] [PATCH v3 1/2] guix-install.sh: Add symbolic links for supported shell completions zimoun
2020-10-16 9:39 ` bug#43769: [PATCH v3 2/2] guix-install.sh: Check the service 'nscd' and suggest it Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn5z9lb5.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=43769@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).