From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gO8IGd7ael9aMQAA0tVLHw (envelope-from ) for ; Mon, 05 Oct 2020 08:35:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kOarFN7ael/xJQAAbx9fmQ (envelope-from ) for ; Mon, 05 Oct 2020 08:35:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE29894051F for ; Mon, 5 Oct 2020 08:35:41 +0000 (UTC) Received: from localhost ([::1]:55316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPLy7-0004Dz-Bk for larch@yhetil.org; Mon, 05 Oct 2020 04:35:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPLwY-0002Q1-Ue for guix-patches@gnu.org; Mon, 05 Oct 2020 04:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPLwY-0000DJ-Hy for guix-patches@gnu.org; Mon, 05 Oct 2020 04:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPLwY-0000h6-Fd for guix-patches@gnu.org; Mon, 05 Oct 2020 04:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43771] [PATCH 3/5] Remove the postgresql-service procedure Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Oct 2020 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43771 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 43771@debbugs.gnu.org Received: via spool by 43771-submit@debbugs.gnu.org id=B43771.16018868372655 (code B ref 43771); Mon, 05 Oct 2020 08:34:02 +0000 Received: (at 43771) by debbugs.gnu.org; 5 Oct 2020 08:33:57 +0000 Received: from localhost ([127.0.0.1]:47850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLwT-0000gk-0o for submit@debbugs.gnu.org; Mon, 05 Oct 2020 04:33:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLwR-0000gX-9F for 43771@debbugs.gnu.org; Mon, 05 Oct 2020 04:33:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54779) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPLwL-0000Cg-Lu; Mon, 05 Oct 2020 04:33:49 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=34198 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPLwL-00047z-2F; Mon, 05 Oct 2020 04:33:49 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201002184059.29033-1-mail@cbaines.net> <20201002184059.29033-3-mail@cbaines.net> Date: Mon, 05 Oct 2020 10:33:47 +0200 In-Reply-To: <20201002184059.29033-3-mail@cbaines.net> (Christopher Baines's message of "Fri, 2 Oct 2020 19:40:57 +0100") Message-ID: <87pn5x3wd0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: sghR/U5WWgTN Hi, Christopher Baines skribis: > It's unnecessary, using the service type directly is a better approach. W= hile > this is unfortunately a breaking change, I'm also looking at making break= ing > changes to the service type configuration, so I don't think this can be > avoided. [...] > -(define* (postgresql-service #:key (postgresql postgresql) > - (port 5432) > - (locale "en_US.utf8") Here I=E2=80=99d suggest to keep it as =E2=80=98define-deprecated=E2=80=99,= like we did for other such procedures. Otherwise LGTM. Thanks, Ludo=E2=80=99.