From: Kei Kebreau <kkebreau@posteo.net>
To: Michael Rohleder <mike@rohleder.de>
Cc: 44681@debbugs.gnu.org
Subject: [bug#44681] [PATCH] gnu: gnubg: Prevent building with avx instructions.
Date: Tue, 17 Nov 2020 21:27:09 -0500 [thread overview]
Message-ID: <87pn4bv1qa.fsf@posteo.net> (raw)
In-Reply-To: <20201116121737.22825-1-mike@rohleder.de> (Michael Rohleder's message of "Mon, 16 Nov 2020 13:17:37 +0100")
[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]
Hi Michael!
Michael Rohleder <mike@rohleder.de> writes:
> * gnu/packages/games.scm (gnubg): Prevent building with avx instructions.
> [arguments]: Add configure-flags for Intel systems.
I'd modify the commit message to be a bit shorter, like so:
gnu: gnubg: Prevent building with AVX instructions.
* gnu/packages/games.scm (gnubg)[arguments]: Add configure-flags for Intel
systems to build without AVX instructions.
> ---
> gnu/packages/games.scm | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 97b0cb976d..12cc64fefa 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1605,7 +1605,14 @@ such as chess or stockfish.")
> (native-inputs `(("python-2" ,python-2)
> ("pkg-config" ,pkg-config)))
> (arguments
> - `(#:phases
> + `(#:configure-flags
> + ;; SSE instructions are available on Intel systems only.
> + (list ,@(if (any (cute string-prefix? <> (or (%current-target-system)
> + (%current-system)))
> + '("x86_64" "i686"))
> + '("--enable-simd=sse2") ; prevent avx instructions
> + '()))
> + #:phases
> (modify-phases %standard-phases
> (add-after 'install 'install-desktop-file
> (lambda* (#:key outputs #:allow-other-keys)
Otherwise, the patch looks and works fine. I didn't even know that GNU
Backgammon didn't work on my machine until I tested this patch!
Please let me know whether you're okay with the commit message
modification, and I'll push this for you.
Thanks,
Kei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-11-18 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 12:17 [bug#44681] [PATCH] gnu: gnubg: Prevent building with avx instructions Michael Rohleder
2020-11-18 2:27 ` Kei Kebreau [this message]
2020-11-18 6:53 ` Michael Rohleder
2020-11-18 14:05 ` bug#44681: " Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn4bv1qa.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=44681@debbugs.gnu.org \
--cc=mike@rohleder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).