From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IJqSEhknuF+8dgAA0tVLHw (envelope-from ) for ; Fri, 20 Nov 2020 20:29:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YJrjDRknuF+xfgAAbx9fmQ (envelope-from ) for ; Fri, 20 Nov 2020 20:29:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3CFF7940105 for ; Fri, 20 Nov 2020 20:29:12 +0000 (UTC) Received: from localhost ([::1]:55662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgD1p-0004Rj-UX for larch@yhetil.org; Fri, 20 Nov 2020 15:29:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgD1i-0004RV-Hq for guix-patches@gnu.org; Fri, 20 Nov 2020 15:29:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:32829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgD1i-0005yU-A1 for guix-patches@gnu.org; Fri, 20 Nov 2020 15:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgD1i-0005bQ-5o for guix-patches@gnu.org; Fri, 20 Nov 2020 15:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#39071] [PATCH] Add ghc-clay Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Nov 2020 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39071 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Guillaume Salvan Cc: 39071@debbugs.gnu.org Received: via spool by 39071-submit@debbugs.gnu.org id=B39071.160590409421477 (code B ref 39071); Fri, 20 Nov 2020 20:29:02 +0000 Received: (at 39071) by debbugs.gnu.org; 20 Nov 2020 20:28:14 +0000 Received: from localhost ([127.0.0.1]:44374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgD0v-0005aL-NP for submit@debbugs.gnu.org; Fri, 20 Nov 2020 15:28:13 -0500 Received: from mira.cbaines.net ([212.71.252.8]:37792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgD0u-0005aE-Q7 for 39071@debbugs.gnu.org; Fri, 20 Nov 2020 15:28:13 -0500 Received: from localhost (188.30.135.14.threembb.co.uk [188.30.135.14]) by mira.cbaines.net (Postfix) with ESMTPSA id CD5D027BBF5; Fri, 20 Nov 2020 20:28:11 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 93e14a0c; Fri, 20 Nov 2020 20:28:09 +0000 (UTC) References: <0Aa4s7vRDfoPVcvl3y8kcbTAk0hCT_PsUoVeTa4d1Y2sKW8kViVWdwmBR-6EY-3VtDvH5K6ry-CQh-BGWuycchPAZKTE6CEyZDyUBNZpfrE=@protonmail.ch> <87wo73vtxf.fsf@devup.no> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87wo73vtxf.fsf@devup.no> Date: Fri, 20 Nov 2020 20:28:09 +0000 Message-ID: <87pn47kc2u.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: iL1haADP2CEc --=-=-= Content-Type: text/plain Marius Bakke writes: > Hello Guillaume, > > Sorry for the slooow review. > > Could you expand on the comment about why tests are disabled? Is it > because of missing inputs, or network access, or something else? > > Please also add a copyright line for yourself at the top of the file. > > Can you send an updated patch? Next review will be faster, promise! It's been a few months, is this patch still relevant? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+4JtlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe30A//VAc3wS9asvCEkVA1m8fegHSds95AXkhP VIh02+K5AxzT5Nzpg6HxpQIrzGM6DyxE+vQuXgaAtlypvcXlv2jKTr1YGh14+1yn C1IUQxZtevbZyMReTfBuuMlDnrQnKQjXIRQpTnW2dLP9zFNxEeXD3chwVFyiRDUc Kkw7Bltmnn3KMQtG6AUlPd/snIoD2HRtc7f0i/7s92MN9My+wIt0pfXJ+XupER69 e7Xdu+Raf49gBK1VAVkS39iNBS4z5VlyOguB3OXwZbEFqQIWW61qOwrezay3Lj2X L024AmjbEv1v9TsgtmREn+wocNJ1L6siiNkGYphqaH7c8Cq7uF51umhcc3g1yMsW ILLPIaDVJ7QzecleNPstKBRLKhCVXKLnC/EBZ1iBsDsj6d/AYIVyoWWmeFt4JB+E tAJKOooq/bCIElOczrsj8v/Fs9lCBgJjFjU/jxyQEjdeG/tR4qdxcThxoTwW0eVM gvwCYPEWyle9wn/5VnDGV239yfoF9cguH/dnAOGdRh+dcCAtLYfyQQOm2K029rxi Fiy6aPvgG9DWAGEkEznPNZX1BF3+dv2YGwnfy92UkpXkHbFsuBDYpzhXlwbMgUUX 2eSVsxCWIJ06ZRw2CNh0nVOxFt39n13Cl8Exxkbq68t5OIVbNPiOQ8CgWSVdzSy0 kJLONpQKSn8= =y4gn -----END PGP SIGNATURE----- --=-=-=--