unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Guillaume Salvan <salvang@protonmail.ch>
Cc: 39071@debbugs.gnu.org
Subject: [bug#39071] [PATCH] Add ghc-clay
Date: Fri, 20 Nov 2020 20:28:09 +0000	[thread overview]
Message-ID: <87pn47kc2u.fsf@cbaines.net> (raw)
In-Reply-To: <87wo73vtxf.fsf@devup.no>

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]


Marius Bakke <mbakke@fastmail.com> writes:

> Hello Guillaume,
>
> Sorry for the slooow review.
>
> Could you expand on the comment about why tests are disabled?  Is it
> because of missing inputs, or network access, or something else?
>
> Please also add a copyright line for yourself at the top of the file.
>
> Can you send an updated patch?  Next review will be faster, promise!

It's been a few months, is this patch still relevant?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2020-11-20 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 13:35 [bug#39071] [PATCH] Add ghc-clay Guillaume Salvan via Guix-patches via
2020-03-29 19:32 ` Marius Bakke
2020-11-20 20:28   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn47kc2u.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=39071@debbugs.gnu.org \
    --cc=salvang@protonmail.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).