From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sE/lEANO+F/NBAAA0tVLHw (envelope-from ) for ; Fri, 08 Jan 2021 12:20:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mFdFDANO+F+DIQAAB5/wlQ (envelope-from ) for ; Fri, 08 Jan 2021 12:20:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EAFA99402A0 for ; Fri, 8 Jan 2021 12:20:18 +0000 (UTC) Received: from localhost ([::1]:51842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxqkb-0005WP-Ux for larch@yhetil.org; Fri, 08 Jan 2021 07:20:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxqkN-0005Sb-9Y for guix-patches@gnu.org; Fri, 08 Jan 2021 07:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxqkN-00083e-1N for guix-patches@gnu.org; Fri, 08 Jan 2021 07:20:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxqkM-0003Qm-TS for guix-patches@gnu.org; Fri, 08 Jan 2021 07:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Jan 2021 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel X-Debbugs-Original-Cc: 45712@debbugs.gnu.org, Lars-Dominik Braun , guix-patches@gnu.org Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.161010838813117 (code B ref 45712); Fri, 08 Jan 2021 12:20:02 +0000 Received: (at 45712) by debbugs.gnu.org; 8 Jan 2021 12:19:48 +0000 Received: from localhost ([127.0.0.1]:49424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxqk7-0003PV-N5 for submit@debbugs.gnu.org; Fri, 08 Jan 2021 07:19:48 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxqk3-0003P6-QR for 45712@debbugs.gnu.org; Fri, 08 Jan 2021 07:19:44 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1610108375; cv=none; d=zohomail.com; s=zohoarc; b=jBg3+3KY8cepeoPqrEhYJ8vVUpIcXzqRHHyON9X0Fyn+JZVmfcC9MIHGR7r5tQVuo760cqaQVZudzyKV8awo/2343N6llBZsHSoAD5TAw4N6KSXBiW5riAcLLn7j9xEIJ1N7LHPSlaieAfxuv9iGyqaQ38jKLBCzcNSQBqxmzPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610108375; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Ui+TDBecRez5brm99SE8d6VjUMFxhzptcgNKu3ggGAU=; b=kuiCKHkWgEsDChcChawp4H4gVWna7trzRIQ0cVMc0280f6aPqOkmWWwpSfiVvomOdhqzdnD62sMpq+FCF+eLokdMTa7vDGvWFgvCEFLgUoEMZ34tfn1G1dJt0p5jMLaluG5DYDst+NRAkvyCsnNz36ORNftM4M3NQ9Uj7cMnxwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1610108375; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Ui+TDBecRez5brm99SE8d6VjUMFxhzptcgNKu3ggGAU=; b=SQksJra8CGabtFwWnVJmVyFJh1qs/AgJT3rioyE0Yco9AYpFEB+0GozhkBqHnYO1 mA/JcJZhwfvs5bz98BJnEpObJ4SS6K1eCa8fkoORug9RVfBk6sHuub0S4T84elow7yE HrxN1eCUA6tr4Fp0czR1ZJvEYgw/TFJ8n/95xyD0= Received: from localhost (p54ad4ca5.dip0.t-ipconnect.de [84.173.76.165]) by mx.zohomail.com with SMTPS id 1610108373138529.1636585524626; Fri, 8 Jan 2021 04:19:33 -0800 (PST) References: <87mtxj1wym.fsf@lenashee.goebel-consult.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus In-reply-to: <87mtxj1wym.fsf@lenashee.goebel-consult.de> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Fri, 08 Jan 2021 13:19:29 +0100 Message-ID: <87pn2ffwoe.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=elephly.net header.s=zoho header.b=SQksJra8; arc=reject (signature check failed: fail, {[1] = sig:zohomail.com:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EAFA99402A0 X-Spam-Score: 0.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: BS/CpXyJoifJ Hartmut Goebel writes: > Hi Lars, > > thanks for the patch set. Please please find some comments. (I did not > check all changes to the packages, assuming you did it right :-) > > >> +(define validate-script >> + "from __future__ import print_function # Python 2 support. > > Please but this int a new line - makeing it easier to copy & paste. > (Leading emptry lines doe nor effect "from __future__ import"). You can also escape the line break: --8<---------------cut here---------------start------------->8--- (define validate-script "\ from __future__ import print_function # Python 2 support. =E2=80=A6") --8<---------------cut here---------------end--------------->8--- --=20 Ricardo