From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2Sy/Bh5U3GDsagAAgWs5BA (envelope-from ) for ; Wed, 30 Jun 2021 13:23:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kKPAAR5U3GC+cwAAbx9fmQ (envelope-from ) for ; Wed, 30 Jun 2021 11:23:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7774617A81 for ; Wed, 30 Jun 2021 13:23:09 +0200 (CEST) Received: from localhost ([::1]:46278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyYJA-0007wI-9O for larch@yhetil.org; Wed, 30 Jun 2021 07:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyYJ4-0007w5-0v for guix-patches@gnu.org; Wed, 30 Jun 2021 07:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyYJ3-0008M8-Py for guix-patches@gnu.org; Wed, 30 Jun 2021 07:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyYJ3-0002Wf-Mk for guix-patches@gnu.org; Wed, 30 Jun 2021 07:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49284] [PATCH] gnu: Add fheroes2 Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Jun 2021 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49284 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler , 49284@debbugs.gnu.org Received: via spool by 49284-submit@debbugs.gnu.org id=B49284.16250521679685 (code B ref 49284); Wed, 30 Jun 2021 11:23:01 +0000 Received: (at 49284) by debbugs.gnu.org; 30 Jun 2021 11:22:47 +0000 Received: from localhost ([127.0.0.1]:56566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyYIp-0002W8-1c for submit@debbugs.gnu.org; Wed, 30 Jun 2021 07:22:47 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:40502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyYIm-0002Vv-8X for 49284@debbugs.gnu.org; Wed, 30 Jun 2021 07:22:45 -0400 Received: by mail-lf1-f46.google.com with SMTP id q18so4419942lfc.7 for <49284@debbugs.gnu.org>; Wed, 30 Jun 2021 04:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=WaQgycx75BGHIuZzT/UTzvmPwsYNpU29BGDTO/4OaQg=; b=PC/9Eh4TleQkooBBiWM+OV7Tzi6ZCNeX1dz3mc/H5OTbU1MAjH+bYCGiUT56TNF9zm JfIvf+u2bRFMD9fw/QhxyMjg0XFPTF3QYDYpUdZL7n+qw+RYcJm9MBmh78YWfH5PWVrc bBEzdRjKQFt6SvqLxwCgChpuRx6fIjQCyOuL5aoztqnSCZ6DdcWwRkNqSzJgmzHHvcJv MNRyS4frvhb9knYAE45QFx2ZeP5pdOo7FGFJS8igHE081ZZR1j69fTnEZlnu8HybrDCT gJNvKgX9XXlk5tr/nVltdFWjB/DJjwOjl/H7IUsUWv9/iqX5m0Mwwv2LxKspBlhXBgne TimA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=WaQgycx75BGHIuZzT/UTzvmPwsYNpU29BGDTO/4OaQg=; b=Lrvg6oAtKXVNie8XHoqKrFJsXAOLC2j0CmJbDfuXsV2/ctgTgtDKeEvRGaNPwEC7nZ cLx/jmeHBM/kWUrSF5YPCDGP6TaHiZc+hoecrBuNXmqcCKO+MGa6Uub8KLSz4FD4PDeu JnhHnKUjvBvKxL/3DcCm1BKuf6JK6Du6hPBa73vrQQfVf3xYRSgoX+kT9cDnTEEljQSE FykIR7l+073qMBRnNr6xJIzhhMHVvkgl6aVhB1F7qU3C51Jop1u5jqnzNFfri0nfbIcW r1hegXYCWICw5wGCgJClGv68rhMzncZm5FZURrP70Zce8olrI9EC6/Jv/wzpXDpIbBxu coGA== X-Gm-Message-State: AOAM5332f8w3wGROaQWlwtybP6y6fBfsy3LAPqGX0qgqPxw2kDdndH2o 1dWe6Q0+EYzQpxiZcAxueACcd5/z8qOudQ== X-Google-Smtp-Source: ABdhPJzD4iEp5hyIxlq8IxWHclaYsVeB1/cBO7DEZwyh6z4Ubk0clKYgfg1Fnz8tdGBDaNAZfiB+8A== X-Received: by 2002:ac2:4208:: with SMTP id y8mr24172087lfh.27.1625052157784; Wed, 30 Jun 2021 04:22:37 -0700 (PDT) Received: from ixy (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id u19sm1415561ljg.29.2021.06.30.04.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 04:22:37 -0700 (PDT) From: Andrew Tropin In-Reply-To: References: <871r8jvekq.fsf@trop.in> Date: Wed, 30 Jun 2021 14:22:33 +0300 Message-ID: <87pmw31ts6.fsf@trop.in> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625052189; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WaQgycx75BGHIuZzT/UTzvmPwsYNpU29BGDTO/4OaQg=; b=ducT4ngF94gcWbpi8MQXEdw1kc1aL5tijuPJdcH7ghb8IXQPFRKZvW/l8FU8adprvNjlRY v1sTOVUsUz/68NRbII+U8INy7BcyFfxQXTYzDmtHvY8EVWu6fIwr8IslUVZj7XbsgmnPp8 +0BEElPxalKnvx/uEd7OI2eU9de7556XUbkJvXWnaDP6GP2ymMZWj0m6YBTTggieESZXf/ vMipfSOGuehw5Kv2Su+PEEVrCqXsLDlPwVQm7DZxEXtlGiYA1oMw9GhH2YjIEyBiroGHEf LkzQzFq8knfhWyEbbfWAOGvmqvgc/EXmCrcyeEsqhkbeG+l3HBmK53JYhb/s6g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625052189; a=rsa-sha256; cv=none; b=YoEGtEP0s5ysEE7+ZImDJJ8zp481i6Gw+Z5RO8tLfQnkEJxDibAnOHbWpNPZC9d+k0c9g9 xunv4Rs3a+d4vzEnpky+d0hNikorYkfCZV+dQhIyZEEeSJ7K5Z+ZR/+Gu8SS2flYZHmQPP SHO0RWPdFeoUN/jjpmqek2793jTlobzjl14nUJSs4k9/5trEt7C+pdZyHC5Xy7ITTrs0J5 ADAaFbxr6W0hmDJK4YfZrCbIkHqbsqZTHBBQmNNVvetLChBLG6CjsFX4HcUUIn6dbiJWeE qJx7tl7KHCEwW6cLPgLDV3dQDtC4YS9DRxiCyqWQwHAevUKiuCb1j1OxBTe76w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b="PC/9Eh4T"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b="PC/9Eh4T"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7774617A81 X-Spam-Score: 0.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: 00nqxQF/EV1I Leo Prikler writes: > Am Mittwoch, den 30.06.2021, 13:20 +0300 schrieb Andrew Tropin: >> Leo Prikler writes: >> >> > Am Mittwoch, den 30.06.2021, 08:49 +0300 schrieb Andrew Tropin: >> > > * gnu/packages/games.scm (fheroes2): New variable. >> > > --- >> > > There are no tests in the project, so they are disabled. >> > #:tests? #f should always be documented inside the code >> > > gnu/packages/games.scm | 30 ++++++++++++++++++++++++++++++ >> > > 1 file changed, 30 insertions(+) >> > > >> > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm >> > > index 83cb738b9c..7a87123df3 100644 >> > > --- a/gnu/packages/games.scm >> > > +++ b/gnu/packages/games.scm >> > > @@ -12511,3 +12511,33 @@ wreckage. You're stranded on a desert >> > > island and have to survive. In order to >> > > do so you need to explore the island, find food, build a shelter >> > > and >> > > try to >> > > get attention, so you get found.") >> > > (license license:cc-by4.0)))) >> > > + >> > > +(define-public fheroes2 >> > > + (package >> > > + (name "fheroes2") >> > > + (version "0.9.4") >> > > + (build-system cmake-build-system) >> > > + (arguments >> > > + `(#:tests? #f >> > Add a comment here along the lines of "no tests" or "no check >> > target". >> > > + #:make-flags '("FHEROES2_STRICT_COMPILATION=1" >> > > + "RELEASE=1"))) >> > > + (native-inputs >> > > + `(("gettext" ,gettext-minimal))) >> > > + (inputs >> > > + `(("zlib" ,zlib) >> > > + ("libpng" ,libpng) >> > > + ("sdl" ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2- >> > > ttf))))) >> > > + (source (origin >> > > + (method git-fetch) >> > > + (uri (git-reference >> > > + (url "https://github.com/ihhub/fheroes2") >> > > + (commit version))) >> > > + (file-name (git-file-name name version)) >> > > + (sha256 >> > > + (base32 >> > > + "0a3xi3k7ngp0byhmg7wq22l1hix3jwr68prk2y6frqhzbfs >> > > krvy >> > > g")))) >> > > + (home-page "https://ihhub.github.io/fheroes2/") >> > > + (synopsis "Turn-based strategy game engine") >> > > + (description "Free implementation of Heroes of Might and >> > > Magic >> > > II (aka >> > > +HOMM2) game engine.") >> > > + (license license:gpl2))) >> > The description is a bit lacking in information. Is this engine >> > usable? If so, how? We ought not to steer users towards non-free >> > software. >> >> Yep, it's usable. It requires game resources (assets like music, >> maps, >> sprites), the assets from original game is not distributed with it >> because of legal reasons I suppose, but AFAIK nothing stops people >> from >> creating their own set of assets to use with this game engine. Also, >> taking only assets from original game and using them with this engine >> will help people not to use unfree software. >> >> Added comment, updated description. > Without a package providing those assets, this is still pretty much > "here, go seek out this nonfree software thingy for assets". This is > not to say, that we can never ever ship fheroes2, but I'd personally > hold back on it until we can package some fheroes2-data to make it > useful without requiring people seek out these assets. > > This is just my own opinion however, and it's certainly not reflected > all over guix source. For instance, both oshu and stepmania require > beatmaps and stepfiles respectively to be useful and ship without them > while most of what you'll find online will be somewhat dubious in terms > of copyright. However, both also offer the tools to create those using > your own (hopefully GPL-compatible) album collection, so it's not a big > problem. I don't think fheroes2 has that low of an entry barrier to > full playability, does it? Y, probably it's not easy to find free assets. Still can be useful for people, who already have a CD with the original game, but do not want to use unfree software or even for people, who would buy it to get resource from it. Feels kinda on the edge: On the one hand it can nudge someone to buy or obtain a bundle with unfree software inside to extract resources from it. On the other hand it helps not to use unfree software. I think it's more towards steering people from unfree to free software, but I can be wrong. Anyway, I trust your expertise on this topic and will accept your descision to hold it back if you think it's necessary to have fheroes2-data created/packaged first.