* [bug#49342] [PATCH 0/1] Fix libykpers reference in python-yubikey-manager
@ 2021-07-02 21:18 Dhruvin Gandhi via Guix-patches via
2021-07-02 21:21 ` [bug#49342] [PATCH 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
0 siblings, 1 reply; 6+ messages in thread
From: Dhruvin Gandhi via Guix-patches via @ 2021-07-02 21:18 UTC (permalink / raw)
To: 49342; +Cc: Dhruvin Gandhi
libykpers from yubikey-personalization package is required by
python-yubikey-manager to perform otp operations.
This patch fixes it. ($ ykman -v)
PS: The yubikey packages in the repo are quite old now and there are major
version changes upstream. I'll soon submit patches, fixing some of them.
Dhruvin Gandhi (1):
gnu: python-yubikey-manager: Fix libykpers reference.
gnu/packages/security-token.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
--
2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#49342] [PATCH 1/1] gnu: python-yubikey-manager: Fix libykpers reference.
2021-07-02 21:18 [bug#49342] [PATCH 0/1] Fix libykpers reference in python-yubikey-manager Dhruvin Gandhi via Guix-patches via
@ 2021-07-02 21:21 ` Dhruvin Gandhi via Guix-patches via
2021-07-03 4:32 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
0 siblings, 1 reply; 6+ messages in thread
From: Dhruvin Gandhi via Guix-patches via @ 2021-07-02 21:21 UTC (permalink / raw)
To: 49342; +Cc: Dhruvin Gandhi
* gnu/packages/security-token.scm (python-yubikey-manager): Fix libykpers reference.
---
gnu/packages/security-token.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 49ca1dc01e..3c2f336497 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -657,6 +657,23 @@ implementing a Relying Party.")
(base32
"11rsmcaj60k3y5m5gdhr2nbbz0w5dm3m04klyxz0fh5hnpcmr7fm"))))
(build-system python-build-system)
+ (arguments
+ '(#:modules ((srfi srfi-1)
+ (guix build utils)
+ (guix build python-build-system))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'fix-libykpers-reference
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "ykman/driver_otp.py"
+ (("Ykpers\\('ykpers-1', '1'\\)")
+ (string-append
+ "Ykpers('"
+ (find (negate symbolic-link?)
+ (find-files (assoc-ref inputs "yubikey-personalization")
+ "^libykpers-.*\\.so\\..*"))
+ "')")))
+ #t)))))
(propagated-inputs
`(("python-six" ,python-six)
("python-pyscard" ,python-pyscard)
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#49342] [PATCH v2 0/1] Update Copyright
2021-07-02 21:21 ` [bug#49342] [PATCH 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
@ 2021-07-03 4:32 ` Dhruvin Gandhi via Guix-patches via
2021-07-03 4:32 ` [bug#49342] [PATCH v2 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
2021-07-08 6:12 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
0 siblings, 2 replies; 6+ messages in thread
From: Dhruvin Gandhi via Guix-patches via @ 2021-07-03 4:32 UTC (permalink / raw)
To: 49342; +Cc: Dhruvin Gandhi
I missed updating the copyright in last patch. Here's v2.
Dhruvin Gandhi (1):
gnu: python-yubikey-manager: Fix libykpers reference.
gnu/packages/security-token.scm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
base-commit: eef099a2e1648032c571567c6da29ccd86e72058
--
2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#49342] [PATCH v2 1/1] gnu: python-yubikey-manager: Fix libykpers reference.
2021-07-03 4:32 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
@ 2021-07-03 4:32 ` Dhruvin Gandhi via Guix-patches via
2021-07-30 20:50 ` bug#49342: [PATCH 0/1] Fix libykpers reference in python-yubikey-manager Ludovic Courtès
2021-07-08 6:12 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
1 sibling, 1 reply; 6+ messages in thread
From: Dhruvin Gandhi via Guix-patches via @ 2021-07-03 4:32 UTC (permalink / raw)
To: 49342; +Cc: Dhruvin Gandhi
* gnu/packages/security-token.scm (python-yubikey-manager): Fix libykpers reference.
---
gnu/packages/security-token.scm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 49ca1dc01e..8af27176cc 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -11,6 +11,7 @@
;;; Copyright © 2020 Raphaël Mélotte <raphael.melotte@mind.be>
;;; Copyright © 2021 Antero Mejr <antero@kodmin.com>
;;; Copyright © 2021 Sergey Trofimov <sarg@sarg.org.ru>
+;;; Copyright © 2021 Dhruvin Gandhi <contact@dhruvin.dev>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -657,6 +658,23 @@ implementing a Relying Party.")
(base32
"11rsmcaj60k3y5m5gdhr2nbbz0w5dm3m04klyxz0fh5hnpcmr7fm"))))
(build-system python-build-system)
+ (arguments
+ '(#:modules ((srfi srfi-1)
+ (guix build utils)
+ (guix build python-build-system))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'fix-libykpers-reference
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "ykman/driver_otp.py"
+ (("Ykpers\\('ykpers-1', '1'\\)")
+ (string-append
+ "Ykpers('"
+ (find (negate symbolic-link?)
+ (find-files (assoc-ref inputs "yubikey-personalization")
+ "^libykpers-.*\\.so\\..*"))
+ "')")))
+ #t)))))
(propagated-inputs
`(("python-six" ,python-six)
("python-pyscard" ,python-pyscard)
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#49342] [PATCH v2 0/1] Update Copyright
2021-07-03 4:32 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
2021-07-03 4:32 ` [bug#49342] [PATCH v2 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
@ 2021-07-08 6:12 ` Dhruvin Gandhi via Guix-patches via
1 sibling, 0 replies; 6+ messages in thread
From: Dhruvin Gandhi via Guix-patches via @ 2021-07-08 6:12 UTC (permalink / raw)
To: 49342
Dhruvin Gandhi <contact@dhruvin.dev> writes:
> I missed updating the copyright in last patch. Here's v2.
>
> Dhruvin Gandhi (1):
> gnu: python-yubikey-manager: Fix libykpers reference.
>
> gnu/packages/security-token.scm | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
>
> base-commit: eef099a2e1648032c571567c6da29ccd86e72058
> --
> 2.32.0
Are there any updates on the patch? It'd be great if we can merge it.
The patch only adds (links) a missing library at runtime. It can be
verified by running `ykman -v` before and after the patch.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49342: [PATCH 0/1] Fix libykpers reference in python-yubikey-manager
2021-07-03 4:32 ` [bug#49342] [PATCH v2 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
@ 2021-07-30 20:50 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2021-07-30 20:50 UTC (permalink / raw)
To: Dhruvin Gandhi; +Cc: 49342-done
Hi Dhruvin,
Dhruvin Gandhi <contact@dhruvin.dev> skribis:
> * gnu/packages/security-token.scm (python-yubikey-manager): Fix libykpers reference.
Applied.
Thank you, and apologies for the delay!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-30 20:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 21:18 [bug#49342] [PATCH 0/1] Fix libykpers reference in python-yubikey-manager Dhruvin Gandhi via Guix-patches via
2021-07-02 21:21 ` [bug#49342] [PATCH 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
2021-07-03 4:32 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
2021-07-03 4:32 ` [bug#49342] [PATCH v2 1/1] gnu: python-yubikey-manager: Fix libykpers reference Dhruvin Gandhi via Guix-patches via
2021-07-30 20:50 ` bug#49342: [PATCH 0/1] Fix libykpers reference in python-yubikey-manager Ludovic Courtès
2021-07-08 6:12 ` [bug#49342] [PATCH v2 0/1] Update Copyright Dhruvin Gandhi via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).