From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uG09ARZ0X2GxIgEAgWs5BA (envelope-from ) for ; Fri, 08 Oct 2021 00:26:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YLWYOBV0X2EsewAA1q6Kng (envelope-from ) for ; Thu, 07 Oct 2021 22:26:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC7D6D607 for ; Fri, 8 Oct 2021 00:26:29 +0200 (CEST) Received: from localhost ([::1]:53644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYbqO-0007W4-Gn for larch@yhetil.org; Thu, 07 Oct 2021 18:26:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYbl8-0005pT-VI for guix-patches@gnu.org; Thu, 07 Oct 2021 18:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYbl8-000265-Ln for guix-patches@gnu.org; Thu, 07 Oct 2021 18:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYbl8-0001Rp-Hh for guix-patches@gnu.org; Thu, 07 Oct 2021 18:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51061] [PATCH v2 01/23] guix: Add extracting-download. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Oct 2021 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51061 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 42180@debbugs.gnu.org, Maxime Devos , GNU Guix maintainers , 51061@debbugs.gnu.org Received: via spool by 51061-submit@debbugs.gnu.org id=B51061.16336452565522 (code B ref 51061); Thu, 07 Oct 2021 22:21:02 +0000 Received: (at 51061) by debbugs.gnu.org; 7 Oct 2021 22:20:56 +0000 Received: from localhost ([127.0.0.1]:48647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYbl2-0001Qz-Je for submit@debbugs.gnu.org; Thu, 07 Oct 2021 18:20:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYbl0-0001Qi-9S; Thu, 07 Oct 2021 18:20:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50662) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYbks-0001sc-B6; Thu, 07 Oct 2021 18:20:46 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59190 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYbkq-0006tm-8w; Thu, 07 Oct 2021 18:20:46 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <626e4718c45c95a7278460f132bd38e08835e9f4.1633533541.git.h.goebel@crazy-compilers.com> <1aa101af088dceee34ad9373f153b5f7dd7603ba.1633533541.git.h.goebel@crazy-compilers.com> <2c66b294-9ed0-2e50-da45-47f56af904cb@crazy-compilers.com> <547ce621-59be-cc29-2ea2-a29ff8151227@crazy-compilers.com> <14770aaa1de2c9f540a6a9600eb4122812075910.camel@telenet.be> Date: Fri, 08 Oct 2021 00:20:36 +0200 In-Reply-To: (Hartmut Goebel's message of "Thu, 7 Oct 2021 22:57:02 +0200") Message-ID: <87pmsg79zf.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633645589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=N0AEMwaaaFPIDZ2jBUx/99qpk/Tg1u7h1EvBnM6Uk48=; b=OHgRH4yod7ILuxdpMtYTk1PkZPzv56SW1lYly8eoZLPWYT5T9EQb7+5OvcSoZHaz3uTHn2 FogNQbeEhnRfJ+CmR9PauieO+5SHVU6u6nSf8YP9s/2TeC4J6KF1ubx/u1AUF+Q4Ku3O4D 0y6+aQInY9fUwcTDR48jp7E3EDCG1Bf6M9kK96vqe1HjMKuaOE3vS4eYRpWe5sVsSx6sRq v1G33Qp3Sh+GIM+cDGUcxVz82pnvwGCMCyeM9t8Bc9C5vQaBCUuLmLI3qvh9dHfXFSjqdP alkYIVk02Tz5okhX4JHVznZgy9zrPLVOsn43/ZN1oEdfFYuigCxtqYadoJ/Jpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633645589; a=rsa-sha256; cv=none; b=MILlmd16sfHTf3EdVHRj49cu5YSg/50x+OC6Y2sdBWy9xb1hP7FNEEqcOeEGeVfeWcbpbg z2fMt1y4bcK8z3olVkDm4peJsylt/iUbTltuukwftLSCGDuLp5Nmswwa6gjC8Xwx3WtjWY bsViJdYoFgMsaJXFtHoslrO12JV2h8qEoaikffGjyYEwrNZY82BeLFihts0AFCfmW2CDlr hbiRACdfLK3KKApghVhfqtXWiXV8BsNLjiHOJvy4vREhXhMs8vjbmjSlEUEoqPtQ8DEEcR UzZhJtG0ws556iofJ3VY/ggSITvPjsc3vPk5Y+RNZZoM4DubKBk9nILzyiYqGA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.22 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BC7D6D607 X-Spam-Score: -2.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: tvi6Qypmwl1J Hi, Hartmut Goebel skribis: > thanks for the review. I applied the changes as discussed, fixed some > last-minute bug in the importer :-) and pushed as=20 > f86f7e24b39928247729020df0134e2e1c4cde62. That=E2=80=99s really not how we work, nor how we should work IMO. There w= ere ~24h between the time you sent this series and the time you pushed it, only quick comments on 2 patches out of 23, and zero =E2=80=9CLGTMs=E2=80= =9D. I would very much like us to stick to our standards, in particular when proposing changes or additions to core APIs under (guix =E2=80=A6). These things just cannot go in without proper review; they cannot go in without adequate testing and documentation, as has always been done in these areas. Perhaps views differ on what =E2=80=9Cproper review=E2=80=9D is, and we can= discuss it if in doubt. For one thing, and I thought you were familiar with it since you=E2=80=99ve been around for some time, when someone is done review= ing a specific bit, they explicitly say so with =E2=80=9CLGTM=E2=80=9D or similar. Now, how do we move forward? I would prefer a single patch reverting all 23 patches now rather than a myriad of tiny fixups hastily reviewed. WDYT? I should say that while I=E2=80=99m unhappy with the way this has been done= , I=E2=80=99m glad you=E2=80=99re made this much progress on the Erlang front, and I think it=E2=80=99s a nice addition. Thanks, Ludo=E2=80=99.