unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Brian Kubisiak <brian@kubisiak.com>
Cc: 51990@debbugs.gnu.org
Subject: [bug#51990] [PATCH] gnu: Add emacs-bazel.
Date: Sun, 21 Nov 2021 21:30:52 +0100	[thread overview]
Message-ID: <87pmqtuu83.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <YZg94OdgZs/3Inzy@neutron> (Brian Kubisiak's message of "Fri, 19 Nov 2021 16:14:24 -0800")

Hello,

Brian Kubisiak <brian@kubisiak.com> writes:

> * gnu/packages/emacs-xyz (emacs-bazel): New variable.

Thank you. Some comments follow.
>
> Signed-off-by: Brian Kubisiak <brian@kubisiak.com>

We don't sign our own commits. So the line above is not necessary.

> +(define-public emacs-bazel
> +  (package
> +    (name "emacs-bazel")
> +    (version "20211031.1941")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/bazel-"
> +                           version ".el"))

We don't trust MELPA as a reliable source. Could you use git-fetch
instead, and get source files from upstream instead?

Also, the version is "O", according to "Version" keyword in "bazel.el"
file.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-11-21 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-20  0:14 [bug#51990] [PATCH] gnu: Add emacs-bazel Brian Kubisiak
2021-11-21 20:30 ` Nicolas Goaziou [this message]
2021-11-23  0:27 ` Brian Kubisiak
2021-11-23  9:30   ` bug#51990: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmqtuu83.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=51990@debbugs.gnu.org \
    --cc=brian@kubisiak.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).