From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gBovDm8u2GGYZQEAgWs5BA (envelope-from ) for ; Fri, 07 Jan 2022 13:13:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +JamC28u2GETMgEA9RJhRA (envelope-from ) for ; Fri, 07 Jan 2022 13:13:35 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC09ACAA7 for ; Fri, 7 Jan 2022 13:13:34 +0100 (CET) Received: from localhost ([::1]:41216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5o7h-0002mt-R2 for larch@yhetil.org; Fri, 07 Jan 2022 07:13:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5niA-0006Ck-UZ for guix-patches@gnu.org; Fri, 07 Jan 2022 06:47:12 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5ni2-0002g2-HD for guix-patches@gnu.org; Fri, 07 Jan 2022 06:47:09 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5ni2-00080d-GA for guix-patches@gnu.org; Fri, 07 Jan 2022 06:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-command-in-installer in (gnu installer parted). Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Jan 2022 11:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53063 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: othacehe@gnu.org, 53063@debbugs.gnu.org X-Debbugs-Original-To: Mathieu Othacehe , Josselin Poiret via Guix-patches via X-Debbugs-Original-Cc: 53063@debbugs.gnu.org Received: via spool by 53063-submit@debbugs.gnu.org id=B53063.164155599930728 (code B ref 53063); Fri, 07 Jan 2022 11:47:02 +0000 Received: (at 53063) by debbugs.gnu.org; 7 Jan 2022 11:46:39 +0000 Received: from localhost ([127.0.0.1]:43220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5nhf-0007zY-4B for submit@debbugs.gnu.org; Fri, 07 Jan 2022 06:46:39 -0500 Received: from jpoiret.xyz ([206.189.101.64]:43146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5nhd-0007zQ-8x for 53063@debbugs.gnu.org; Fri, 07 Jan 2022 06:46:38 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id EF1E1184D67; Fri, 7 Jan 2022 11:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1641555995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RDTc1VLIlwgL5kA4CsBh6PGAvgOcCMuHexiz9TMeGpY=; b=SJwWPlGf1bIr8EaO3/+85ShV/BD5umXOnvIbZj4tWzww2/guQJQHykc63ZBYrA4LUQLgwQ jXvjDUx96BCmbBigqz50qVfMi4z9AeyVm2HbbwYFxPrMLFQ2fKzLDyZUDT48kQpUgkyDxi 3aL9ZLemYtbwSDZ23DFojP6OdaILNYvXlKm4dM+c+8d9A7cE/TM+chT+LVzr/6Hs6x8NfG jtNByFltDav9K4PsXaxD9OQ/P1xeGVPwk4zctVmbY6qrQBSGeOhqkPh4Hm+1hdF/mP/ZhW mKx6fHp1+5pmq33jmsnflRdSy2/Lvi6oWVJGFS6bqDjgb9/NOWgeEGs8/HJP/w== In-Reply-To: <8735lz4xsv.fsf@gnu.org> References: <8735lz4xsv.fsf@gnu.org> Date: Fri, 07 Jan 2022 12:46:34 +0100 Message-ID: <87pmp3dazp.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641557614; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=RDTc1VLIlwgL5kA4CsBh6PGAvgOcCMuHexiz9TMeGpY=; b=pHu/P/3SyVpwNwglXfPfGJ+S7YSArP2mBOovwO2n0Lb7BahF5/HEtvIKPhpG6tIQeoUKF5 FihafjGp12r+fKhNV9iD+Fj5V8YYDmWL3PeudWvvh5CvA0w8Ps/rQGRQtPE5WAm5ePQLfD vE+fqwNT3jMA03ZQTWvWxUDFtVqQDb1Pk83n0WVFmkFskE8+Ju2ngj3I5PZv2d5XJFWgrx 6kD29bdrm4suNQUmSAyn2tFKbHB4At5UF71dq1U2DqjWAS193DxMBDGCidLaoqDq8mGOZG mTPs425t1VSbjCCB+S0/5BIoG7NxYvPozqs7jsdK+ArjnN7Q/jOu4SARBiQksg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641557614; a=rsa-sha256; cv=none; b=r2cgii+ucc1003sZOpwgyaS2wamfg/B0upzC2c8BThqTXWaPlxnYpQEV/N+dlbbdVuhYwY dUEWjqg4lBPaqs6WNUvNz33qEF1IbyuIKvqJ/45hqmNKmlDzIkeg79FKZCG41dwK4RNuAo Rx3Vz7gvUwuuW+k8TWvMRp8FwSnBGHYOLitLCgkFLcinqYhTGElquhqMICiENcAm2tN51G tuqxZkUdUzD33jEAavZLaF2/IOKYURnT+yntnpuWLcN4ed2Kq0X21b13Fr2rSqFbRS+ymr Aj/bwcNxUBvDR33ViBhlZ3mzFxv58tk73PAIiCw0t0jZ83EZ1jPQOe+s37eMsg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=SJwWPlGf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=SJwWPlGf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CC09ACAA7 X-Spam-Score: -4.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: rWxTInYsnSCr Hello Mathieu, Mathieu Othacehe writes: > Maybe we could only display those "External command" pages when the > command fails? Seems like my mental checklist swiftly removed the "Update installer tests" part. I still like having every command the installer runs displayed to me, but that's personal preference I reckon. Maybe I could look into making the tests simply confirm every single confirmation page? > Another issue is that if any partitioning command fails, the installer > keeps going. Maybe we should instead propose to abort the installation > or restart the partitioning step? Right, this patchset is still missing the switch to exceptions, along with raising a condition on command error. I will post a follow-up patchset addressing these! One thing though, is that &invoke-error is not exported by (gnu build utils). I think for now using @@ would be the right solution to avoid a world rebuild. -- Josselin Poiret