From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eELAKnMyAGKoawAAgWs5BA (envelope-from ) for ; Sun, 06 Feb 2022 21:41:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EGIVKHMyAGK2gQAA9RJhRA (envelope-from ) for ; Sun, 06 Feb 2022 21:41:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 264732E546 for ; Sun, 6 Feb 2022 21:41:23 +0100 (CET) Received: from localhost ([::1]:34880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGoLZ-0001g8-0X for larch@yhetil.org; Sun, 06 Feb 2022 15:41:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGoLJ-0001ft-3W for guix-patches@gnu.org; Sun, 06 Feb 2022 15:41:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGoLG-0006BC-J2 for guix-patches@gnu.org; Sun, 06 Feb 2022 15:41:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGoLG-0004fD-9A for guix-patches@gnu.org; Sun, 06 Feb 2022 15:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53673] [PATCH] Add package: emacs-beacon-1.3.4 Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Feb 2022 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Cc: 53673@debbugs.gnu.org Received: via spool by 53673-submit@debbugs.gnu.org id=B53673.164418000217831 (code B ref 53673); Sun, 06 Feb 2022 20:41:02 +0000 Received: (at 53673) by debbugs.gnu.org; 6 Feb 2022 20:40:02 +0000 Received: from localhost ([127.0.0.1]:39895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGoKH-0004dV-V3 for submit@debbugs.gnu.org; Sun, 06 Feb 2022 15:40:02 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGoKF-0004cw-JD for 53673@debbugs.gnu.org; Sun, 06 Feb 2022 15:40:00 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 9A676FF803; Sun, 6 Feb 2022 20:39:52 +0000 (UTC) From: Nicolas Goaziou References: <20220131225040.268586-1-contact@phfrohring.com> Date: Sun, 06 Feb 2022 21:39:51 +0100 In-Reply-To: <20220131225040.268586-1-contact@phfrohring.com> ("Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?="'s message of "Mon, 31 Jan 2022 23:50:41 +0100") Message-ID: <87pmnzhgq0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644180083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=VtMFqd0DoTNZl8n6cng9OjQhnsj9aWJJ0OE2uKIABfc=; b=QEG9tkFroHP4wVHJqhlLvLwVgXrqJWCmQoFFDTVFbVC073qkX1sdaVuNxPeEb5qwi+4JNK 2OkF1qh7GSRTD45i35PJFMMX2KpjyRRHmDQdD6yv3at3H3xqt0bsDyLvI6fUAicxrczP0m hwvQc+8FP44rppInSXG/LrLAYS/N6FDiKgQ6RpI6QocTzegAA0ZojBcQDdD/vRKf7S3YiQ AvsVM/KevUEZavNbxaQiOnDL0Bua/1yUq7PH7XYyIwSPlU5DjdOGJczUqNIpiPl/18X0O8 b2S11F+TwLJ+jFw/1PPU134QSrlRCj6GODSiPXu8bSZYTPJA6dPKFeP1nZR2Ww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644180083; a=rsa-sha256; cv=none; b=kbGlpe5MNe0GaGAaK4TCDmj/PZpTWlx8Zq/3pqjEIHDgTLk2vpr0PJ91t5Mb4cCYMrl4ZG ChsBGz+VownlTCu80PGYpcYa0qWzVWmUTUMYvtO+7Uljoyj1qUr5OOl2BZLcHPwlYgTGOL xu6LEHW5FY4yx7G4Sg+iWlCtFL+QsIzoJiXK8jNyb6/oLV0BCF/LVlZ+BTeASj85NSFkxl xVxVotgmMSZUZUUMbiu1jk7t9HtmSmRqde8KuQ0Ho3Ed5d3d1xKKdAChlPHK96MMLK9Zhn D6wPicv6u95fiEvISEdlU4g3UJjYeSkrLD8HboA6969Xs7y2BTbhCoNCNAjZzQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.23 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 264732E546 X-Spam-Score: -3.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: G3/rR+U/HICS Hello, Pierre-Henry Fr=C3=B6hring writes: > --- > +(define-public emacs-beacon-1.3.4 Thank you. Some comments follow. First, the variable should not include the version string. So, you should write: (define-public emacs-beacon Then, you need to provide a proper commit message. Such messages are somewhat standardized in Guix. Here, this could be: gnu: Add emacs-beacon. * gnu/packages/emacs-xyz.scm (emacs-beacon): New variable. > + (package > + (name "emacs-beacon") > + (version "1.3.4") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/Malabarba/" > + (second (string-split name #\-)) > + "/archive/refs/tags/" version ".tar.gz= ")) This URL is not stable. Use git-fetch method, with version string as the ta= g. > + (synopsis "A light that follows your cursor around so you don't lose= it!") A synopsis may not start with an article. I suggest to use "guix lint" on your package definition. I suggest: Emacs minor mode creating a light that follows your cursor around > + (description > + "This is a global minor-mode. Turn it on everywhere with: (beacon-m= ode 1). > +Whenever the window scrolls a light will shine on top of your cursor so = you know where it is. > +That=E2=80=99s it.") The part about "(beacon-mode 1)" belongs to the manual, not the description. The last sentence can be dropped, too. Also, sentences should be separated with two spaces in descriptions. I suggest: Beacon is an Emacs minor-mode. Whenever the ... where it is. Could you send an updated patch? Regards, --=20 Nicolas Goaziou