unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#48006] [PATCH] gnu: Add python-stripe.
@ 2021-04-24 20:47 jgart via Guix-patches via
  2021-06-30  1:39 ` [bug#48006] Raghav Gururajan via Guix-patches via
  0 siblings, 1 reply; 5+ messages in thread
From: jgart via Guix-patches via @ 2021-04-24 20:47 UTC (permalink / raw)
  To: 48006
  Cc: Oliver Loaiza, Ekaitz Zarraga, rprior, leo, Raghav Gururajan,
	Roberto Beltran

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hi Guix!

Here is our efforts so far from today's meetup.

Attached is a patch for python-stripe.

https://github.com/stripe/stripe-python

all the best,

jgart

[-- Attachment #2: 0001-gnu-Add-python-stripe.patch --]
[-- Type: application/octet-stream, Size: 1860 bytes --]

From b478dcf548ec2bb0cc0c4f682bb4d2f314b9ed6b Mon Sep 17 00:00:00 2001
From: LibreMiami <packaging-guix@libremiami.org>
Date: Sat, 24 Apr 2021 16:22:20 -0400
Subject: [PATCH] gnu: Add python-stripe.

* gnu/packages/python-web.scm (python-stripe): New variable.

Co-authored-by: jgart <jgart@dismail.de>
Co-authored-by: BonfaceKilz <me@bonfacemunyoki.com>
Co-authored-by: Raghav Gururajan <rg@raghavgururajan.name>
---
 gnu/packages/python-web.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 4f34502e86..d9d35510e4 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -1685,6 +1685,31 @@ connection to each user.")
     (license license:asl2.0)
     (properties `((python2-variant . ,(delay python2-tornado))))))
 
+(define-public python-stripe
+  (package
+    (name "python-stripe")
+    (version "2.56.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "stripe" version))
+       (sha256
+        (base32
+         "0z3p8n004spmmzbla2xyikf28bc5fsl6i5056pqja3gfipxh9y9g"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:tests? #f)) ; tests require network access
+    (propagated-inputs
+      `(("python-requests" ,python-requests)))
+    (home-page "https://stripe.com")
+    (synopsis "Python bindings for the Stripe API")
+    (description
+"The Stripe Python library provides convenient access to the Stripe API
+from applications written in the Python language.  It includes a pre-defined set
+of classes for API resources that initialize themselves dynamically from API
+responses which makes it compatible with a wide range of versions of the Stripe API.")
+    (license license:expat)))
+
 (define-public python-tornado-6
   (package
     (name "python-tornado")
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#48006]
  2021-04-24 20:47 [bug#48006] [PATCH] gnu: Add python-stripe jgart via Guix-patches via
@ 2021-06-30  1:39 ` Raghav Gururajan via Guix-patches via
  2022-06-22 19:41   ` [bug#48006] [PATCH] gnu: Add python-stripe Maxim Cournoyer
  0 siblings, 1 reply; 5+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-30  1:39 UTC (permalink / raw)
  To: 48006; +Cc: jgart, packaging-guix


[-- Attachment #1.1: Type: text/plain, Size: 105 bytes --]

So it appears we can enable tests using stripe-mock. We'll package it as 
well and enable the tests.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#48006] [PATCH] gnu: Add python-stripe.
  2021-06-30  1:39 ` [bug#48006] Raghav Gururajan via Guix-patches via
@ 2022-06-22 19:41   ` Maxim Cournoyer
  2022-06-23  0:46     ` jgart via Guix-patches via
  0 siblings, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2022-06-22 19:41 UTC (permalink / raw)
  To: Raghav Gururajan, GNU Debbugs; +Cc: jgart, 48006, packaging-guix

tags 48006 moreinfo
thanks

Hello,

Raghav Gururajan <rg@raghavgururajan.name> writes:

> So it appears we can enable tests using stripe-mock. We'll package it
> as well and enable the tests.

Any update on this?  Adding a package without tests doesn't provide any
guarantee of about whether it is functional, so I'd rather we add
stripe-mock first.

Thanks,

Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#48006] [PATCH] gnu: Add python-stripe.
  2022-06-22 19:41   ` [bug#48006] [PATCH] gnu: Add python-stripe Maxim Cournoyer
@ 2022-06-23  0:46     ` jgart via Guix-patches via
  2022-06-23 16:42       ` bug#48006: " Maxim Cournoyer
  0 siblings, 1 reply; 5+ messages in thread
From: jgart via Guix-patches via @ 2022-06-23  0:46 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: Raghav Gururajan, GNU Debbugs, 48006, packaging-guix

On Wed, 22 Jun 2022 15:41:03 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> Any update on this?  Adding a package without tests doesn't provide any
> guarantee of about whether it is functional, so I'd rather we add
> stripe-mock first.
> 
> Thanks,
> 
> Maxim

Hi, this can be closed as someone had already merged python-stripe without stripe-mock in another ticket.

We should probably add stripe-mock and enable tests for python-stripe in a new contribution.

all best,

jgart




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#48006: [PATCH] gnu: Add python-stripe.
  2022-06-23  0:46     ` jgart via Guix-patches via
@ 2022-06-23 16:42       ` Maxim Cournoyer
  0 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2022-06-23 16:42 UTC (permalink / raw)
  To: jgart; +Cc: Raghav Gururajan, packaging-guix, 48006-done

OK,

jgart <jgart@dismail.de> writes:

> On Wed, 22 Jun 2022 15:41:03 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>> Any update on this?  Adding a package without tests doesn't provide any
>> guarantee of about whether it is functional, so I'd rather we add
>> stripe-mock first.
>> 
>> Thanks,
>> 
>> Maxim
>
> Hi, this can be closed as someone had already merged python-stripe without stripe-mock in another ticket.
>
> We should probably add stripe-mock and enable tests for python-stripe in a new contribution.

OK, sounds good.  Thanks for the heads-up.

For the record, you can close a ticket yourself by adding '-done' at the
end of the bug number in Debbugs, like so:

48006-done@debbugs.gnu.org

C.f.: "Synopsis of bug submission and followup addresses" at
https://debbugs.gnu.org/server-refcard.html.

Thank you!

Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-23 16:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24 20:47 [bug#48006] [PATCH] gnu: Add python-stripe jgart via Guix-patches via
2021-06-30  1:39 ` [bug#48006] Raghav Gururajan via Guix-patches via
2022-06-22 19:41   ` [bug#48006] [PATCH] gnu: Add python-stripe Maxim Cournoyer
2022-06-23  0:46     ` jgart via Guix-patches via
2022-06-23 16:42       ` bug#48006: " Maxim Cournoyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).