From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4OLOLA958mLHygAAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 17:11:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OMSuLA958mJIYAAA9RJhRA (envelope-from ) for ; Tue, 09 Aug 2022 17:11:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78455FC6D for ; Tue, 9 Aug 2022 17:11:11 +0200 (CEST) Received: from localhost ([::1]:54048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLQsw-0005aR-7j for larch@yhetil.org; Tue, 09 Aug 2022 11:11:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLQso-0005aB-87 for guix-patches@gnu.org; Tue, 09 Aug 2022 11:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLQsn-0008UC-Vu for guix-patches@gnu.org; Tue, 09 Aug 2022 11:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLQsn-0003dl-QA for guix-patches@gnu.org; Tue, 09 Aug 2022 11:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56803] [PATCH 0/6] Add hydrus network and its dependencies Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Aug 2022 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56803 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tomasz Jeneralczyk Cc: 56803@debbugs.gnu.org Received: via spool by 56803-submit@debbugs.gnu.org id=B56803.166005781113912 (code B ref 56803); Tue, 09 Aug 2022 15:11:01 +0000 Received: (at 56803) by debbugs.gnu.org; 9 Aug 2022 15:10:11 +0000 Received: from localhost ([127.0.0.1]:44483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLQry-0003cJ-JK for submit@debbugs.gnu.org; Tue, 09 Aug 2022 11:10:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLQru-0003bm-NQ for 56803@debbugs.gnu.org; Tue, 09 Aug 2022 11:10:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLQro-00088Q-2t; Tue, 09 Aug 2022 11:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=56yBVN9TZLsQq3+A2fMAiiXvm+gJv1+2z1rEOFXLLtY=; b=j4Ax0bkzZ3+nqAvTQcR2 uPcAvtPk1B9qIuwAqaPWz0Syx/b69jke16s5XKFkEF+HsWXnjmEqeV8vcuBRYfFK2oKzVCXq8GB5d wAW/k2hnKmO4iXDr3Mh6ZqqqCsUX0TZw5nolV67o6wrLf+nPunpQ8iBOeYO09mNCwOccsz/SuktkT cp3URie5JPlRQPrWNNqSAjD0LA5JG/bp1KSYxQdwATBwSQNMh8LZiuks9nsWJVWUkB2OWiuWeXy1B szITSla1+aoPi1M1cDTwmSTFJ6f9LBmHz6WkYz0KudPZ7EwHXWuK4ET9ccwkdziIMJrutEHfZVISY vAVHwS3G2/hQTQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52766 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLQrm-0005hK-Qn; Tue, 09 Aug 2022 11:09:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9622a5d87b172e7f9ae838da45f15eb0ba95e374.1658946720.git.tj@schwi.pl> Date: Tue, 09 Aug 2022 17:09:56 +0200 In-Reply-To: <9622a5d87b172e7f9ae838da45f15eb0ba95e374.1658946720.git.tj@schwi.pl> (Tomasz Jeneralczyk's message of "Wed, 27 Jul 2022 21:00:28 +0200") Message-ID: <87pmh95u7v.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660057871; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=56yBVN9TZLsQq3+A2fMAiiXvm+gJv1+2z1rEOFXLLtY=; b=FavyHGhGP4pgV6tbhz1ya+5SpRuDZB29uG+0at+hM7w7ns32nBrA4SIFXqp52/Rxi74Gbh MWmYa4SKdaxKDddKvIXmjHCVOKc1ROdCPFPl8dN/1oQCvlqUZGBMoVHZgP291r3dnkCl0T yqngTXhjKQP5KlrxZ2sGAfTfbNcwMrZLBH5qHNaSAVp26dFR0xuqifffaMopJQfVR8PUXl 3hyBkjgbUDEjzTSCr5k2GjcMbtr3kX5eNdei4mlnCKxIdOIBJnrskIDNNG8USGDx/AHUCy a1Uzmb/qYylxavrW6dA6KyCOrgc7QwCP7lczr/8S3KyKwKZhfH8Zl4nvR6zcoQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660057871; a=rsa-sha256; cv=none; b=YzPtvaMdeV6fsYRcBs0wL61D4U8JIrcR7KRz4uPoVq4QtxXwAlicXKRhiureQB4O3gA6gm ufMFP57hkGxP6IUILGhpJBzxpKkOLjaSAxQMuvmuE1AAXA5hAOsBhCaz/OoKgfGdTrGKim 0FHRcHnxsa+oCqJKGpyHhz6JNCEHKKVUvPkSvLZdsezFXgIFocXEnShX3yuOSlk+O0vkyu FASwrjrS+LVKsPfE7UlHGz/5H6+O+NECJWBwPGFjiiGnuNejK3ETfjDE9JyRx+OCQ4HvXg BSLgh7NzOxD877tLTGXa3aKoUN8wQGUJi/RYNkle/BizOASOL2NVSlGDYJp/JQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=j4Ax0bkz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=j4Ax0bkz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 78455FC6D X-Spam-Score: -5.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: zdJ5wfIqq2Up Hi Tomasz, Tomasz Jeneralczyk skribis: > Hydrus-network has a weekly release cycle and is meant to be used from it= s own > directory so I artificially spread it out to comply with guix's expectati= ons. > > Three binaries from inputs are copied into a directory hydrus knows about: > * ffmpeg - works as expected > * swftools - does not do anything neither on guix or Arch linux - possi= bly > an unfinished feature, but I left it in, in case it gets fixed in a fut= ure version. > * miniupnpc - times out on my system, but it should work otherwise. > > I was not able to build the program's help files. Updating > python-pymdown-extensions to its latest version might be the solution, but > this would require also packaging its new build system that is not presen= t in > guix yet. I decided to cut short there. Perhaps these comments, or some of them, should go as comments in the source? That will prove helpful next time you or someone else tries to work on the package. > + (with-imported-modules '((guix build utils)) This is unnecessary as (guix build utils) is always present on the build side. > + (replace 'install > + (lambda* (#:key outputs inputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (python (assoc-ref inputs "python")) > + (client-path (string-append out "/bin/hydrus")) > + (server-path (string-append out "/bin/hydrus-se= rver"))) Nitpick: GNU and Guix convention is to use the term =E2=80=9Cpath=E2=80=9D = to denote a search path (like $PATH, etc.) and to use =E2=80=9Cfile name=E2=80=9D (or = =E2=80=9Cfile=E2=80=9D) to denote a file name, as is the case here. In this case it might be enough to write =E2=80=98client=E2=80=99 instead of =E2=80=98client-path=E2=80=99, and similarly for =E2=80=98server-path=E2=80= =99. > + ;; Hydrus searches for some binaries at bin-dir so it's im= portant > + ;; to put them there so it can find and use them. In general, the solution here, rather than copy files like the =E2=80=98ffm= peg=E2=80=99 executable, would be to patch Hydrus so that it contains the absolute file name of =E2=80=98ffmpeg=E2=80=99 as returned by (search-input-file inp= uts "/bin/ffmpeg"). How does that sound? Thanks, Ludo=E2=80=99.