unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#53387] [PATCH 0/4] Update tdlib and telega packages
@ 2022-01-20 11:45 Andrew Tropin
  2022-01-22 15:14 ` Liliana Marie Prikler
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Tropin @ 2022-01-20 11:45 UTC (permalink / raw)
  To: 53387


[-- Attachment #1.1: Type: text/plain, Size: 613 bytes --]

tdlib and telega are inteded to be used from specific commits not tags, I keep
revision and commit parameters for those packages to make it easier to update
them to untagged commits in the future.

https://github.com/tdlib/td/issues/1790

Also, updated the style for arguments.

Andrew Tropin (4):
  gnu: tdlib: Update to 1.8.0.
  gnu: telega: Update to 0.8.01.
  gnu: tdlib: Use new package style.
  gnu: telega: Use new package style.

 gnu/packages/emacs-xyz.scm | 88 +++++++++++++++++++-------------------
 gnu/packages/messaging.scm | 38 ++++++++--------
 2 files changed, 65 insertions(+), 61 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-tdlib-Update-to-1.8.0.patch --]
[-- Type: text/x-patch, Size: 1415 bytes --]

From c64a936ba458676cee41a11a42202fda13dda8cb Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 20 Jan 2022 11:56:11 +0300
Subject: [PATCH 1/4] gnu: tdlib: Update to 1.8.0.

* gnu/packages/messaging.scm (tdlib): Update to 1.8.0.
---
 gnu/packages/messaging.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 2fe0d35a10..843dba2c61 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2593,10 +2593,11 @@ (define-public telegram-purple
     (license license:gpl2+)))
 
 (define-public tdlib
-  (let ((commit "34ba9b21f365b8d3bdc36808c2d665ca5cd128f6"))
+  (let ((commit "b3ab664a18f8611f4dfcd3054717504271eeaa7a")
+        (revision "1"))
     (package
       (name "tdlib")
-      (version "1.7.10")
+      (version (git-version "1.8.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -2604,7 +2605,7 @@ (define-public tdlib
                (url "https://github.com/tdlib/td")
                (commit commit)))
          (sha256
-          (base32 "06fbdh1jypz0p1rf6xbpias4kx7xplq9xjd9vz177vwj9icq3wki"))
+          (base32 "19psqpyh9a2kzfdhgqkirpif4x8pzy89phvi59dq155y30a3661q"))
          (file-name (git-file-name name version))))
       (build-system cmake-build-system)
       (arguments
-- 
2.34.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-gnu-telega-Update-to-0.8.01.patch --]
[-- Type: text/x-patch, Size: 1558 bytes --]

From 84d1bce32f1a18f1e733499f5dc9dd4bb8374aba Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 20 Jan 2022 11:56:22 +0300
Subject: [PATCH 2/4] gnu: telega: Update to 0.8.01.

* gnu/packages/emacs-xyz.scm (emacs-telega-server): Update to 0.8.01.
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b317d4dc58..ed58989f56 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26807,11 +26807,11 @@ (define-public emacs-helm-switch-to-repl
     (license license:gpl3+)))
 
 (define-public emacs-telega-server
-  (let ((commit "b4a5e206bd259f3d7f7633a725b2990704d6a1e8")
+  (let ((commit "5739794d2d0c8a4e7b77c2e37a097e19f80ac9f0")
         (revision "1"))
     (package
       (name "emacs-telega-server")
-      (version (git-version  "0.7.15" revision commit))
+      (version (git-version "0.8.01" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -26819,7 +26819,7 @@ (define-public emacs-telega-server
                (url "https://github.com/zevlg/telega.el")
                (commit commit)))
          (sha256
-          (base32 "0gr4nmpk175hxmj357bpzaqywbjc6dmmvfxnyzkh884vyzbwdxlc"))
+          (base32 "1am0b2bjjkw7zd0yq39v015a08dcbk43j4d4h8y2q8hj53ryfk5a"))
          (file-name (git-file-name "emacs-telega" version))
          (patches
           (search-patches "emacs-telega-path-placeholder.patch"
-- 
2.34.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.4: 0003-gnu-tdlib-Use-new-package-style.patch --]
[-- Type: text/x-patch, Size: 2403 bytes --]

From 4234d27ed60796b6c4927fdd378e75f6cdafa057 Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 20 Jan 2022 13:27:15 +0300
Subject: [PATCH 3/4] gnu: tdlib: Use new package style.

* gnu/packages/messaging.scm (tdlib): Use gexps, remove trailing #t.
---
 gnu/packages/messaging.scm | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 843dba2c61..f2d518fdf5 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2609,21 +2609,22 @@ (define-public tdlib
          (file-name (git-file-name name version))))
       (build-system cmake-build-system)
       (arguments
-       `(#:tests? #t
-         #:configure-flags
-         (list "-DCMAKE_BUILD_TYPE=Release"
-               "-DTD_ENABLE_LTO=OFF")   ; FIXME: Get LTO to work.
-         #:phases
-         (modify-phases %standard-phases
-           (add-after 'unpack 'remove-failing-tests
-             (lambda _
-               (substitute* "test/CMakeLists.txt"
-                 ;; The test cases are compiled into a distinct binary
-                 ;; which uses mtproto.cpp to attempt to connect to
-                 ;; a remote server. Removing this file from the sources
-                 ;; list disables those specific test cases.
-                 (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") ""))
-               #t)))))
+       (list
+        #:tests? #t
+        #:configure-flags
+        #~(list "-DCMAKE_BUILD_TYPE=Release"
+                "-DTD_ENABLE_LTO=OFF")   ; FIXME: Get LTO to work.
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'remove-failing-tests
+              (lambda _
+                (substitute* "test/CMakeLists.txt"
+                  ;; The test cases are compiled into a distinct binary
+                  ;; which uses mtproto.cpp to attempt to connect to
+                  ;; a remote server. Removing this file from the sources
+                  ;; list disables those specific test cases.
+                  (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") ""))
+                )))))
       (native-inputs
        (list gperf openssl zlib php doxygen))
       (synopsis "Cross-platform library for building Telegram clients")
-- 
2.34.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.5: 0004-gnu-telega-Use-new-package-style.patch --]
[-- Type: text/x-patch, Size: 5406 bytes --]

From 6a57549e00616dae5ae8e35e7375e60e2dfe68aa Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 20 Jan 2022 14:09:14 +0300
Subject: [PATCH 4/4] gnu: telega: Use new package style.

* gnu/packages/emacs-xyz.scm (emacs-telega, emacs-telega-contrib): Use gexps,
remove trailing #t.
---
 gnu/packages/emacs-xyz.scm | 82 +++++++++++++++++++-------------------
 1 file changed, 42 insertions(+), 40 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed58989f56..c94f8443d9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26863,39 +26863,40 @@ (define-public emacs-telega
     (name "emacs-telega")
     (build-system emacs-build-system)
     (arguments
-     `(#:emacs ,(if (target-64bit?)
-                    emacs-minimal
-                    ;; Require wide-int support for 32-bit platform.
-                    emacs-wide-int)
-       #:include (cons "^etc\\/" %default-include)
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'patch-sources
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; Hard-code paths to `ffplay` and `ffmpeg`.
-             (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay"))
-                    (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg")))
-               (substitute* '("telega-ffplay.el" "telega-vvnote.el")
-                 (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe)"
-                   all func cmd)
-                  (string-append func " \""
-                                 (search-input-file
-                                  inputs (string-append "/bin/" cmd))))
-                 (("\\(executable-find \"ffplay\"\\)")
-                  (string-append "(and (file-executable-p \"" ffplay-bin "\")"
-                                 "\"" ffplay-bin "\")"))
-                 (("\\(executable-find \"ffmpeg\"\\)")
-                  (string-append "(and (file-executable-p \"" ffmpeg-bin "\")"
-                                 "\"" ffmpeg-bin "\")"))))))
-         (add-after 'unpack 'configure
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (substitute* "telega-customize.el"
-               (("@TELEGA_SERVER_BIN@")
-                (search-input-file inputs "/bin/telega-server")))
-             (substitute* "telega-util.el"
-               (("@TELEGA_SHARE@")
-                (string-append (elpa-directory (assoc-ref outputs "out"))
-                               "/etc"))))))))
+     (list
+      #:emacs (if (target-64bit?)
+                  emacs-minimal
+                  ;; Require wide-int support for 32-bit platform.
+                  emacs-wide-int)
+      #:include #~(cons "^etc\\/" %default-include)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-sources
+            (lambda* (#:key inputs #:allow-other-keys)
+              ;; Hard-code paths to `ffplay` and `ffmpeg`.
+              (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay"))
+                     (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg")))
+                (substitute* '("telega-ffplay.el" "telega-vvnote.el")
+                  (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe)"
+                    all func cmd)
+                   (string-append func " \""
+                                  (search-input-file
+                                   inputs (string-append "/bin/" cmd))))
+                  (("\\(executable-find \"ffplay\"\\)")
+                   (string-append "(and (file-executable-p \"" ffplay-bin "\")"
+                                  "\"" ffplay-bin "\")"))
+                  (("\\(executable-find \"ffmpeg\"\\)")
+                   (string-append "(and (file-executable-p \"" ffmpeg-bin "\")"
+                                  "\"" ffmpeg-bin "\")"))))))
+          (add-after 'unpack 'configure
+            (lambda* (#:key inputs outputs #:allow-other-keys)
+              (substitute* "telega-customize.el"
+                (("@TELEGA_SERVER_BIN@")
+                 (search-input-file inputs "/bin/telega-server")))
+              (substitute* "telega-util.el"
+                (("@TELEGA_SHARE@")
+                 (string-append (elpa-directory (assoc-ref outputs "out"))
+                                "/etc"))))))))
     (inputs
      (list emacs-telega-server ffmpeg))
     (native-inputs '())
@@ -26911,13 +26912,14 @@ (define-public emacs-telega-contrib
     (inherit emacs-telega)
     (name "emacs-telega-contrib")
     (arguments
-     `(#:exclude '("telega-live-location.el")
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'enter-subdirectory
-           (lambda _ (chdir "contrib") #t))
-         (add-before 'install-license-files 'leave-subdirectory
-           (lambda _ (chdir "..") #t)))))
+     (list
+      #:exclude '("telega-live-location.el")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'enter-subdirectory
+            (lambda _ (chdir "contrib")))
+          (add-before 'install-license-files 'leave-subdirectory
+            (lambda _ (chdir ".."))))))
     (inputs '())
     (native-inputs '())
     (propagated-inputs
-- 
2.34.0


[-- Attachment #1.6: Type: text/plain, Size: 17 bytes --]


-- 
2.34.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#53387] [PATCH 0/4] Update tdlib and telega packages
  2022-01-20 11:45 [bug#53387] [PATCH 0/4] Update tdlib and telega packages Andrew Tropin
@ 2022-01-22 15:14 ` Liliana Marie Prikler
  2022-01-27  7:54   ` Andrew Tropin
  0 siblings, 1 reply; 5+ messages in thread
From: Liliana Marie Prikler @ 2022-01-22 15:14 UTC (permalink / raw)
  To: Andrew Tropin, 53387; +Cc: Nicolas Goaziou

Hi Andrew, 

Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin:
> tdlib and telega are inteded to be used from specific commits not
> tags, I keep revision and commit parameters for those packages to
> make it easier to update them to untagged commits in the future.
> 
> https://github.com/tdlib/td/issues/1790
> 
> Also, updated the style for arguments.
It appears Telega was already updated through a different patch.  The
style adjustments are still relevant, but fail to apply currently.

As for commit vs. tag, I've CC'd Nicolas to make a more informed
decision.  I do understand your reasoning, but OTOH I disagree with
Telegram's "every commit is as good as a release" stance, particularly
if there's a widely used client whose releases fail in CI :)




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#53387] [PATCH 0/4] Update tdlib and telega packages
  2022-01-22 15:14 ` Liliana Marie Prikler
@ 2022-01-27  7:54   ` Andrew Tropin
  2022-11-26 12:58     ` Liliana Marie Prikler
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Tropin @ 2022-01-27  7:54 UTC (permalink / raw)
  To: Liliana Marie Prikler, 53387; +Cc: zevlg, Nicolas Goaziou, avityazev


[-- Attachment #1.1: Type: text/plain, Size: 1215 bytes --]

CCed: avityazev, zevlg

On 2022-01-22 16:14, Liliana Marie Prikler wrote:

> Hi Andrew, 
>
> Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin:
>> tdlib and telega are inteded to be used from specific commits not
>> tags, I keep revision and commit parameters for those packages to
>> make it easier to update them to untagged commits in the future.
>> 
>> https://github.com/tdlib/td/issues/1790
>> 
>> Also, updated the style for arguments.
> It appears Telega was already updated through a different patch.  The
> style adjustments are still relevant, but fail to apply currently.
>

Updated patches.

> 
> As for commit vs. tag, I've CC'd Nicolas to make a more informed
> decision.  I do understand your reasoning, but OTOH I disagree with
> Telegram's "every commit is as good as a release" stance, particularly
> if there's a widely used client whose releases fail in CI :)

I agree, tdlib rolling release seems a little strange to me and I
personally not in a favor of it.  I still propose to keep commit and
revision variables for both tdlib and telega to be able to update them
from time to time to a fresh version, which surely won't have a release
tag.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-telega-Use-new-package-style.patch --]
[-- Type: text/x-patch, Size: 5406 bytes --]

From 78e24c360cbd9c9cd791f56aeb290fffbc29ebae Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 20 Jan 2022 14:09:14 +0300
Subject: [PATCH 1/2] gnu: telega: Use new package style.

* gnu/packages/emacs-xyz.scm (emacs-telega, emacs-telega-contrib): Use gexps,
remove trailing #t.
---
 gnu/packages/emacs-xyz.scm | 82 +++++++++++++++++++-------------------
 1 file changed, 42 insertions(+), 40 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 387f1b93fd..d456a6cd52 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27030,39 +27030,40 @@ (define-public emacs-telega
     (name "emacs-telega")
     (build-system emacs-build-system)
     (arguments
-     `(#:emacs ,(if (target-64bit?)
-                    emacs-minimal
-                    ;; Require wide-int support for 32-bit platform.
-                    emacs-wide-int)
-       #:include (cons "^etc\\/" %default-include)
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'patch-sources
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; Hard-code paths to `ffplay` and `ffmpeg`.
-             (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay"))
-                    (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg")))
-               (substitute* '("telega-ffplay.el" "telega-vvnote.el")
-                 (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe)"
-                   all func cmd)
-                  (string-append func " \""
-                                 (search-input-file
-                                  inputs (string-append "/bin/" cmd))))
-                 (("\\(executable-find \"ffplay\"\\)")
-                  (string-append "(and (file-executable-p \"" ffplay-bin "\")"
-                                 "\"" ffplay-bin "\")"))
-                 (("\\(executable-find \"ffmpeg\"\\)")
-                  (string-append "(and (file-executable-p \"" ffmpeg-bin "\")"
-                                 "\"" ffmpeg-bin "\")"))))))
-         (add-after 'unpack 'configure
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (substitute* "telega-customize.el"
-               (("@TELEGA_SERVER_BIN@")
-                (search-input-file inputs "/bin/telega-server")))
-             (substitute* "telega-util.el"
-               (("@TELEGA_SHARE@")
-                (string-append (elpa-directory (assoc-ref outputs "out"))
-                               "/etc"))))))))
+     (list
+      #:emacs (if (target-64bit?)
+                  emacs-minimal
+                  ;; Require wide-int support for 32-bit platform.
+                  emacs-wide-int)
+      #:include #~(cons "^etc\\/" %default-include)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-sources
+            (lambda* (#:key inputs #:allow-other-keys)
+              ;; Hard-code paths to `ffplay` and `ffmpeg`.
+              (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay"))
+                     (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg")))
+                (substitute* '("telega-ffplay.el" "telega-vvnote.el")
+                  (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe)"
+                    all func cmd)
+                   (string-append func " \""
+                                  (search-input-file
+                                   inputs (string-append "/bin/" cmd))))
+                  (("\\(executable-find \"ffplay\"\\)")
+                   (string-append "(and (file-executable-p \"" ffplay-bin "\")"
+                                  "\"" ffplay-bin "\")"))
+                  (("\\(executable-find \"ffmpeg\"\\)")
+                   (string-append "(and (file-executable-p \"" ffmpeg-bin "\")"
+                                  "\"" ffmpeg-bin "\")"))))))
+          (add-after 'unpack 'configure
+            (lambda* (#:key inputs outputs #:allow-other-keys)
+              (substitute* "telega-customize.el"
+                (("@TELEGA_SERVER_BIN@")
+                 (search-input-file inputs "/bin/telega-server")))
+              (substitute* "telega-util.el"
+                (("@TELEGA_SHARE@")
+                 (string-append (elpa-directory (assoc-ref outputs "out"))
+                                "/etc"))))))))
     (inputs
      (list emacs-telega-server ffmpeg))
     (native-inputs '())
@@ -27078,13 +27079,14 @@ (define-public emacs-telega-contrib
     (inherit emacs-telega)
     (name "emacs-telega-contrib")
     (arguments
-     `(#:exclude '("telega-live-location.el")
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'enter-subdirectory
-           (lambda _ (chdir "contrib") #t))
-         (add-before 'install-license-files 'leave-subdirectory
-           (lambda _ (chdir "..") #t)))))
+     (list
+      #:exclude '("telega-live-location.el")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'enter-subdirectory
+            (lambda _ (chdir "contrib")))
+          (add-before 'install-license-files 'leave-subdirectory
+            (lambda _ (chdir ".."))))))
     (inputs '())
     (native-inputs '())
     (propagated-inputs
-- 
2.34.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-gnu-tdlib-Use-new-package-style.patch --]
[-- Type: text/x-patch, Size: 2296 bytes --]

From 90a77ee77aa4f339c9cee978e96ee72e1316bcd9 Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Thu, 20 Jan 2022 13:27:15 +0300
Subject: [PATCH 2/2] gnu: tdlib: Use new package style.

* gnu/packages/messaging.scm (tdlib): Use gexps, remove trailing #t.
---
 gnu/packages/messaging.scm | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 768642f119..01316f8bd2 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2612,20 +2612,21 @@ (define-public tdlib
        (file-name (git-file-name name version))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #t
-       #:configure-flags
-       (list "-DCMAKE_BUILD_TYPE=Release"
-             "-DTD_ENABLE_LTO=OFF")     ; FIXME: Get LTO to work.
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'remove-failing-tests
-           (lambda _
-             (substitute* "test/CMakeLists.txt"
-               ;; The test cases are compiled into a distinct binary
-               ;; which uses mtproto.cpp to attempt to connect to
-               ;; a remote server. Removing this file from the sources
-               ;; list disables those specific test cases.
-               (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))))
+     (list
+      #:tests? #t
+      #:configure-flags
+      #~(list "-DCMAKE_BUILD_TYPE=Release"
+              "-DTD_ENABLE_LTO=OFF")     ; FIXME: Get LTO to work.
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'remove-failing-tests
+            (lambda _
+              (substitute* "test/CMakeLists.txt"
+                ;; The test cases are compiled into a distinct binary
+                ;; which uses mtproto.cpp to attempt to connect to
+                ;; a remote server. Removing this file from the sources
+                ;; list disables those specific test cases.
+                (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))))
     (native-inputs
      (list gperf openssl zlib php doxygen))
     (synopsis "Cross-platform library for building Telegram clients")
-- 
2.34.0


[-- Attachment #1.4: Type: text/plain, Size: 37 bytes --]


-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#53387] [PATCH 0/4] Update tdlib and telega packages
  2022-01-27  7:54   ` Andrew Tropin
@ 2022-11-26 12:58     ` Liliana Marie Prikler
  2022-11-28  5:43       ` Andrew Tropin
  0 siblings, 1 reply; 5+ messages in thread
From: Liliana Marie Prikler @ 2022-11-26 12:58 UTC (permalink / raw)
  To: Andrew Tropin, 53387; +Cc: zevlg, Nicolas Goaziou, avityazev

Hi Andrew,

sorry for not reacting earlier.  Is this patch still "fresh and
relevant"?  Should we aim for newer versions?

Am Donnerstag, dem 27.01.2022 um 10:54 +0300 schrieb Andrew Tropin:
> CCed: avityazev, zevlg
> 
> On 2022-01-22 16:14, Liliana Marie Prikler wrote:
> 
> > Hi Andrew, 
> > 
> > Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin:
> > > tdlib and telega are inteded to be used from specific commits not
> > > tags, I keep revision and commit parameters for those packages to
> > > make it easier to update them to untagged commits in the future.
> > > 
> > > https://github.com/tdlib/td/issues/1790
> > > 
> > > Also, updated the style for arguments.
> > It appears Telega was already updated through a different patch. 
> > The style adjustments are still relevant, but fail to apply
> > currently.
> > 
> 
> Updated patches.
> 
> > 
> > As for commit vs. tag, I've CC'd Nicolas to make a more informed
> > decision.  I do understand your reasoning, but OTOH I disagree with
> > Telegram's "every commit is as good as a release" stance,
> > particularly if there's a widely used client whose releases fail in
> > CI :)
> 
> I agree, tdlib rolling release seems a little strange to me and I
> personally not in a favor of it.  I still propose to keep commit and
> revision variables for both tdlib and telega to be able to update
> them from time to time to a fresh version, which surely won't have a
> release tag.
> 
> 





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#53387] [PATCH 0/4] Update tdlib and telega packages
  2022-11-26 12:58     ` Liliana Marie Prikler
@ 2022-11-28  5:43       ` Andrew Tropin
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Tropin @ 2022-11-28  5:43 UTC (permalink / raw)
  To: Liliana Marie Prikler, 53387; +Cc: zevlg, Nicolas Goaziou, avityazev

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On 2022-11-26 13:58, Liliana Marie Prikler wrote:

> Hi Andrew,
>
> sorry for not reacting earlier.  Is this patch still "fresh and
> relevant"?  Should we aim for newer versions?
>
> Am Donnerstag, dem 27.01.2022 um 10:54 +0300 schrieb Andrew Tropin:
>> CCed: avityazev, zevlg
>> 
>> On 2022-01-22 16:14, Liliana Marie Prikler wrote:
>> 
>> > Hi Andrew, 
>> > 
>> > Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin:
>> > > tdlib and telega are inteded to be used from specific commits not
>> > > tags, I keep revision and commit parameters for those packages to
>> > > make it easier to update them to untagged commits in the future.
>> > > 
>> > > https://github.com/tdlib/td/issues/1790
>> > > 
>> > > Also, updated the style for arguments.
>> > It appears Telega was already updated through a different patch. 
>> > The style adjustments are still relevant, but fail to apply
>> > currently.
>> > 
>> 
>> Updated patches.
>> 
>> > 
>> > As for commit vs. tag, I've CC'd Nicolas to make a more informed
>> > decision.  I do understand your reasoning, but OTOH I disagree with
>> > Telegram's "every commit is as good as a release" stance,
>> > particularly if there's a widely used client whose releases fail in
>> > CI :)
>> 
>> I agree, tdlib rolling release seems a little strange to me and I
>> personally not in a favor of it.  I still propose to keep commit and
>> revision variables for both tdlib and telega to be able to update
>> them from time to time to a fresh version, which surely won't have a
>> release tag.
>> 
>> 
>

Hi Liliana,

version update seems outdated, emacs-telega-server and tdlib styles
updates outdated as well.

But emacs-telega and emacs-telega-contrib style updates looks relevant
and still applies.  Slightly updated the patch, applied, pushed.

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-28  5:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 11:45 [bug#53387] [PATCH 0/4] Update tdlib and telega packages Andrew Tropin
2022-01-22 15:14 ` Liliana Marie Prikler
2022-01-27  7:54   ` Andrew Tropin
2022-11-26 12:58     ` Liliana Marie Prikler
2022-11-28  5:43       ` Andrew Tropin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).