From: "Ludovic Courtès" <ludo@gnu.org>
To: Timo Wilken <guix@twilken.net>
Cc: 63647@debbugs.gnu.org, 63631@debbugs.gnu.org,
Simon Tournier <zimon.toutoune@gmail.com>,
54097@debbugs.gnu.org, wolf@wolfsden.cz
Subject: [bug#63631] [PATCH] import: go: Handle subpackage versioning correctly.
Date: Wed, 14 Jun 2023 23:09:35 +0200 [thread overview]
Message-ID: <87pm5xrbsg.fsf@gnu.org> (raw)
In-Reply-To: <6dd1de3dd4d968876fa55f5126056834c77b0244.1684703258.git.guix@twilken.net> (Timo Wilken's message of "Sun, 21 May 2023 23:18:08 +0200")
Hi Timo,
Timo Wilken <guix@twilken.net> skribis:
> Some Go source repositories (notably the Google Cloud SDK) contain multiple
> submodules and use a `refs/tags/<submodule>/<version>' tagging scheme.
>
> Fixes <https://bugs.gnu.org/54097>.
>
> * guix/import/go.scm (vcs->origin): Accept a module-path-suffix.
> (go-module->guix-package): Use the new parameter.
> ---
> Here's a patch that fixes the reported issue (bug#54097) for me. I've only
> tested this on the github.com/googleapis/google-cloud-go/compute package so
> far, though it seems to work there. Perhaps others have more testcases?
>
> I don't know enough about Go tooling to use it, so I've just patched the Guile
> logic of the importer. (I don't write Go, I just want to package stuff written
> in it.) In terms of performance, at least the repo contents are apparently
> cached by the first `git-checkout-hash' call, even if it fails, so the second
> call doesn't have to redownload them.
What you propose looks similar to part of the work Simon Tournier
submitted at <https://issues.guix.gnu.org/63647>.
What would you suggest? Simon?
Thanks for the patch, Timo!
Ludo’.
next prev parent reply other threads:[~2023-06-14 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 21:18 [bug#63631] [PATCH] import: go: Handle subpackage versioning correctly Timo Wilken
2023-05-21 21:54 ` wolf
2023-06-14 21:09 ` Ludovic Courtès [this message]
[not found] ` <CTF06XBYWPT0.1MV6QA1B2OB98@lap.twilken.net>
2023-08-16 15:59 ` [bug#64035] bug#63001: bug#63631: " Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm5xrbsg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54097@debbugs.gnu.org \
--cc=63631@debbugs.gnu.org \
--cc=63647@debbugs.gnu.org \
--cc=guix@twilken.net \
--cc=wolf@wolfsden.cz \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).