unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Herman Rimm <herman@rimm.ee>
Cc: 宋文武 <iyzsong@envs.net>, "Andreas Enge" <andreas@enge.fr>,
	57431@debbugs.gnu.org, "Zhu Zihao" <all_but_last@163.com>,
	"Maxim Cournoyer" <maxim.cournoyer@gmail.com>
Subject: [bug#57431] [PATCH v1 2/3] gnu: Add python-pyqt, version 6.5.2.
Date: Wed, 22 Nov 2023 16:47:46 +0100	[thread overview]
Message-ID: <87pm01kcwt.fsf@gnu.org> (raw)
In-Reply-To: <817ca09b733ed2163ec3147a1f131844fa0080e1.1700407095.git.herman@rimm.ee> (Herman Rimm's message of "Sun, 19 Nov 2023 16:18:14 +0100")

Herman Rimm <herman@rimm.ee> skribis:

> From: Zhu Zihao <all_but_last@163.com>
>
> * gnu/packages/qt.scm (python-pyqt-6): New variable.

[...]

> +    (inputs ; Qt5 dependencies only in python-pyqt:
> +     ; (qt)connectivity, location, sensors, serialport, x11extras, xmlpatterns.
> +     `(("python" ,python-wrapper)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)
> +       ("qtmultimedia" ,qtmultimedia)
> +       ("qtpositioning" ,qtpositioning)
> +       ("qtsvg" ,qtsvg)
> +       ("qttools" ,qttools)
> +       ("qtwebchannel" ,qtwebchannel)
> +       ("qtwebsockets" ,qtwebsockets)))

Could you run ‘guix style -f inputs --input-simplification=always python-pyqt-6’?

> +       #:phases
> +       #~(modify-phases %standard-phases
> +         ;; When building python-pyqtwebengine, <qprinter.h> can not be
> +         ;; included.  Here we substitute the full path to the header in the
> +         ;; store.
> +         (add-after 'unpack 'substitute-source
> +           (lambda* (#:key inputs  #:allow-other-keys)
> +             (let* ((qtbase (assoc-ref inputs "qtbase"))
> +                    (qtprinter.h (string-append "\"" qtbase "/include/qt6/QtPrintSupport/qprinter.h\"")))

I understand it’s copied from ‘python-pyqt’ but IWBN to write it along
these lines:

  (let ((qtprinter.h
         (search-input-file inputs
                            "/include/qt6/QtPrintSupport/qprinter.h")))
    …)

(We could make the same changes in ‘python-pyqt’ in a separate patch.)

Thanks,
Ludo’.




  reply	other threads:[~2023-11-22 15:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 14:50 [bug#57431] [PATCH]: Add PyQt 6 Zhu Zihao
2023-04-13 15:04 ` ROCKTAKEY
2023-04-16  2:16   ` Zhu Zihao
2023-11-19 15:15 ` [bug#57431] Update packages to compatible versions Herman Rimm via Guix-patches via
2023-11-19 15:18 ` [bug#57431] [PATCH v1 1/3] gnu: Add python-pyqt6-sip Herman Rimm via Guix-patches via
2023-11-19 15:18   ` [bug#57431] [PATCH v1 2/3] gnu: Add python-pyqt, version 6.5.2 Herman Rimm via Guix-patches via
2023-11-22 15:47     ` Ludovic Courtès [this message]
2023-11-19 15:18   ` [bug#57431] [PATCH v1 3/3] gnu: Add python-pyqtwebengine, version 6.6.0 Herman Rimm via Guix-patches via
2023-11-22 15:49     ` Ludovic Courtès
2023-11-22 15:43   ` [bug#57431] [PATCH v1 1/3] gnu: Add python-pyqt6-sip Ludovic Courtès
2023-11-23  7:20 ` [bug#57431] [PATCH v2 " Herman Rimm via Guix-patches via
2023-11-23  7:20   ` [bug#57431] [PATCH v2 2/3] gnu: Add python-pyqt, version 6.5.2 Herman Rimm via Guix-patches via
2023-11-23  7:20   ` [bug#57431] [PATCH v2 3/3] gnu: Add python-pyqtwebengine, version 6.6.0 Herman Rimm via Guix-patches via
2023-11-23 11:59 ` [bug#57431] [PATCH v3 1/3] gnu: Add python-pyqt6-sip Herman Rimm via Guix-patches via
2023-11-23 11:59   ` [bug#57431] [PATCH v3 2/3] gnu: Add python-pyqt, version 6.5.2 Herman Rimm via Guix-patches via
2023-11-23 11:59   ` [bug#57431] [PATCH v3 3/3] gnu: Add python-pyqtwebengine, version 6.6.0 Herman Rimm via Guix-patches via
2023-12-22 16:14   ` bug#57431: [PATCH v3 1/3] gnu: Add python-pyqt6-sip Ludovic Courtès
2023-11-30  9:50 ` [bug#57431] [PATCH]: Add PyQt 6 chris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm01kcwt.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=57431@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    --cc=andreas@enge.fr \
    --cc=herman@rimm.ee \
    --cc=iyzsong@envs.net \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).