From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id SFefAhFKgWXHLgAAkFu2QA (envelope-from ) for ; Tue, 19 Dec 2023 08:45:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +F+wOBBKgWVzJQEA62LTzQ (envelope-from ) for ; Tue, 19 Dec 2023 08:45:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702971920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ULK4NL6+MqeYC3rWDjjboyAfkcSXTmCU5Xw+sUKyDzM=; b=gGXFZrU9MT7BuyBw/b+vrw4/yIgUkr+MzAFfskTe6fqpClsc37kUYKgaI154Cyzwt4Kz+8 RCF+dI2id4fE5CprKp9I63DbQlZ/YEps0lnT85mV0T1qCxFYompRsKmfTVGPbyQUQJJA6+ G7H+2+DvkD6sRAo/gVYegA87wfI2DenHZIFKX4XnOR1P5ryJWWQAh15/K2PgdTvPw4YjCx VtaHCBYwMRmSxhelTyy9cJaQteB3VLPVQZNv/q8iHw4rpY824U/kaevLjHhKTHDM/4BP0u 3NNYMLtST+4wDKryXNk/iScDpFgY+rf8MYnYS9YMtNgzm2+PTu/iRXlHQqM9kQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702971920; a=rsa-sha256; cv=none; b=GL8oHDegamlv8qoHx4kDOFRMOSsLljpI3QZ+guUaojlXyYPpAXbNkBLPvMqgMOA3vgrTsi Xxhb2Z+agWzA7Uiim1FX8OTf/vnFs2oOJDbs8be+Y4ZwHGYitaTyy3xh0aT4FWsQXT9JUM tjBeKBSTTkN9sbYdeHCCb+mvEx2wfjFKLcGDvE4LOkGKY+OKuSYlnS2P0nVe3Py65di34o TM9r2jkdE/VGhHCdjSKPfRPoiOP+HhOsYNA8VUuu2IJFJ+GPqnhgQZoMvpEAieis5RMoHz 9ocDBTNmEGq1JrfGr95ezqOAxijQEiI/ZjWf1tkidHqi8zo+xulruo6rBsZR7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44C1E43A10 for ; Tue, 19 Dec 2023 08:45:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFUmm-0005sD-8X; Tue, 19 Dec 2023 02:45:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFUmj-0005pt-9C for guix-patches@gnu.org; Tue, 19 Dec 2023 02:45:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFUmi-0008T8-Ty for guix-patches@gnu.org; Tue, 19 Dec 2023 02:45:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFUmk-0001Oi-Rs for guix-patches@gnu.org; Tue, 19 Dec 2023 02:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#42338] [PATCH v5 0/9] Composer build-system Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Dec 2023 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42338 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Julien Lepiller , 42338@debbugs.gnu.org Received: via spool by 42338-submit@debbugs.gnu.org id=B42338.17029718425149 (code B ref 42338); Tue, 19 Dec 2023 07:45:02 +0000 Received: (at 42338) by debbugs.gnu.org; 19 Dec 2023 07:44:02 +0000 Received: from localhost ([127.0.0.1]:34335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFUlm-0001Kq-44 for submit@debbugs.gnu.org; Tue, 19 Dec 2023 02:44:02 -0500 Received: from 13.mo583.mail-out.ovh.net ([87.98.182.191]:43019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFUlj-0001KB-Ad for 42338@debbugs.gnu.org; Tue, 19 Dec 2023 02:44:00 -0500 Received: from director2.ghost.mail-out.ovh.net (unknown [10.108.25.63]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 244D12AB8E for <42338@debbugs.gnu.org>; Tue, 19 Dec 2023 07:43:54 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wq7pb (unknown [10.110.178.91]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id D28D81FDFC; Tue, 19 Dec 2023 07:43:52 +0000 (UTC) Received: from ngraves.fr ([37.59.142.97]) by ghost-submission-6684bf9d7b-wq7pb with ESMTPSA id vBrfMLhJgWVSjBQADzcBsA (envelope-from ); Tue, 19 Dec 2023 07:43:52 +0000 X-OVh-ClientIp: 81.67.140.142 In-Reply-To: <87sf3zi1jc.fsf@gnu.org> References: <20200713002055.1553f136@tachikoma.lepiller.eu> <20231102151725.31362-1-ngraves@ngraves.fr> <87sf3zi1jc.fsf@gnu.org> Date: Tue, 19 Dec 2023 08:43:50 +0100 Message-ID: <87plz24oy1.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 5312558712057291458 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtledguddtjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgfgsehtqhertddttdejnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepffduleekjeevteelueffjeefffethffhffeutdettefhleeuleevffejvdfftdffnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugedtrddugedvpdefjedrheelrddugedvrdeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepgedvfeefkeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekfedpmhhouggvpehsmhhtphhouhht X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.69 X-Spam-Score: -6.69 X-Migadu-Queue-Id: 44C1E43A10 X-Migadu-Scanner: mx11.migadu.com X-TUID: PTVJ9eiBd/Fe On 2023-12-18 23:33, Ludovic Court=C3=A8s wrote: > Hi, > > Nicolas Graves skribis: > >> This is the result of my further rework of the composer import and >> build-system. The `guix: import: composer` commits can be squashed >> easily. >> >> This is now tested on 94 php packages with all testing enabled except >> for 3 packages. I will submit these packages as a whole in the >> alphabetical order (the bootstrap order is not worth it IMO) in a new >> guix issue. >> >> Before accepting it, I also would like to propose a change of >> names. If me make an analogy with python: >> tool: pip <-> composer >> package hub: pypi <-> packagist >> build-system: python/pyproject <-> php >> >> Since we only take about 90 lines of real composer code, I would >> rather call the build-system php-build-system.=20 >> Same thing: instead of `guix import composer` we should rather call >> `guix import packagist`. Do you have an opinion on this? I guess now that's in the code, we can keep it as is, but that's sad we didn't get to discuss on this.=20 >> >> If that's OK, I'll change it with the next (and hopefully last!) >> version of this build system. >> >> Nicolas Graves (9): >> guix: import: Add composer importer. >> gnu: Add composer-classloader. >> guix: Add composer-build-system. >> guix: import: composer: Use memoization. >> guix: import: composer: Fix json->require. >> guix: import: composer: More robust string->license. >> guix: import: composer: Modern inputs formatting. >> guix: import: composer: Full rewrite composer-fetch. >> gnu: composer-build-system: Full check phase rewrite. > > In the interest of moving forward, I pushed this: > > 6454788a5c build-system/composer: Do not import host-side Guile-JSON mo= dules. > 9dab758791 build-system: Add =E2=80=98composer-build-system=E2=80=99. > e8fd78d54e gnu: Add composer-classloader. > b7e3945283 guix: import: Add composer importer. > > I squashed the importer commits. > > However, I also add to make way too many fixes to my taste: adding > missing #:use-module, fixing unbound variables (guessing=E2=80=A6), fixing > typos, untangling and build system commit that was fixing things in the > importer, fixing =E2=80=98tests/composer.scm=E2=80=99 which wouldn=E2=80= =99t pass, fixing a case > where the importer would return a single value instead of two (breaking > recursive imports), and probably others that I forgot. Not great. > > Could you please take a closer look and see whether anything is amiss at > this point? Not great indeed, seemed to work fine on my end, will take a look. I hope I didn't send a different patch series than intended.=20 > > Next, which PHP packages do we add? Julien initially submitted 30ish of > them, should we take those? Or are you planning to submit a separate > set? I have a set of 94-97 packages, I've sent them in an email to you and Julien (an email from ngraves@ngraves.fr on november 2nd), these should work with this set of commits. Will cut that in commits and submit them quickly.=20 > > It would also be nice if the updater would fill in the =E2=80=98inputs=E2= =80=99 fields > of : that would allow =E2=80=98guix refresh -u=E2=80=99 = to > automatically update inputs. I will first focus on fixes and packages. > > Thanks in advance! > > Ludo=E2=80=99. --=20 Best regards, Nicolas Graves