From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uMbQKA0Mu2XrOgAAqHPOHw:P1 (envelope-from ) for ; Thu, 01 Feb 2024 04:12:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id uMbQKA0Mu2XrOgAAqHPOHw (envelope-from ) for ; Thu, 01 Feb 2024 04:12:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=diwbOONt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706757133; a=rsa-sha256; cv=none; b=qguIpjIN2QhPi722d25JOWBeq3KiW88/CeIiT8m9dnh7qUTtP/WbzBqr1jFoQ/6YOXsGxC Dy5mRsBWo2AORIQqhL9caU5FoHngG9iupoHs7qUaJYj3bprMkb5snTQgo/DMkLwFtqZAps pJchu3XFyJbhJUdQNcFk5mo9sfoAfggEyU4Y5VbbM4REl6y6PE+P034XJ7asKhDfAs7LPz 9y8zT8FRU/vLbBgN3KezwjMKeXPmm1ehZvnKZiuJDN5rzdQZFCvZU5zEGL0KHmeJ4Vz2kB w/1TVQMPN+5lmDXk/XDessTMMiTLrKVFQDoh4jQGKqCIeeiwWcOQM0Q3dDxlUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=diwbOONt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706757133; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=egFq0nGDgFntLbHqEZ4CvONkPjyuJIi1k926UHHMWIY=; b=jpl3kPt52T8oDfguLUnI3OVZQSaG5eGfEy/ZLFzOWnN1ldrZOuueSiv3OGR82ZvGuM97oV Zr/S5hgWltBgsGEY9WxdRl+JEY1wBkwcyn67WrjhQZnNBjSlBpWxYOdFmCzVKztbZEfnAI R0w3HTB1X0ISo+ZGBVGqwkjEoAeoeG5DRkZHLMl2gTzgXTMAd6u3zCwLzFOKY/bGhr31Ej T3UllDmUzukTbM5arqoCrZ6n2VDakL8zKgHzfzI+i7c1Cu3t1oP1QEV1jGO5GYdaGaUj6t WGzeICW1bayzoFUUWuh3uPinEcWycMn9mDdos39/4WPzkWweeyOBrvIn7jxqVA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57F62F996 for ; Thu, 1 Feb 2024 04:12:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVNUa-0003FU-9R; Wed, 31 Jan 2024 22:11:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVNUX-0003FI-18 for guix-patches@gnu.org; Wed, 31 Jan 2024 22:11:53 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVNUW-0002Q5-Ox for guix-patches@gnu.org; Wed, 31 Jan 2024 22:11:52 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVNUg-00085X-Ib for guix-patches@gnu.org; Wed, 31 Jan 2024 22:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61946] [PATCH 0/6] gnu: golang: Add minify Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Feb 2024 03:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher Cc: 61946@debbugs.gnu.org Received: via spool by 61946-submit@debbugs.gnu.org id=B61946.170675706731026 (code B ref 61946); Thu, 01 Feb 2024 03:12:02 +0000 Received: (at 61946) by debbugs.gnu.org; 1 Feb 2024 03:11:07 +0000 Received: from localhost ([127.0.0.1]:39409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVNTn-00084L-Av for submit@debbugs.gnu.org; Wed, 31 Jan 2024 22:11:07 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:37966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVNTl-00084B-7z for 61946@debbugs.gnu.org; Wed, 31 Jan 2024 22:11:06 -0500 Date: Thu, 01 Feb 2024 11:10:39 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1706757004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=egFq0nGDgFntLbHqEZ4CvONkPjyuJIi1k926UHHMWIY=; b=diwbOONt37p0aGhDa7KwrYDT/8Z6weZ0SMqBJ+7OZIIM0ptiLXM05TUvaPeDAylstBcH4G qL9BhpK9yt0ZndHsL5cSCmh8CbEOE/wgs//oUdxOiRXuLnDTd87IhQD9YNQ7aK9xQMKOPt T2B58AmEMSt9aRWBFPuUqTTJgLfL1kgJgEvs8uuIg2gTXKSkAGANRHl4XwHnFWJFldyzyB McmEpdQylY+5NckYKcnuhy8neHwXwi7PHqah3XcNkpqYCQpy978ufuyKCdEndVTKW3yb4k iEfZM0atdgK7FUj8fzd742SXVAo2Z/zW6ddJRGsoZ4Uw+IkuFahXKps46VUAGQ== Message-ID: <87plxg5174.wl-hako@ultrarare.space> In-Reply-To: <87v87as96e.fsf@gmail.com> References: <87v87as96e.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -7.17 X-Migadu-Queue-Id: 57F62F996 X-Migadu-Spam-Score: -7.17 X-TUID: EPfkHPayWlsv Hi Sharlatan, On Wed, 31 Jan 2024 07:17:29 +0800, Sharlatan Hellseher wrote: > > [1 ] > > Hi Thomas and Hilton, > > I've tried to resolved all highlights which Hilton pointed out and from > some investigation I've left with 3 pushed patches. > > - present [3/3] > - [X] go-github-com-tdewolff-parse-v2 > - [X] go-github-com-tdewolff-test > - [X] go-github-com-tdewolff-minify-v2 > > - added to golang-xyz.scm [2/2] > - [X] go-github-com-djherbis-atime > - [X] go-github-com-matryer-try > > And the minify looks like this with inherit and modification: > > --8<---------------cut here---------------start------------->8--- > (define-public minify > (package > (inherit go-github-com-tdewolff-minify-v2) > (name "minify") > (arguments > (substitute-keyword-arguments > (package-arguments go-github-com-tdewolff-minify-v2) > ((#:install-source? _ #t) #f) > ((#:import-path _ "github.com/tdewolff/minify/v2") > "github.com/tdewolff/minify/cmd/minify"))) I think there's no need to supply a default value to #:import-path since all Go packages should have it in their arguments list. > (inputs > (list go-github-com-djherbis-atime > go-github-com-dustin-go-humanize > go-github-com-fsnotify-fsnotify > go-github-com-matryer-try > go-github-com-spf13-pflag)))) > --8<---------------cut here---------------end--------------->8--- And we can avoid the inherited propagated-inputs. I have adjusted the definition to the following, does this look good to you? --8<---------------cut here---------------start------------->8--- (define-public minify (let ((base go-github-com-tdewolff-minify-v2)) (package (inherit base) (name "minify") (arguments (substitute-keyword-arguments (package-arguments base) ((#:install-source? _ #t) #f) ((#:import-path _) "github.com/tdewolff/minify/cmd/minify"))) (inputs (modify-inputs (package-propagated-inputs base) (prepend go-github-com-djherbis-atime go-github-com-dustin-go-humanize go-github-com-fsnotify-fsnotify go-github-com-matryer-try go-github-com-spf13-pflag))) (propagated-inputs '())))) --8<---------------cut here---------------end--------------->8--- Thanks