From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: Andy Tai <atai@atai.org>
Cc: 68890@debbugs.gnu.org, skyvine@protonmail.com
Subject: [bug#68890] [PATCH v2] gnu: pspp: Update to 2.0.0
Date: Sun, 25 Feb 2024 16:06:25 +0100 [thread overview]
Message-ID: <87plwkk2ha.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <85490b486948461bf2c14003c23602bf0f95bdc5.1708851816.git.atai@atai.org> (Andy Tai's message of "Sun, 25 Feb 2024 01:04:01 -0800")
Hello,
Andy Tai <atai@atai.org> writes:
> * gnu/packages/statistics.scm (pspp): Update to 2.0.0
> [arguments](phases): Patch test case to skip failed test due to locale
>
> Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9
> ---
> gnu/packages/statistics.scm | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 01d5e25a1a..b77f167c03 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -115,7 +115,7 @@ (define-module (gnu packages statistics)
> (define-public pspp
> (package
> (name "pspp")
> - (version "1.4.1")
> + (version "2.0.0")
> (source
> (origin
> (method url-fetch)
> @@ -123,12 +123,18 @@ (define-public pspp
> version ".tar.gz"))
> (sha256
> (base32
> - "0lqrash677b09zxdlxp89z6k02y4i23mbqg83956dwl69wc53dan"))))
> + "1pyqlab9kw65wxc8pilcwb64l18w37xxdg3r6n287c7mda4cpxm8"))))
> (build-system gnu-build-system)
> (arguments
> (list #:phases
> #~(modify-phases %standard-phases
> - (add-before 'check 'prepare-tests
> + (add-after 'unpack 'patch-test-suite
> + (lambda _
> + (substitute* "tests/output/tex.at"
> + (("AT_CHECK\\(\\[LC_ALL=C.UTF-8 pspp")
> + "dnl AT_CHECK([LC_ALL=C.UTF-8 pspp"))
> + #t))
Nitpick: trailing #T are no longer recommended at the end of phases. You
can remove this one.
> + (add-before 'check 'prepare-tests
> ;; Prevent irrelevant errors that cause test output mismatches:
> ;; ‘Fontconfig error: No writable cache directories’
> (lambda _
> @@ -149,7 +155,7 @@ (define-public pspp
> `(,glib "bin") ;for glib-genmarshal
> perl
> pkg-config
> - python-2 ;for tests
> + python-3 ;for tests
This change should appear in the commit message.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2024-02-25 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 7:34 [bug#68890] [PATCH] gnu: pspp: Update to 2.0.0 Andy Tai
2024-02-22 23:56 ` Skyler Ferris via Guix-patches via
2024-02-23 0:35 ` Andy Tai
2024-02-23 21:20 ` Skyler Ferris via Guix-patches via
2024-02-25 9:04 ` [bug#68890] [PATCH v2] " Andy Tai
2024-02-25 15:06 ` Nicolas Goaziou via Guix-patches via [this message]
2024-02-25 18:07 ` [bug#68890] [PATCH v3] " Andy Tai
2024-02-25 23:45 ` [bug#68890] [PATCH v4] " Andy Tai
2024-02-27 10:21 ` bug#68890: " Ludovic Courtès
2024-02-26 19:48 ` [bug#68890] passes QA Andy Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plwkk2ha.fsf@nicolasgoaziou.fr \
--to=guix-patches@gnu.org \
--cc=68890@debbugs.gnu.org \
--cc=atai@atai.org \
--cc=mail@nicolasgoaziou.fr \
--cc=skyvine@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).