unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 69432@debbugs.gnu.org
Subject: [bug#69432] [PATCH 3/3] website: Use Linux Libertine for the body of the manual.
Date: Wed, 28 Feb 2024 08:56:32 +0100	[thread overview]
Message-ID: <87plwh2f9r.fsf@pelzflorian.de> (raw)
In-Reply-To: <20240227213835.21147-3-ludo@gnu.org> ("Ludovic Courtès"'s message of "Tue, 27 Feb 2024 22:38:35 +0100")

Hi Ludo.  Serif fonts are fine, although they might not be more readable
as is often claimed.

Ludovic Courtès <ludo@gnu.org> writes:
> * website/static/base/css/manual.css: New @fontface entries for Linux

Nitpick; below you have written @font-face with a hyphen.  I have not
checked if hyphens are required, but MDN also writes @font-face with a
hyphen.

More importantly:

> +@font-face {
> +    font-family: 'Linux Libertine O';
> +    src: url('../fonts/Linux Libertine O_R.ttf') format('truetype');
> +    font-weight: normal;
> +    font-style: normal;
> +}

The files are at

src: url('../fonts/LinLibertine_R.ttf') format('truetype');

without a space, otherwise I get HTTP error 404.


Also, don’t forget your copyright headers for .guix.scm.

Regards,
Florian




  reply	other threads:[~2024-02-28  7:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 16:51 [bug#69432] [PATCH 0/3] Change fonts of the on-line manual Ludovic Courtès
2024-02-27 21:38 ` pelzflorian (Florian Pelz)
2024-02-27 21:38 ` [bug#69432] [PATCH 1/3] website: Adjust style of web site builder Ludovic Courtès
2024-02-27 21:38   ` [bug#69432] [PATCH 2/3] website: Use Fira Sans for section headings only Ludovic Courtès
2024-02-27 21:38   ` [bug#69432] [PATCH 3/3] website: Use Linux Libertine for the body of the manual Ludovic Courtès
2024-02-28  7:56     ` pelzflorian (Florian Pelz) [this message]
2024-02-29 21:41       ` Ludovic Courtès
2024-02-29 21:47         ` [bug#69432] [PATCH guix-artwork v2 1/3] website: Adjust style of web site builder Ludovic Courtès
2024-02-29 21:47           ` [bug#69432] [PATCH guix-artwork v2 2/3] website: Use Fira Sans for section headings only Ludovic Courtès
2024-02-29 21:47           ` [bug#69432] [PATCH guix-artwork v2 3/3] website: Use Linux Libertine for the body of the manual Ludovic Courtès
2024-03-01 11:51             ` pelzflorian (Florian Pelz)
2024-03-02 15:01               ` bug#69432: " Ludovic Courtès
2024-02-28  8:06   ` [bug#69432] [PATCH 1/3] website: Adjust style of web site builder pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plwh2f9r.fsf@pelzflorian.de \
    --to=pelzflorian@pelzflorian.de \
    --cc=69432@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).