From: Z572 <zhengjunjie@iscas.ac.cn>
To: Vagrant Cascadian <vagrant@reproducible-builds.org>
Cc: 72387-done@debbugs.gnu.org
Subject: bug#72387: Fix reproducible build for readymedia
Date: Thu, 01 Aug 2024 23:56:07 +0800 [thread overview]
Message-ID: <87plqsw82w.fsf@iscas.ac.cn> (raw)
In-Reply-To: <87r0batqek.fsf@wireframe> (Vagrant Cascadian's message of "Tue, 30 Jul 2024 16:24:03 -0700")
[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]
Vagrant Cascadian <vagrant@reproducible-builds.org> writes:
> The attached patch should fix build reproducibility issues of
> "readymedia" by avoiding embedding the running kernel version of the
> build machine.
>
> This was one of the examples used in the Reproducible Builds patch
> session On July 11th!
>
> https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024
>
> live well,
> vagrant
>
> [2. text/x-diff; 0001-gnu-readymedia-Fix-reproducible-build.patch]
> From e40dc4bc9633a44fc10ea49007618a41fa598d99 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Date: Wed, 3 Jul 2024 14:00:34 -0700
> Subject: [PATCH] gnu: readymedia: Fix reproducible build.
>
> * gnu/packages/upnp.scm (readymedia)[configure-flags]: Avoid embedding kernel
> version.
> ---
> gnu/packages/upnp.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..5514b3632b 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -150,7 +150,8 @@ (define-public readymedia
> (base32 "1al04jx72bxwqch1nv9lx536mb6pvj7pgnqzy6lm32q6xa114yr2"))))
> (build-system gnu-build-system)
> (arguments
> - `(#:configure-flags '("--with-os-name=Linux") ; uname -s
> + `(#:configure-flags '("--with-os-name=Linux" ; uname -s
> + "--with-os-version=") ; uname -r
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch-source
>
> base-commit: 2aa0127d4e3d2363c04caab88137b070b6cf1318
Thanks, push, close.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2024-08-01 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 23:24 [bug#72387] Fix reproducible build for readymedia Vagrant Cascadian
2024-08-01 15:56 ` Z572 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plqsw82w.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=72387-done@debbugs.gnu.org \
--cc=vagrant@reproducible-builds.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).