unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Noé Lopez via Guix-patches via" <guix-patches@gnu.org>
To: 74147@debbugs.gnu.org
Subject: [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3.
Date: Fri, 01 Nov 2024 23:35:24 +0100	[thread overview]
Message-ID: <87plnebn0z.fsf@xn--no-cja.eu> (raw)
In-Reply-To: <cover.1730412151.git.sepeth@fastmail.com>

Hi Doğan,

Thank you for your patch, here are a few suggestions:

>               (uri (git-reference
>                     (url "https://github.com/tree-sitter/tree-sitter")
>-                    (commit "0e4ff0bb27edf37b76fc7d35aa768b02cf4392ad")))
>+                    (commit "v0.24.3")))
>               (file-name (git-file-name name version))
>               (sha256

You can use “string-append” to avoid repeating the version:
(commit (string-append "v" commit))

As a result of updating tree-sitter, the ”tree-sitter-cli” package has
stopped building for me, it is recommended that you check that
dependencies of tree-sitter don’t fail to build as a result of the
update, see “info (guix) Submitting Patches” step 9.

Can you send an updated patch?

Thanks for your work,
Noé Lopez

Disclaimer: I am not a guix committer, just a random person trying to help.




      parent reply	other threads:[~2024-11-01 22:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 22:02 [bug#74147] [PATCH] gnu: tree-sitter: Update to 0.24.3 Doğan Çeçen
2024-10-31 22:02 ` [bug#74148] [PATCH 1/1] " Doğan Çeçen
2024-11-01 22:35 ` Noé Lopez via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plnebn0z.fsf@xn--no-cja.eu \
    --to=guix-patches@gnu.org \
    --cc=74147@debbugs.gnu.org \
    --cc=noe@xn--no-cja.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).