From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id GLdBK0YVMmcBrQAAqHPOHw:P1 (envelope-from ) for ; Mon, 11 Nov 2024 14:31:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id GLdBK0YVMmcBrQAAqHPOHw (envelope-from ) for ; Mon, 11 Nov 2024 15:31:34 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=m5VhLVCg; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OAPTODDW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731335494; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+NAYtaJyXNFdQ02lM/3NTobEjDYZR5lXMQvnYmsWjGU=; b=dGInfwIGxWAi1Euw2yYOI4YNIyje4xS3k9kWpa5etqbLwjTJ6wetvT6YIy54trpkjZ2r8e z4xKnUL/m7tJ4vjIMw2I+Doi91hJI6w6vzJHm71bQ3prEJ7q4MW5FnU+d82OsTPatdeGAX C/sHNpblqWisEfi29s7VYb+RAqCmJEkUbH0hvhKKmpWJcsfEWKu8uFbG0ojvPrcjOvs65c tdl2GR9yq4b963cbs6CF2GjJ9zj2cnwUkTFva2AbS4F9iLgKAIgdGH5C7mS2QJIdH4oYIc R+7wytOBk5zzkdwSbpruuXhVYK+nThIcCeHQKi+JB761FMdm8pq1JTQS2Al87A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731335494; a=rsa-sha256; cv=none; b=DLDCjpRnhqENeXmDqXmh72hmQeij9+BUXvQQmtqNk+kueqQck/PMzlmRWvyXOMZ2MCnvbD Ar/mk9z7indx1bbLPJdalkqL2N+4KLYpVmkF4QIoJyTrbqVBIKOVBeXQ6ypBERRN4UtDGG E+Rk5TjtniOJ6hU9NOcDyT3+zMM1972oD8N4BHGw+hyTjIJiQ2VHcXEiaGuOO8uzumrzgU niLR55XCHMZ+txq4Tks49i4qepk+mzJiyxpH1GKhbc/hlgfM1ZZEEhhTp5x2T4yMIPa87Q jBsTAvFxbcT++uctsnaftd5r2VdQgag+u00dgwo5T/mkiFvKx9oBxda+EBKEPw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=m5VhLVCg; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OAPTODDW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB0BD55695 for ; Mon, 11 Nov 2024 15:31:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAVRn-00068k-Ru; Mon, 11 Nov 2024 09:31:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAVRY-00065W-U7 for guix-patches@gnu.org; Mon, 11 Nov 2024 09:31:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAVRW-0008Qm-R0 for guix-patches@gnu.org; Mon, 11 Nov 2024 09:31:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=+NAYtaJyXNFdQ02lM/3NTobEjDYZR5lXMQvnYmsWjGU=; b=m5VhLVCgyJ3jKoCuAwo83rvhS3nr5MF94YPBkl09g02Z5T6qB794+YgqdlupliDAIrQ44sUPWjdHaBz6eK6OIdmLJ+ftAYJOZUiyR+oVy93moPaZqMgHF1Cay43v1T0avQAiA990NTH5uPz3GBSUu/LhD6OrJrSdNWiybj6HsT8Apv7tfQ6ay1wPv0K6lm4Ambxhiqsh3QxCFS8Cw7aJz/VxZ97D5Ovxf+FsItGjEk9EzWjCmkpBA7asjfA4wg1aHeYmE6LD28caYW3L9gmH/fYnX3a4W0T7ee258i4BiunwTm9v7qmLYeYK+4mxJkshTtoDPwWnNMoLYrGn/ogqVA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAVRW-0002z0-BB for guix-patches@gnu.org; Mon, 11 Nov 2024 09:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#73981] [PATCH 2/4] gnu: Add libqrtr-glib. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Nov 2024 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73981 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zheng Junjie Cc: 73981@debbugs.gnu.org Received: via spool by 73981-submit@debbugs.gnu.org id=B73981.173133541211309 (code B ref 73981); Mon, 11 Nov 2024 14:31:02 +0000 Received: (at 73981) by debbugs.gnu.org; 11 Nov 2024 14:30:12 +0000 Received: from localhost ([127.0.0.1]:58797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAVQh-0002vJ-FG for submit@debbugs.gnu.org; Mon, 11 Nov 2024 09:30:11 -0500 Received: from mail-pf1-f180.google.com ([209.85.210.180]:46224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAVQe-0002qk-Kw for 73981@debbugs.gnu.org; Mon, 11 Nov 2024 09:30:09 -0500 Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-723f37dd76cso4644888b3a.0 for <73981@debbugs.gnu.org>; Mon, 11 Nov 2024 06:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731335342; x=1731940142; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+NAYtaJyXNFdQ02lM/3NTobEjDYZR5lXMQvnYmsWjGU=; b=OAPTODDWbPKHZ+hClN0ICpeaD9pJCOC8cpym8bW6lAzo5amokqMG423i88wDCu/T1M ZUG0kZNzATeAVJrSHuI72Bw/sOMVUGO4PLAChF3feFPpj+mp6hzBTf6MAwbMAmIPGgTU XrZTwdlevPgbA64eQO79KSEAb2vGeOuDs9orKy7ud4eAgzhlEyM8Fu64knuIZ7dvvzWQ SuSxKc7Gdm1cU3pb1eRCGbdK+qPYpyaJTB3yoww4yT4Kre21hI1c5MWPP624eIeOTl89 JEcP8BIr7A7MZ+oqyzGeQjmfRj568T4wCMdGTEVwHky3g3fjlHiOhKse5eTDQPfxzQ0M sZcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731335342; x=1731940142; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+NAYtaJyXNFdQ02lM/3NTobEjDYZR5lXMQvnYmsWjGU=; b=w1HwepTrgj3vejvamk57IZeXiTvd342RdALElriChNqZrTS1fWZInlNwicS24LkNoj BmqzfvnzOYiTRFzUy+3zLSIYngSOntsEKwgWrCXh26dlA9hdd7NCKGhfnQtux1xKKqEp wWqlx2UZfOWVDUQkT3k4/Tg/no0psEMCyRIFhsKlcwt0wnJtPQ+ThVyvTTiRH3rPFHr/ V30zC25Q5YZQeRRHjNFSkf8j0csDHwgVUR/uJtvpnGzgup9kU5U1mnVyuJ5jvuNYt5H4 tDkUd6MRntGTk78GSTvzP5swVpT8rjJYqUnuI5FJZS8x6p5J2cGufu24rK5+VL2tPGtZ gOuA== X-Gm-Message-State: AOJu0YzkP5mkoPDgaow/mmtjsN4OpjvGdOnYaL7/504aoFYuYWnOh0EG VVDtLJhqWcPE2mD7JxjHZx+HkY9MhbPwCVOePkTo+B6UyOGN4R60ViyoUQ== X-Google-Smtp-Source: AGHT+IGCqgDrQK7b/dJERbob7GYDQHLafuafRil0koGaHKi/VdsCVcX45L/4lA+3tOeWq8MHS1cPgA== X-Received: by 2002:a05:6a00:14d2:b0:71e:4dc5:259e with SMTP id d2e1a72fcca58-72413360343mr17294608b3a.17.1731335342234; Mon, 11 Nov 2024 06:29:02 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724078a433esm9275531b3a.42.2024.11.11.06.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 06:29:01 -0800 (PST) From: Maxim Cournoyer In-Reply-To: (Zheng Junjie's message of "Thu, 24 Oct 2024 15:40:37 +0800") References: Date: Mon, 11 Nov 2024 23:28:55 +0900 Message-ID: <87pln1974o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 1.85 X-Spam-Score: 1.85 X-Migadu-Queue-Id: DB0BD55695 X-Migadu-Scanner: mx13.migadu.com X-TUID: IAao71rIBsPd Zheng Junjie writes: > * gnu/packages/freedesktop.scm (libqrtr-glib): New variable. > > Change-Id: I84e26d0e8f69c8e5bc1c65925792aea296f6a97d > --- > gnu/packages/freedesktop.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm > index a7c740f3d05..321ab2a1d1e 100644 > --- a/gnu/packages/freedesktop.scm > +++ b/gnu/packages/freedesktop.scm > @@ -1932,6 +1932,37 @@ (define-public libmbim > ;; The mbimcli tool is released under the GPLv2+ license. > (list license:lgpl2.0+ license:gpl2+)))) > > +(define-public libqrtr-glib > + (package > + (name "libqrtr-glib") > + (version "1.2.2") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.freedesktop.org/mobile-broadband/libqrtr-glib") Too wide of a line; you should break (source (origin ... as (source (origin ...)) Note that 'guix style' has issues in this regard, which I've reported to our tracker. > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0bfn5kfscli0rrxvmzdl6ix5ikh0kxia7ad83rmh1hksfcwynwlh")))) > + (build-system meson-build-system) > + (inputs > + (list libgudev libmbim)) > + (native-inputs > + (list `(,glib "bin") > + gtk-doc > + pkg-config > + gobject-introspection > + bash-completion)) My package only had (native-inputs (list gobject-introspection gtk-doc pkg-config)) > + (propagated-inputs > + (list glib)) When propagating inputs, we typically leave a comment as to why, as it shouldn't be made without a good reason (it hurts composability in a profile). Typically something like a ;required by some-package.pc inline comment when pkg-config files list them in Requires or Requires.private (the later is consulted when retrieving Cflags with pkg-config... even when using dynamic linking). In my package I had listed it as an 'input'; I hadn't checked for .pc files, but didn't have problems building modem-manager with it. -- Thanks, Maxim