unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Noé Lopez via Guix-patches via" <guix-patches@gnu.org>
To: control@debbugs.gnu.org,74506@debbugs.gnu.org
Subject: [bug#74506] QA review for 74506
Date: Sun, 24 Nov 2024 15:49:10 +0100	[thread overview]
Message-ID: <87plmk8z6h.fsf@xn--no-cja.eu> (raw)
In-Reply-To: <877c8tlfdm.fsf@gmail.com>

user guix
usertag 74506 + reviewed-looks-good
thanks

Guix QA review form submission:
Hi, thanks for your patch!

Everything works well, it is just missing a dot in the commit message,
and a double space between sentences in the description.  I’m sending an
amended patch with these two changes.

Additionally, it is best to avoid adding your packages at the end of the
file to avoid merge conflicts, just put them where you feel like it or
near a related package.

Have a nice day,
Noé Lopez

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package synopsis and descriptions




  reply	other threads:[~2024-11-24 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-23 22:33 [bug#74506] [PATCH] gnu: fonts: Add font-dina 8dcc
2024-11-24 14:49 ` Noé Lopez via Guix-patches via [this message]
2024-11-24 14:53 ` [bug#74506] [PATCH v2] " Noé Lopez via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plmk8z6h.fsf@xn--no-cja.eu \
    --to=guix-patches@gnu.org \
    --cc=74506@debbugs.gnu.org \
    --cc=control@debbugs.gnu.org \
    --cc=noe@xn--no-cja.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).