From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4EG3HBHld2eodAAAe85BDQ:P1 (envelope-from ) for ; Fri, 03 Jan 2025 13:24:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 4EG3HBHld2eodAAAe85BDQ (envelope-from ) for ; Fri, 03 Jan 2025 14:24:33 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=R2sdffyv; dkim=fail ("headers rsa verify failed") header.d=ngraves.fr header.s=ovhmo4487190-selector1 header.b=cDlxnuOD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735910673; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=x5CYmNcxiAqTBgZ15WbTSdu/wg90+aJuPF8kmAA5740=; b=ka+6hcz2MsXfUOkRPll5NefHwgG6st9DSphGwLOndIzGqnYneynjtxvzFOLcsaZDna5Qg6 rKzDBReiElZa/WMAOovYWUwzqq3PahpqFbdM0kImocvj85+QyG1+5lbRVBsR0GiDW3yrai cdwfMNttsGitQ0AJD/wmImS0EZto5ro2P0IHbxUYNsZPeGVgol8JvsAxL78Tu0DYNNNzHg t0rUIx3Lc7zJFT/CfP/OuMLzB1y+ShHlnObfqLaqaJd05Ytno8QOiTSuPeEG1xcPhSleFq 608wcbKsY5xrLnqPR3IyBfLGM4Ry+1Y6fxxynLLaMQxwuEnEB4t3hgCIHYUlDg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=R2sdffyv; dkim=fail ("headers rsa verify failed") header.d=ngraves.fr header.s=ovhmo4487190-selector1 header.b=cDlxnuOD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735910673; a=rsa-sha256; cv=none; b=K3//YI0AUHiR0bcWsTNlZj1RisCXL/YKkO6OjOulSxZ3KIKbs6SlW9lKNVDhjtjvmHm+zC LEvR4qFB0NYRBIjP6Al+owasUUTgsVDqAiylJki4nGnzFbfxhsH7H3kTi1OgtOTkYibA01 qs7R4bSkXTFVOKqBxUKIMe45FXa7ofN18yeXLgkV3lp+YdGZ44/gELQhcBxdOhWeDPeLgY D7kKdnk5aYn7lbEi6xDLUeSilRHTpt3BbTQ/uJBjDDC70T+PCjsdgoNmUe7mh0I+qopTqL NG83mkWDDPS+6t1TMQbFh2gNjB4aispz9MJQQWx6So3+YbC0ePQ1Vvs19BqrdA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D3A2683189 for ; Fri, 03 Jan 2025 14:24:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTheq-0006aC-EQ; Fri, 03 Jan 2025 08:24:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tThen-0006Z6-Ga for guix-patches@gnu.org; Fri, 03 Jan 2025 08:24:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tThem-0005Sb-6q for guix-patches@gnu.org; Fri, 03 Jan 2025 08:24:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=x5CYmNcxiAqTBgZ15WbTSdu/wg90+aJuPF8kmAA5740=; b=R2sdffyvu3siaixuv7+yeEh90iADPOTd4FzwwICfSyPlvTiF78qkJy6I1NJtMibaup8bve3pmw8pOsMzoMkTTSqq2uAzZdosZynthef1Totvfl6QZ19tJHjO3sYOBhjZJ76uJLTwq7YN/FFKwxLVaR+RymFIEK3gaqojcu25fRjCTf6G6BhHQ7PMGzPapcgZTVAhqWr71R/U8JsdxFpVutd6p1E4iZoOdl63h4b1IMvJFg28obRCLZxUiwTWZasRG41/Ze4FsSmYWJqvhpJEmN+MuKQI4cLggzDBNVcRwWd/e1SPuX4IvF4gMwqyhMZIt4XZN7I7zFSw60n3aPnYAQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tThel-000732-UO for guix-patches@gnu.org; Fri, 03 Jan 2025 08:24:04 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75270] [PATCH 1/3] services: greetd: Improve greeter configurations. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Jan 2025 13:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75270 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: muradm , 75270@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 75270-submit@debbugs.gnu.org id=B75270.173591058926970 (code B ref 75270); Fri, 03 Jan 2025 13:24:03 +0000 Received: (at 75270) by debbugs.gnu.org; 3 Jan 2025 13:23:09 +0000 Received: from localhost ([127.0.0.1]:50011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tThds-00070v-Jc for submit@debbugs.gnu.org; Fri, 03 Jan 2025 08:23:08 -0500 Received: from 17.mo582.mail-out.ovh.net ([46.105.36.150]:37149) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tThdp-00070k-5S for 75270@debbugs.gnu.org; Fri, 03 Jan 2025 08:23:06 -0500 Received: from director1.ghost.mail-out.ovh.net (unknown [10.108.2.211]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 4YPklp70DHz1QjK for <75270@debbugs.gnu.org>; Fri, 3 Jan 2025 13:23:02 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-49x8b (unknown [10.110.101.173]) by director1.ghost.mail-out.ovh.net (Postfix) with ESMTPS id D7A141FE87; Fri, 3 Jan 2025 13:23:01 +0000 (UTC) Received: from ngraves.fr ([37.59.142.112]) by ghost-submission-5b5ff79f4f-49x8b with ESMTPSA id pq3qKbXkd2eBJQIAlji3/w (envelope-from ); Fri, 03 Jan 2025 13:23:01 +0000 X-OVh-ClientIp: 90.92.117.144 In-Reply-To: <8ea5f949f8b473c3ec68e7d2f5f40c1152c6c631.1735771462.git.mail@muradm.net> References: <8ea5f949f8b473c3ec68e7d2f5f40c1152c6c631.1735771462.git.mail@muradm.net> Date: Fri, 03 Jan 2025 14:23:01 +0100 Message-ID: <87pll4owui.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 16480359886886200001 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefuddrudefgedgheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepveekleeujedthefgffekleekhffhffetgfdvheekleeuhfehueeljedtjefhvdfgnecukfhppeduvdejrddtrddtrddupdeltddrledvrdduudejrddugeegpdefjedrheelrddugedvrdduuddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejhedvjedtseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkedvmgdpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=x5CYmNcxiAqTBgZ15WbTSdu/wg90+aJuPF8kmAA5740=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1735910583; v=1; b=cDlxnuODHD9y10xkCCKMEiclv0AAhJhV4HCdrhRBRv/KkfT2Ki/i9P1K+TlYtRT3kyzlaOAK /rnt86pXaa3FSG+eG6sNwLI2igjNtI6l74JEkdNqpnJRK9Yvb11y1GiJ0WAqkQVxOTFq+S+TbqK i1yK+D7FkWDkMwURlo4wnDiA2FRiXV0Vgj59lMyw833/AIWTwYFePdAVEAKM/gYve8nCACrYmWy XgpP1KjK6Jne/A+aCHkgDCjr4FWkP5EE+mmFbATltd0tGYxbuSC+Fan7dAv6hbACdJ6GndDmReh MJQ/W9B2WFakKSCQfFigb8L9+Ma3gpVf22Pmvkp/2SaOw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: D3A2683189 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -2.09 X-Spam-Score: -2.09 X-TUID: 1E2t+yMmv427 On 2025-01-02 01:53, muradm wrote: > This improvement focuses on providing common user session scripts > for use by multiple greeters. It also fixes incorrect use of > `XDG_RUNTIME_DIR` for `wlgreet`. `wlgreet` requires compositor to > run. We provide common sway based greeter script, which can be > shared by other graphical greeters. [...] > +(define (make-greetd-sway-greeter-command sway sway-config) > + (let ((sway-bin (file-append sway "/bin/sway"))) > + (program-file > + "greeter-sway-command" > + #~(begin > + (let* ((username (getenv "USER")) > + (useruid (passwd:uid (getpwuid username))) > + (useruid (number->string useruid)) > + ;; /run/user/ won't exist yet > + ;; this will contain WAYLAND_DISPLAY socket file > + ;; and log-file below > + (user-xdg-runtime-dir "/tmp/greeter-xdg-rt") > + (log-file (string-append (number->string (getpid)) ".log")) > + (log-file (string-append user-xdg-runtime-dir "/" > log-file))) Could you explain why this is necessary? If I'm not mistaken, we didn't used a special runtime dir in RDE, and it worked OK. > + (mkdir user-xdg-runtime-dir #o700) > + (setenv "XDG_RUNTIME_DIR" user-xdg-runtime-dir) > + (sleep 1) ;; give time to elogind or seatd > + (dup2 > + (open-fdes > + log-file > + (logior O_CREAT O_WRONLY O_APPEND) > + #o640) > + 1) > + (dup2 1 2) Maybe also here a tiny comment on why this is better than the previous fileno approach. > + (execl #$sway-bin #$sway-bin "-d" "-c" #$sway-config)))))) Also, what about the XDG_CURRENT_DESKTOP setting? Should it not be added with xdg-env too? -- Best regards, Nicolas Graves