[bug#74860] [PATCH 02/10] services: Add ‘log-rotation-service-type’.

["Ludovic Courtès" <ludo@gnu.org>]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>> +@item @code{compression} (default: @code{'gzip})
>> +This is the compression method used for rotated log files, one of
>> +@code{'none}, @code{'gzip}, and @code{'zstd}.
>
> Why not default to zstd?  It's superior to gzip in all regards, as far
> as I know.  We use it already preferably to gzip to compress man pages
> for example.  Perhaps we should consider it as our default compressor
> from now on?

It’s just that it’s the default, conservative choice, and also what
rottlog has been doing.

But yes, why not change to zstd.  I’ll make that change.

> Is there a technical reason for not using define-configuration here?

Not really, habit mostly.

> Otherwise, define-configuration offers superior error checking and
> useful error messages on invalid input types.

I’m not entirely convinced but yeah I’ll do that in v2.

Thanks!

Ludo’.