From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id yAXZJi/Tf2d2MgAAe85BDQ:P1 (envelope-from ) for ; Thu, 09 Jan 2025 13:46:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id yAXZJi/Tf2d2MgAAe85BDQ (envelope-from ) for ; Thu, 09 Jan 2025 14:46:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Z3ObAPX4; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RJcc+Cia; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736430381; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8vXZIHRqtGw9Mwwt2PHRHk2hAr5xzV5fyY8puuhD+NA=; b=JUe+A5ymDC4jsYGXJxgsIHb57uzNy2ylgt+aV0sF7xpMdUsjkFlr+QCU/FC5BgVPB4TLKl YRm+OHVOcOx4j5EO8VCGYjj+FMhqJYtQ06iRO6FnH+P+NqD9lVgBPFGDDhvG81zCh2a432 W4bJ2wgacDIKNeXZIdm2Lecja370e3C97GOepCzVhGHP7pirzGSjDGWZDv7J5xiZVd/o5d qMqZmGUXoTjV8d16Y/CKql6LCIRt8972MKVYMQlBikswn6nH+N83OFQMncNsgfVc/p07Pn SukVoEY8sTJ1Ad+1eXtbFhBk336qhoJ5QPJQq/ElpuHGhB1dW2NFraWt9VB93w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Z3ObAPX4; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RJcc+Cia; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736430381; a=rsa-sha256; cv=none; b=qEt4kDqPWp7gQ0c8O7gtR0DwrfHb3skWI81sWZZ7UkyihpCXJoKmDVjROP5TVfucaXJXxj 5CYTLnpYHZWthRzuDSX236PyWjXg/k01y6cxqA8WlGr7QuijBmyCPyTpUb8zsV56jInlxP vfUl4kgTjIMk/Z3nZ1qMizSYzXA3cL4OJYhxG4rzSCtZvA7BeJjTLu/s5GjreuwO8Laxak 8u9DubwvlQqOBp2NKjgqMKFdwfx46YWeVs+bS0uTlc65J2ITZCPU3ipd0w3IAWynvKFSFb EK8K0GB83muEY/tsT7U6g7Pn85Sah4K/5hKF3VrxNGL8VUSsPYMbx6hFGcF1vg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5730814DD for ; Thu, 09 Jan 2025 14:46:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVsrO-0007Lx-6F; Thu, 09 Jan 2025 08:46:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVsrL-0007LO-Hq for guix-patches@gnu.org; Thu, 09 Jan 2025 08:46:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVsrK-00045B-Cm for guix-patches@gnu.org; Thu, 09 Jan 2025 08:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8vXZIHRqtGw9Mwwt2PHRHk2hAr5xzV5fyY8puuhD+NA=; b=Z3ObAPX4aPEA9Tk94hlzSum80+vmbD04vXXPlpQEpX9HRK/vLyqO2FwvzMUh+tOUA30YfEaeAvixcQcpNMjv2RG+Q+g5Zb4YScEHKgMacoGkNsMRii5pUJnL/GoIXt4jl1Hta6dQwv7BsqPgr8DtG5CnGs1LdnNVLHaLwpvX1N74/PIUJbpw6cfIgTTkvujq9M28TBl4TFO8NXlAGQ8IJ1+WovIw+aURSLgkeF4vFb0vVA3BVORhYUwCQAsYIs4RWrBUKaFr1DliNkW4aB7wYDdzIHB8HxVKYrPC6PetcQfeSBNU5Kw9NQ65qy3iyGDlVSO99x8pFtBPR0iClI6rWA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVsrJ-0000PG-TO for guix-patches@gnu.org; Thu, 09 Jan 2025 08:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#72249] [PATCH 2/2] services: Add xe-guest-utilities-service-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Jan 2025 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Karl Hallsby Cc: 72249@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 72249-submit@debbugs.gnu.org id=B72249.17364303131464 (code B ref 72249); Thu, 09 Jan 2025 13:46:01 +0000 Received: (at 72249) by debbugs.gnu.org; 9 Jan 2025 13:45:13 +0000 Received: from localhost ([127.0.0.1]:51196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVsqX-0000NY-Bd for submit@debbugs.gnu.org; Thu, 09 Jan 2025 08:45:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39528) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVsqU-0000IU-Ql for 72249@debbugs.gnu.org; Thu, 09 Jan 2025 08:45:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVsqP-0003xj-Da; Thu, 09 Jan 2025 08:45:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8vXZIHRqtGw9Mwwt2PHRHk2hAr5xzV5fyY8puuhD+NA=; b=RJcc+CiaFBVkD9AT+gFQ nrTKGggfBU1jWOOs53ncLP0f5V0zgAYmiE9AR6wkv9iIMxrVm+9SDiSvtmF+GryQa50Ltmj0ldQ85 cfhhWRELnXoiT/LtZLffbGbRCX+TU6xQ/Mb5mJN3GeWIsHr3wZwgIkTMPpYw1r8JwiDRCP0QXr/RP jQYIbx2aaLPc2kt8hQ5MDKaLe2+Brq1lVsCG7ZSmCET5Ga54IXSA6CMuw9IbrqkTMlq0rqsVEWOMt BKB7wysv2hwEFh1WbNmr/9xH4UaqSKr+u+Fwy3uccy+qZmcXLzpg/kmxdUObpdOK1Zq7blHo1D7Gz SoAVawfabyFXZg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <05dbe98e7be3b45ddbf4a49df643e35333df78e7.1736366732.git.karl@hallsby.com> (Karl Hallsby's message of "Wed, 8 Jan 2025 14:10:26 -0600") References: <6920fcb2b7edd619b323c7f70d076a7a73ab0463.1736366732.git.karl@hallsby.com> <05dbe98e7be3b45ddbf4a49df643e35333df78e7.1736366732.git.karl@hallsby.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 20 =?UTF-8?Q?Niv=C3=B4se?= an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Van X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 09 Jan 2025 14:45:00 +0100 Message-ID: <87plkwp0df.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 5730814DD X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -1.96 X-Spam-Score: -1.96 X-TUID: Oxy6YHf0vka9 Hello, Karl Hallsby skribis: > * gnu/services/virtualization.scm (xe-guest-utilities-configuration, > xe-guest-utilities-service-type): New variables. > * doc/guix.texi: Document them. > > Change-Id: Ife4e79fa6d1a9d5a21bf7479488884f2a5cf8d56 I=E2=80=99m only looking at the doc side of things. Minor comments: > +@cindex xen > +@cindex xen guest agent =E2=80=9CXen=E2=80=9D, capitalized. > +The Xen guest agent allows a Xen host to control the emulated system. > +The @code{xe-guest-utilities} service runs the agent on Guix guests. I=E2=80=99m surprised it=E2=80=99s all =E2=80=9Cxe-=E2=80=9D, not =E2=80=9C= xen-=E2=80=9D, but I guess that=E2=80=99s the way it is. :-) It would be nice to add a sentence or two about what said utilities do, perhaps with a link to upstream documentation if that helps? > +@item @code{log-file} (default: @code{"/var/log/xe-guest-utilities.log"}) > +Path to @code{xe-guest-utilities} log file. =E2=80=9CName of the @code{xe-guest-utilities} log file.=E2=80=9D (We use the term =E2=80=9Cpath=E2=80=9D for =E2=80=9Csearch paths=E2=80=9D.) Apart from that LGTM! Thanks, Ludo=E2=80=99.