From: Alex Kost <alezost@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26702@debbugs.gnu.org
Subject: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Thu, 04 May 2017 23:03:42 +0300 [thread overview]
Message-ID: <87o9v8crtt.fsf@gmail.com> (raw)
In-Reply-To: <87wpa2gcdx.fsf@fastmail.com> (Marius Bakke's message of "Sun, 30 Apr 2017 17:10:02 +0200")
Marius Bakke (2017-04-30 17:10 +0200) wrote:
>> + (outputs '("out" "tw-kai" "tw-sung"))
>> + (build-system trivial-build-system)
>> + (native-inputs
>> + `(("unzip" ,unzip)))
>> + (arguments
>> + `(#:modules ((guix build utils))
>> + #:builder
>> + (begin
>> + (use-modules (guix build utils))
>> + (let* ((font-dir "/share/fonts/truetype/cns11643")
>> + (out (string-append %output font-dir))
>
> I've changes this to use (assoc-ref outputs "out") instead of the
> magical %output.
I would leave the magical %output :-) Besides (assoc-ref outputs "out")
wouldn't work here; you probably meant (assoc-ref %outputs "out").
Regarding “%output” vs “(assoc-ref %outputs "out")”: I always prefer the
former (Ludovic prefers the latter). Why does “%output” exist anyway,
if not for using it?
--
Alex
next prev parent reply other threads:[~2017-05-04 20:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 18:53 bug#26702: [PATCH 1/2] gnu: Add font-cns11643 Brendan Tildesley
2017-04-30 15:10 ` Marius Bakke
2017-04-30 18:07 ` Kei Kebreau
2017-05-01 14:43 ` Brendan Tildesley
2017-05-01 22:34 ` Marius Bakke
2017-05-04 20:15 ` Alex Kost
2017-05-05 14:51 ` Marius Bakke
2017-05-04 20:12 ` Alex Kost
2017-05-04 20:03 ` Alex Kost [this message]
2017-05-05 7:55 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9v8crtt.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=26702@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).